* [PATCH] mfd: tps65217: fix nonstandard declaration
@ 2016-09-14 8:13 Arnd Bergmann
2016-09-14 8:37 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-09-14 8:13 UTC (permalink / raw)
To: Lee Jones
Cc: Arnd Bergmann, Tony Lindgren, Marcin Niestroj, Grygorii Strashko,
linux-omap, linux-kernel
The tps65217 gained a new warning when building with W=1:
drivers/mfd/tps65217.c:85:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]
This fixes it by putting the 'inline' modifier before 'const'.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 262d5cc6ceb2 ("mfd: tps65217: Add support for IRQs")
---
drivers/mfd/tps65217.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c
index 57c87412106f..9a4d8684dd32 100644
--- a/drivers/mfd/tps65217.c
+++ b/drivers/mfd/tps65217.c
@@ -82,7 +82,7 @@ static void tps65217_irq_sync_unlock(struct irq_data *data)
mutex_unlock(&tps->irq_lock);
}
-static const inline struct tps65217_irq *
+static inline const struct tps65217_irq *
irq_to_tps65217_irq(struct tps65217 *tps, struct irq_data *data)
{
return &tps65217_irqs[data->hwirq];
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mfd: tps65217: fix nonstandard declaration
2016-09-14 8:13 [PATCH] mfd: tps65217: fix nonstandard declaration Arnd Bergmann
@ 2016-09-14 8:37 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2016-09-14 8:37 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Tony Lindgren, Marcin Niestroj, Grygorii Strashko, linux-omap,
linux-kernel
On Wed, 14 Sep 2016, Arnd Bergmann wrote:
> The tps65217 gained a new warning when building with W=1:
>
> drivers/mfd/tps65217.c:85:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]
>
> This fixes it by putting the 'inline' modifier before 'const'.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 262d5cc6ceb2 ("mfd: tps65217: Add support for IRQs")
> ---
> drivers/mfd/tps65217.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
FYI: I plan to fix all W=1 and look at W=2 warnings today anyway.
> diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c
> index 57c87412106f..9a4d8684dd32 100644
> --- a/drivers/mfd/tps65217.c
> +++ b/drivers/mfd/tps65217.c
> @@ -82,7 +82,7 @@ static void tps65217_irq_sync_unlock(struct irq_data *data)
> mutex_unlock(&tps->irq_lock);
> }
>
> -static const inline struct tps65217_irq *
> +static inline const struct tps65217_irq *
> irq_to_tps65217_irq(struct tps65217 *tps, struct irq_data *data)
> {
> return &tps65217_irqs[data->hwirq];
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-14 8:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-14 8:13 [PATCH] mfd: tps65217: fix nonstandard declaration Arnd Bergmann
2016-09-14 8:37 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox