* [PATCH 1/2] mfd: fsl-imx25-tsadc: Fix module autoload when registered via OF
@ 2016-10-14 15:40 Javier Martinez Canillas
2016-10-14 15:40 ` [PATCH 2/2] mfd: hi655x-pmic: " Javier Martinez Canillas
2016-10-26 12:40 ` [PATCH 1/2] mfd: fsl-imx25-tsadc: " Lee Jones
0 siblings, 2 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-10-14 15:40 UTC (permalink / raw)
To: linux-kernel; +Cc: Javier Martinez Canillas, Lee Jones
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/mfd/fsl-imx25-tsadc.ko | grep alias
alias: platform:mx25-tsadc
After this patch:
$ modinfo drivers/mfd/fsl-imx25-tsadc.ko | grep alias
alias: platform:mx25-tsadc
alias: of:N*T*Cfsl,imx25-tsadcC*
alias: of:N*T*Cfsl,imx25-tsadc
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/mfd/fsl-imx25-tsadc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c
index 77b2675cf8f5..ac430a396a89 100644
--- a/drivers/mfd/fsl-imx25-tsadc.c
+++ b/drivers/mfd/fsl-imx25-tsadc.c
@@ -187,6 +187,7 @@ static const struct of_device_id mx25_tsadc_ids[] = {
{ .compatible = "fsl,imx25-tsadc" },
{ /* Sentinel */ }
};
+MODULE_DEVICE_TABLE(of, mx25_tsadc_ids);
static struct platform_driver mx25_tsadc_driver = {
.driver = {
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] mfd: hi655x-pmic: Fix module autoload when registered via OF
2016-10-14 15:40 [PATCH 1/2] mfd: fsl-imx25-tsadc: Fix module autoload when registered via OF Javier Martinez Canillas
@ 2016-10-14 15:40 ` Javier Martinez Canillas
2016-10-26 12:40 ` Lee Jones
2016-10-26 12:40 ` [PATCH 1/2] mfd: fsl-imx25-tsadc: " Lee Jones
1 sibling, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-10-14 15:40 UTC (permalink / raw)
To: linux-kernel; +Cc: Javier Martinez Canillas, Lee Jones
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/mfd/hi655x-pmic.ko | grep alias
After this patch:
$ modinfo drivers/mfd/hi655x-pmic.ko | grep alias
alias: of:N*T*Chisilicon,hi655x-pmicC*
alias: of:N*T*Chisilicon,hi655x-pmic
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/mfd/hi655x-pmic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
index 0fc62995695b..ba706adee38b 100644
--- a/drivers/mfd/hi655x-pmic.c
+++ b/drivers/mfd/hi655x-pmic.c
@@ -169,6 +169,7 @@ static const struct of_device_id hi655x_pmic_match[] = {
{ .compatible = "hisilicon,hi655x-pmic", },
{},
};
+MODULE_DEVICE_TABLE(of, hi655x_pmic_match);
static struct platform_driver hi655x_pmic_driver = {
.driver = {
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] mfd: hi655x-pmic: Fix module autoload when registered via OF
2016-10-14 15:40 ` [PATCH 2/2] mfd: hi655x-pmic: " Javier Martinez Canillas
@ 2016-10-26 12:40 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2016-10-26 12:40 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel
On Fri, 14 Oct 2016, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/mfd/hi655x-pmic.ko | grep alias
>
> After this patch:
>
> $ modinfo drivers/mfd/hi655x-pmic.ko | grep alias
> alias: of:N*T*Chisilicon,hi655x-pmicC*
> alias: of:N*T*Chisilicon,hi655x-pmic
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/mfd/hi655x-pmic.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
> diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> index 0fc62995695b..ba706adee38b 100644
> --- a/drivers/mfd/hi655x-pmic.c
> +++ b/drivers/mfd/hi655x-pmic.c
> @@ -169,6 +169,7 @@ static const struct of_device_id hi655x_pmic_match[] = {
> { .compatible = "hisilicon,hi655x-pmic", },
> {},
> };
> +MODULE_DEVICE_TABLE(of, hi655x_pmic_match);
>
> static struct platform_driver hi655x_pmic_driver = {
> .driver = {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] mfd: fsl-imx25-tsadc: Fix module autoload when registered via OF
2016-10-14 15:40 [PATCH 1/2] mfd: fsl-imx25-tsadc: Fix module autoload when registered via OF Javier Martinez Canillas
2016-10-14 15:40 ` [PATCH 2/2] mfd: hi655x-pmic: " Javier Martinez Canillas
@ 2016-10-26 12:40 ` Lee Jones
1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2016-10-26 12:40 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel
On Fri, 14 Oct 2016, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/mfd/fsl-imx25-tsadc.ko | grep alias
> alias: platform:mx25-tsadc
>
> After this patch:
>
> $ modinfo drivers/mfd/fsl-imx25-tsadc.ko | grep alias
> alias: platform:mx25-tsadc
> alias: of:N*T*Cfsl,imx25-tsadcC*
> alias: of:N*T*Cfsl,imx25-tsadc
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/mfd/fsl-imx25-tsadc.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
> diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c
> index 77b2675cf8f5..ac430a396a89 100644
> --- a/drivers/mfd/fsl-imx25-tsadc.c
> +++ b/drivers/mfd/fsl-imx25-tsadc.c
> @@ -187,6 +187,7 @@ static const struct of_device_id mx25_tsadc_ids[] = {
> { .compatible = "fsl,imx25-tsadc" },
> { /* Sentinel */ }
> };
> +MODULE_DEVICE_TABLE(of, mx25_tsadc_ids);
>
> static struct platform_driver mx25_tsadc_driver = {
> .driver = {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-26 12:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-14 15:40 [PATCH 1/2] mfd: fsl-imx25-tsadc: Fix module autoload when registered via OF Javier Martinez Canillas
2016-10-14 15:40 ` [PATCH 2/2] mfd: hi655x-pmic: " Javier Martinez Canillas
2016-10-26 12:40 ` Lee Jones
2016-10-26 12:40 ` [PATCH 1/2] mfd: fsl-imx25-tsadc: " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox