* [PATCH] x86/boot: Remove always empty $(USERINCLUDE)
@ 2016-11-03 9:47 Paul Bolle
2016-11-03 9:51 ` Paul Bolle
2016-11-07 8:52 ` [tip:x86/boot] x86/boot/build: " tip-bot for Paul Bolle
0 siblings, 2 replies; 4+ messages in thread
From: Paul Bolle @ 2016-11-03 9:47 UTC (permalink / raw)
To: H. Peter Anvin, Thomas Gleixner, Ingo Molnar
Cc: Matt Fleming, David Howells, x86, linux-kernel
Commmit b6eea87fc685 ("x86, boot: Explicitly include autoconf.h for
hostprogs") correctly noted
[...] that because $(USERINCLUDE) isn't exported by
the top-level Makefile it's actually empty in arch/x86/boot/Makefile.
So let's do the sane thing and remove the reference to that make variable.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
arch/x86/boot/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
index 12ea8f8384f4..0d810fb15eac 100644
--- a/arch/x86/boot/Makefile
+++ b/arch/x86/boot/Makefile
@@ -65,7 +65,7 @@ clean-files += cpustr.h
# ---------------------------------------------------------------------------
-KBUILD_CFLAGS := $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP
+KBUILD_CFLAGS := $(REALMODE_CFLAGS) -D_SETUP
KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__
GCOV_PROFILE := n
UBSAN_SANITIZE := n
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] x86/boot: Remove always empty $(USERINCLUDE)
2016-11-03 9:47 [PATCH] x86/boot: Remove always empty $(USERINCLUDE) Paul Bolle
@ 2016-11-03 9:51 ` Paul Bolle
2016-11-03 21:26 ` Matt Fleming
2016-11-07 8:52 ` [tip:x86/boot] x86/boot/build: " tip-bot for Paul Bolle
1 sibling, 1 reply; 4+ messages in thread
From: Paul Bolle @ 2016-11-03 9:51 UTC (permalink / raw)
To: Matt Fleming
Cc: H. Peter Anvin, Thomas Gleixner, Ingo Molnar, David Howells, x86,
linux-kernel
Apparently Matt left Intel. Let's forward this to a recently used
address.
On Thu, 2016-11-03 at 10:47 +0100, Paul Bolle wrote:
> Commmit b6eea87fc685 ("x86, boot: Explicitly include autoconf.h for
> hostprogs") correctly noted
> [...] that because $(USERINCLUDE) isn't exported by
> the top-level Makefile it's actually empty in arch/x86/boot/Makefile.
>
> So let's do the sane thing and remove the reference to that make variable.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> arch/x86/boot/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
> index 12ea8f8384f4..0d810fb15eac 100644
> --- a/arch/x86/boot/Makefile
> +++ b/arch/x86/boot/Makefile
> @@ -65,7 +65,7 @@ clean-files += cpustr.h
>
> # ---------------------------------------------------------------------------
>
> -KBUILD_CFLAGS := $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP
> +KBUILD_CFLAGS := $(REALMODE_CFLAGS) -D_SETUP
> KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__
> GCOV_PROFILE := n
> UBSAN_SANITIZE := n
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] x86/boot: Remove always empty $(USERINCLUDE)
2016-11-03 9:51 ` Paul Bolle
@ 2016-11-03 21:26 ` Matt Fleming
0 siblings, 0 replies; 4+ messages in thread
From: Matt Fleming @ 2016-11-03 21:26 UTC (permalink / raw)
To: Paul Bolle
Cc: H. Peter Anvin, Thomas Gleixner, Ingo Molnar, David Howells, x86,
linux-kernel
On Thu, 03 Nov, at 10:51:38AM, Paul Bolle wrote:
> Apparently Matt left Intel. Let's forward this to a recently used
> address.
>
> On Thu, 2016-11-03 at 10:47 +0100, Paul Bolle wrote:
> > Commmit b6eea87fc685 ("x86, boot: Explicitly include autoconf.h for
> > hostprogs") correctly noted
> > [...] that because $(USERINCLUDE) isn't exported by
> > the top-level Makefile it's actually empty in arch/x86/boot/Makefile.
> >
> > So let's do the sane thing and remove the reference to that make variable.
> >
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > arch/x86/boot/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
> > index 12ea8f8384f4..0d810fb15eac 100644
> > --- a/arch/x86/boot/Makefile
> > +++ b/arch/x86/boot/Makefile
> > @@ -65,7 +65,7 @@ clean-files += cpustr.h
> >
> > # ---------------------------------------------------------------------------
> >
> > -KBUILD_CFLAGS := $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP
> > +KBUILD_CFLAGS := $(REALMODE_CFLAGS) -D_SETUP
> > KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__
> > GCOV_PROFILE := n
> > UBSAN_SANITIZE := n
Looks OK to me.
Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:x86/boot] x86/boot/build: Remove always empty $(USERINCLUDE)
2016-11-03 9:47 [PATCH] x86/boot: Remove always empty $(USERINCLUDE) Paul Bolle
2016-11-03 9:51 ` Paul Bolle
@ 2016-11-07 8:52 ` tip-bot for Paul Bolle
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Paul Bolle @ 2016-11-07 8:52 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, hpa, pebolle, matt, dhowells, peterz, torvalds,
linux-kernel, tglx
Commit-ID: 0acba3f91823a5e53a54af5dc31fc774b0e64e99
Gitweb: http://git.kernel.org/tip/0acba3f91823a5e53a54af5dc31fc774b0e64e99
Author: Paul Bolle <pebolle@tiscali.nl>
AuthorDate: Thu, 3 Nov 2016 10:47:48 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 7 Nov 2016 07:30:01 +0100
x86/boot/build: Remove always empty $(USERINCLUDE)
Commmit b6eea87fc685:
("x86, boot: Explicitly include autoconf.h for hostprogs")
correctly noted:
[...] that because $(USERINCLUDE) isn't exported by
the top-level Makefile it's actually empty in arch/x86/boot/Makefile.
So let's do the sane thing and remove the reference to that make variable.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
Cc: David Howells <dhowells@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1478166468-9760-1-git-send-email-pebolle@tiscali.nl
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/boot/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
index 12ea8f8..0d810fb 100644
--- a/arch/x86/boot/Makefile
+++ b/arch/x86/boot/Makefile
@@ -65,7 +65,7 @@ clean-files += cpustr.h
# ---------------------------------------------------------------------------
-KBUILD_CFLAGS := $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP
+KBUILD_CFLAGS := $(REALMODE_CFLAGS) -D_SETUP
KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__
GCOV_PROFILE := n
UBSAN_SANITIZE := n
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-07 8:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-03 9:47 [PATCH] x86/boot: Remove always empty $(USERINCLUDE) Paul Bolle
2016-11-03 9:51 ` Paul Bolle
2016-11-03 21:26 ` Matt Fleming
2016-11-07 8:52 ` [tip:x86/boot] x86/boot/build: " tip-bot for Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox