* [PATCH -next] eeprom: idt_89hpesx: Drop kfree for memory allocated with devm_kzalloc
@ 2017-01-25 14:09 Wei Yongjun
2017-01-26 12:41 ` Serge Semin
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-01-25 14:09 UTC (permalink / raw)
To: Greg Kroah-Hartman, Serge Semin; +Cc: Wei Yongjun, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
It's not necessary to free memory allocated with devm_kzalloc
and using kfree leads to a double free.
Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/misc/eeprom/idt_89hpesx.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
index 25d47d0..f5f2c5a 100644
--- a/drivers/misc/eeprom/idt_89hpesx.c
+++ b/drivers/misc/eeprom/idt_89hpesx.c
@@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev)
pdev->ee_file->size = pdev->eesize;
ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file);
if (ret != 0) {
- kfree(pdev->ee_file);
dev_err(dev, "Failed to create EEPROM sysfs-node");
return ret;
}
@@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev)
/* Remove EEPROM sysfs file */
sysfs_remove_bin_file(&dev->kobj, pdev->ee_file);
-
- /* Free memory allocated for bin_attribute structure */
- kfree(pdev->ee_file);
}
/*
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] eeprom: idt_89hpesx: Drop kfree for memory allocated with devm_kzalloc
2017-01-25 14:09 [PATCH -next] eeprom: idt_89hpesx: Drop kfree for memory allocated with devm_kzalloc Wei Yongjun
@ 2017-01-26 12:41 ` Serge Semin
0 siblings, 0 replies; 2+ messages in thread
From: Serge Semin @ 2017-01-26 12:41 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Greg Kroah-Hartman, Wei Yongjun, linux-kernel
On Wed, Jan 25, 2017 at 02:09:52PM +0000, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> It's not necessary to free memory allocated with devm_kzalloc
> and using kfree leads to a double free.
>
> Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/misc/eeprom/idt_89hpesx.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
> index 25d47d0..f5f2c5a 100644
> --- a/drivers/misc/eeprom/idt_89hpesx.c
> +++ b/drivers/misc/eeprom/idt_89hpesx.c
> @@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev)
> pdev->ee_file->size = pdev->eesize;
> ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file);
> if (ret != 0) {
> - kfree(pdev->ee_file);
> dev_err(dev, "Failed to create EEPROM sysfs-node");
> return ret;
> }
> @@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev)
>
> /* Remove EEPROM sysfs file */
> sysfs_remove_bin_file(&dev->kobj, pdev->ee_file);
> -
> - /* Free memory allocated for bin_attribute structure */
> - kfree(pdev->ee_file);
> }
>
> /*
>
True point! Thanks for the patch.
Acked-by: Serge Semin <fancer.lancer@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-26 12:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-25 14:09 [PATCH -next] eeprom: idt_89hpesx: Drop kfree for memory allocated with devm_kzalloc Wei Yongjun
2017-01-26 12:41 ` Serge Semin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox