From: Steven Rostedt <rostedt@goodmis.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Matthias Kaehlcke <mka@chromium.org>,
Ingo Molnar <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ring-buffer: Remove unused function __rb_data_page_index()
Date: Thu, 18 May 2017 15:46:43 -0400 [thread overview]
Message-ID: <20170518154643.4306b37d@gandalf.local.home> (raw)
In-Reply-To: <CAD=FV=Wcqb09LHEE7jO=+3+Egf+Vj8a5Qi9rsykPiOYoZKj0Ww@mail.gmail.com>
On Thu, 18 May 2017 12:40:02 -0700
Doug Anderson <dianders@chromium.org> wrote:
> Hi,
>
> This appears to have been introduced in 2009 by commit afbab76a62b6
> ("ring-buffer: have read page swap increment counter with page
> entries"), which removed the user of the function but not the function
> itself. If folks were so inclined, this could be picked back to
> linux-stable, but I'm not sure it's worth it.
It doesn't do anything but waste some disk space in the source
repository. It's a static inline function, which means it's not created
unless something calls it.
Thus, not worth the stable churn.
-- Steve
next prev parent reply other threads:[~2017-05-18 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 0:14 [PATCH] ring-buffer: Remove unused function __rb_data_page_index() Matthias Kaehlcke
2017-05-18 19:40 ` Doug Anderson
2017-05-18 19:46 ` Steven Rostedt [this message]
2017-05-18 19:48 ` Doug Anderson
2017-12-04 12:05 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518154643.4306b37d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox