The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org,
	Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH] ring-buffer: Remove unused function __rb_data_page_index()
Date: Mon, 4 Dec 2017 07:05:51 -0500	[thread overview]
Message-ID: <20171204070551.3b891648@vmware.local.home> (raw)
In-Reply-To: <20170518001415.5223-1-mka@chromium.org>

On Wed, 17 May 2017 17:14:15 -0700
Matthias Kaehlcke <mka@chromium.org> wrote:

> This fixes the following warning when building with clang:
> 
> kernel/trace/ring_buffer.c:1842:1: error: unused function
>     '__rb_data_page_index' [-Werror,-Wunused-function]

Ug, I this patch somehow fell through. I'm applying it now.

-- Steve

> 
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>  kernel/trace/ring_buffer.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index 4ae268e687fe..a6b87582c4ff 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -1800,12 +1800,6 @@ void ring_buffer_change_overwrite(struct ring_buffer *buffer, int val)
>  }
>  EXPORT_SYMBOL_GPL(ring_buffer_change_overwrite);
>  
> -static __always_inline void *
> -__rb_data_page_index(struct buffer_data_page *bpage, unsigned index)
> -{
> -	return bpage->data + index;
> -}
> -
>  static __always_inline void *__rb_page_index(struct buffer_page *bpage, unsigned index)
>  {
>  	return bpage->page->data + index;

      parent reply	other threads:[~2017-12-04 12:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18  0:14 [PATCH] ring-buffer: Remove unused function __rb_data_page_index() Matthias Kaehlcke
2017-05-18 19:40 ` Doug Anderson
2017-05-18 19:46   ` Steven Rostedt
2017-05-18 19:48     ` Doug Anderson
2017-12-04 12:05 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171204070551.3b891648@vmware.local.home \
    --to=rostedt@goodmis.org \
    --cc=dianders@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mka@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox