[RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

[RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

[Byungchul Park]

Although llist provides proper APIs, they are not used. Make them used.

Signed-off-by: Byungchul Park <byungchul.park@lge.com>
---
 kernel/irq_work.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index bcf107c..e2ebe8c 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -138,11 +138,7 @@ static void irq_work_run_list(struct llist_head *list)
 		return;
 
 	llnode = llist_del_all(list);
-	while (llnode != NULL) {
-		work = llist_entry(llnode, struct irq_work, llnode);
-
-		llnode = llist_next(llnode);
-
+	llist_for_each_entry(work, llnode, llnode) {
 		/*
 		 * Clear the PENDING bit, after this point the @work
 		 * can be re-used.
-- 
1.9.1

Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

[Byungchul Park]

On Fri, May 12, 2017 at 09:45:35AM +0900, Byungchul Park wrote:
> Although llist provides proper APIs, they are not used. Make them used.

+to peterz@infradead.org
+to mingo@kernel.org
+to rostedt@goodmis.org

I am not sure whom should I send this patch to..
Could you check this if you are right person?

> 
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> ---
>  kernel/irq_work.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> index bcf107c..e2ebe8c 100644
> --- a/kernel/irq_work.c
> +++ b/kernel/irq_work.c
> @@ -138,11 +138,7 @@ static void irq_work_run_list(struct llist_head *list)
>  		return;
>  
>  	llnode = llist_del_all(list);
> -	while (llnode != NULL) {
> -		work = llist_entry(llnode, struct irq_work, llnode);
> -
> -		llnode = llist_next(llnode);
> -
> +	llist_for_each_entry(work, llnode, llnode) {
>  		/*
>  		 * Clear the PENDING bit, after this point the @work
>  		 * can be re-used.
> -- 
> 1.9.1

Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

[Frederic Weisbecker]

On Tue, May 30, 2017 at 02:29:20PM +0900, Byungchul Park wrote:
> On Fri, May 12, 2017 at 09:45:35AM +0900, Byungchul Park wrote:
> > Although llist provides proper APIs, they are not used. Make them used.
> 
> +to peterz@infradead.org
> +to mingo@kernel.org
> +to rostedt@goodmis.org
> 
> I am not sure whom should I send this patch to..
> Could you check this if you are right person?

I'll take it.

Thanks!

Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

[Byungchul Park]

On Wed, May 31, 2017 at 04:04:17PM +0200, Frederic Weisbecker wrote:
> On Tue, May 30, 2017 at 02:29:20PM +0900, Byungchul Park wrote:
> > On Fri, May 12, 2017 at 09:45:35AM +0900, Byungchul Park wrote:
> > > Although llist provides proper APIs, they are not used. Make them used.
> > 
> > +to peterz@infradead.org
> > +to mingo@kernel.org
> > +to rostedt@goodmis.org
> > 
> > I am not sure whom should I send this patch to..
> > Could you check this if you are right person?
> 
> I'll take it.

Hi, Frederic,

Thank you.

Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

[Byungchul Park]

On Wed, May 31, 2017 at 04:04:17PM +0200, Frederic Weisbecker wrote:
> On Tue, May 30, 2017 at 02:29:20PM +0900, Byungchul Park wrote:
> > On Fri, May 12, 2017 at 09:45:35AM +0900, Byungchul Park wrote:
> > > Although llist provides proper APIs, they are not used. Make them used.
> > 
> > +to peterz@infradead.org
> > +to mingo@kernel.org
> > +to rostedt@goodmis.org
> > 
> > I am not sure whom should I send this patch to..
> > Could you check this if you are right person?
> 
> I'll take it.

I would be appriciated if you take this at this window :)

> 
> Thanks!

Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

[Byungchul Park]

On Wed, May 31, 2017 at 04:04:17PM +0200, Frederic Weisbecker wrote:
> On Tue, May 30, 2017 at 02:29:20PM +0900, Byungchul Park wrote:
> > On Fri, May 12, 2017 at 09:45:35AM +0900, Byungchul Park wrote:
> > > Although llist provides proper APIs, they are not used. Make them used.
> > 
> > +to peterz@infradead.org
> > +to mingo@kernel.org
> > +to rostedt@goodmis.org
> > 
> > I am not sure whom should I send this patch to..
> > Could you check this if you are right person?
> 
> I'll take it.

Hello,

You seem to have forgotten this. Could you check this?

Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

[Byungchul Park]

On Wed, May 31, 2017 at 04:04:17PM +0200, Frederic Weisbecker wrote:
> On Tue, May 30, 2017 at 02:29:20PM +0900, Byungchul Park wrote:
> > On Fri, May 12, 2017 at 09:45:35AM +0900, Byungchul Park wrote:
> > > Although llist provides proper APIs, they are not used. Make them used.
> > 
> > +to peterz@infradead.org
> > +to mingo@kernel.org
> > +to rostedt@goodmis.org
> > 
> > I am not sure whom should I send this patch to..
> > Could you check this if you are right person?
> 
> I'll take it.

Hello Frederic,

Any problem to take this?

Thanks,
Byungchul

Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

[Byungchul Park]

On Wed, May 31, 2017 at 04:04:17PM +0200, Frederic Weisbecker wrote:
> On Tue, May 30, 2017 at 02:29:20PM +0900, Byungchul Park wrote:
> > On Fri, May 12, 2017 at 09:45:35AM +0900, Byungchul Park wrote:
> > > Although llist provides proper APIs, they are not used. Make them used.
> > 
> > +to peterz@infradead.org
> > +to mingo@kernel.org
> > +to rostedt@goodmis.org
> > 
> > I am not sure whom should I send this patch to..
> > Could you check this if you are right person?
> 
> I'll take it.

Hello Frederic,

Please let me know if there are some problems with this.

If so, I will request it to others.

Thanks.

> Thanks!