* [PATCH] zram: make function zram_page_end_io static
@ 2017-10-16 17:33 Colin King
2017-10-17 10:15 ` Sergey Senozhatsky
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-10-16 17:33 UTC (permalink / raw)
To: Minchan Kim, Nitin Gupta, Sergey Senozhatsky
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function zram_page_end_io is local to the source and
does not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'zram_page_end_io' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/block/zram/zram_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 88564222f473..d70eba30003a 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -428,7 +428,7 @@ static void put_entry_bdev(struct zram *zram, unsigned long entry)
WARN_ON_ONCE(!was_set);
}
-void zram_page_end_io(struct bio *bio)
+static void zram_page_end_io(struct bio *bio)
{
struct page *page = bio->bi_io_vec[0].bv_page;
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] zram: make function zram_page_end_io static
2017-10-16 17:33 [PATCH] zram: make function zram_page_end_io static Colin King
@ 2017-10-17 10:15 ` Sergey Senozhatsky
0 siblings, 0 replies; 2+ messages in thread
From: Sergey Senozhatsky @ 2017-10-17 10:15 UTC (permalink / raw)
To: Colin King
Cc: Minchan Kim, Nitin Gupta, Sergey Senozhatsky, kernel-janitors,
linux-kernel, Andrew Morton
(Ccing Andrew, message id: 20171016173336.20320-1-colin.king@canonical.com )
On (10/16/17 18:33), Colin King wrote:
> The function zram_page_end_io is local to the source and
> does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'zram_page_end_io' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
> ---
> drivers/block/zram/zram_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index 88564222f473..d70eba30003a 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -428,7 +428,7 @@ static void put_entry_bdev(struct zram *zram, unsigned long entry)
> WARN_ON_ONCE(!was_set);
> }
>
> -void zram_page_end_io(struct bio *bio)
> +static void zram_page_end_io(struct bio *bio)
> {
> struct page *page = bio->bi_io_vec[0].bv_page;
>
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-17 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-16 17:33 [PATCH] zram: make function zram_page_end_io static Colin King
2017-10-17 10:15 ` Sergey Senozhatsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox