From: Eric Biggers <ebiggers@google.com>
To: David Howells <dhowells@redhat.com>
Cc: jmorris@namei.org, torvalds@linux-foundation.org,
keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, Tyler Hicks <tyhicks@canonical.com>
Subject: Re: [GIT PULL] KEYS: Fixes
Date: Tue, 17 Oct 2017 16:23:16 -0700 [thread overview]
Message-ID: <20171017232316.GA29388@google.com> (raw)
In-Reply-To: <866.1508281053@warthog.procyon.org.uk>
+Cc tyhicks@canonical.com
Hi David,
On Tue, Oct 17, 2017 at 11:57:33PM +0100, David Howells wrote:
>
> (2) Fix some ecryptfs bits.
Sorry for the late notice, but just looking at it again I think the patch
"ecryptfs: fix out-of-bounds read of key payload" is broken because the
->private_key is of variable-length. See
ecryptfs_add_key_module_key_to_keyring() in ecryptfs-utils.
So can you please drop the following two patches:
ecryptfs: fix out-of-bounds read of key payload
ecryptfs: move key payload accessor functions into keystore.c
I'll fix them and try to get Tyler Hicks to take them through the ecryptfs tree
later instead.
Eric
next prev parent reply other threads:[~2017-10-17 23:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 22:57 [GIT PULL] KEYS: Fixes David Howells
2017-10-17 23:23 ` Eric Biggers [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-18 8:23 David Howells
2016-11-25 1:32 [GIT PULL] Keys fixes James Morris
2016-10-27 4:37 James Morris
2016-07-18 2:06 [GIT PULL] KEYS fixes James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017232316.GA29388@google.com \
--to=ebiggers@google.com \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tyhicks@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox