From: "Tobin C. Harding" <me@tobin.cc>
To: Jonny Schaefer <schaefer.jonny@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-kernel@i4.cs.fau.de
Subject: Re: [PATCH v2] drivers/fbtft: Fix indentation
Date: Thu, 11 Jan 2018 12:11:22 +1100 [thread overview]
Message-ID: <20180111011122.GC23786@eros> (raw)
In-Reply-To: <1515605435-26783-1-git-send-email-schaefer.jonny@gmail.com>
On Wed, Jan 10, 2018 at 06:30:35PM +0100, Jonny Schaefer wrote:
> From: Luis Gerhorst <luis.gerhorst@fau.de>
>
> This fixes the checkpatch message:
>
> CHECK: Alignment should match open parenthesis
> #1380: FILE: drivers/staging/fbtft/fbtft-core.c:1380:
> + dev_warn(dev,
> + "no default functions for regwidth=%d and buswidth=%d\n",
>
Perhaps:
Checkpatch emits CHECK: Alignment should match open parenthesis
Align code to open parenthesis.
Reasoning:
Patch description should describe the problem then describe what the
patch does (in imperative mood). Better advice is given in
Documentation/process/submitting-patches.rst section 2
Hope this helps,
Tobin.
prev parent reply other threads:[~2018-01-11 1:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 10:07 [PATCH 3/3] drivers/fbtft: Fix indentation Luis Gerhorst
2018-01-08 14:56 ` Greg Kroah-Hartman
2018-01-10 17:30 ` [PATCH v2] " Jonny Schaefer
2018-01-11 1:11 ` Tobin C. Harding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111011122.GC23786@eros \
--to=me@tobin.cc \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=schaefer.jonny@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox