* [PATCH 3/3] drivers/fbtft: Fix indentation
@ 2018-01-08 10:07 Luis Gerhorst
2018-01-08 14:56 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Luis Gerhorst @ 2018-01-08 10:07 UTC (permalink / raw)
To: Thomas Petazzoni, Greg Kroah-Hartman, devel, linux-kernel
Cc: Jonny Schäfer, linux-kernel, Luis Gerhorst
Signed-off-by: Luis Gerhorst <linux-kernel@luisgerhorst.de>
Acked-by: Jonny Schaefer <schaefer.jonny@gmail.com>
Acked-by: Alexander Wuerstlein <arw@cs.fau.de>
---
drivers/staging/fbtft/fbtft-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 34b1c81..566f89c 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -1377,8 +1377,8 @@ int fbtft_probe_common(struct fbtft_display *display,
par->fbtftops.write_register = fbtft_write_reg16_bus16;
else
dev_warn(dev,
- "no default functions for regwidth=%d and buswidth=%d\n",
- display->regwidth, display->buswidth);
+ "no default functions for regwidth=%d and buswidth=%d\n",
+ display->regwidth, display->buswidth);
/* write_vmem() functions */
if (display->buswidth == 8)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] drivers/fbtft: Fix indentation
2018-01-08 10:07 [PATCH 3/3] drivers/fbtft: Fix indentation Luis Gerhorst
@ 2018-01-08 14:56 ` Greg Kroah-Hartman
2018-01-10 17:30 ` [PATCH v2] " Jonny Schaefer
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2018-01-08 14:56 UTC (permalink / raw)
To: Luis Gerhorst
Cc: Thomas Petazzoni, devel, linux-kernel, Jonny Schäfer,
linux-kernel
On Mon, Jan 08, 2018 at 11:07:41AM +0100, Luis Gerhorst wrote:
> Signed-off-by: Luis Gerhorst <linux-kernel@luisgerhorst.de>
> Acked-by: Jonny Schaefer <schaefer.jonny@gmail.com>
> Acked-by: Alexander Wuerstlein <arw@cs.fau.de>
> ---
> drivers/staging/fbtft/fbtft-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I can't take a patch without any changelog text at all, sorry.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] drivers/fbtft: Fix indentation
2018-01-08 14:56 ` Greg Kroah-Hartman
@ 2018-01-10 17:30 ` Jonny Schaefer
2018-01-11 1:11 ` Tobin C. Harding
0 siblings, 1 reply; 4+ messages in thread
From: Jonny Schaefer @ 2018-01-10 17:30 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Thomas Petazzoni, devel, linux-kernel, linux-kernel,
Luis Gerhorst
From: Luis Gerhorst <luis.gerhorst@fau.de>
This fixes the checkpatch message:
CHECK: Alignment should match open parenthesis
#1380: FILE: drivers/staging/fbtft/fbtft-core.c:1380:
+ dev_warn(dev,
+ "no default functions for regwidth=%d and buswidth=%d\n",
Signed-off-by: Luis Gerhorst <linux-kernel@luisgerhorst.de>
Signed-off-by: Jonny Schaefer <schaefer.jonny@gmail.com>
Acked-by: Alexander Wuerstlein <arw@cs.fau.de>
---
Changes since v1:
- Add patch description
---
drivers/staging/fbtft/fbtft-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 34b1c81..566f89c 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -1377,8 +1377,8 @@ int fbtft_probe_common(struct fbtft_display *display,
par->fbtftops.write_register = fbtft_write_reg16_bus16;
else
dev_warn(dev,
- "no default functions for regwidth=%d and buswidth=%d\n",
- display->regwidth, display->buswidth);
+ "no default functions for regwidth=%d and buswidth=%d\n",
+ display->regwidth, display->buswidth);
/* write_vmem() functions */
if (display->buswidth == 8)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] drivers/fbtft: Fix indentation
2018-01-10 17:30 ` [PATCH v2] " Jonny Schaefer
@ 2018-01-11 1:11 ` Tobin C. Harding
0 siblings, 0 replies; 4+ messages in thread
From: Tobin C. Harding @ 2018-01-11 1:11 UTC (permalink / raw)
To: Jonny Schaefer; +Cc: Greg Kroah-Hartman, devel, linux-kernel, linux-kernel
On Wed, Jan 10, 2018 at 06:30:35PM +0100, Jonny Schaefer wrote:
> From: Luis Gerhorst <luis.gerhorst@fau.de>
>
> This fixes the checkpatch message:
>
> CHECK: Alignment should match open parenthesis
> #1380: FILE: drivers/staging/fbtft/fbtft-core.c:1380:
> + dev_warn(dev,
> + "no default functions for regwidth=%d and buswidth=%d\n",
>
Perhaps:
Checkpatch emits CHECK: Alignment should match open parenthesis
Align code to open parenthesis.
Reasoning:
Patch description should describe the problem then describe what the
patch does (in imperative mood). Better advice is given in
Documentation/process/submitting-patches.rst section 2
Hope this helps,
Tobin.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-11 1:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-08 10:07 [PATCH 3/3] drivers/fbtft: Fix indentation Luis Gerhorst
2018-01-08 14:56 ` Greg Kroah-Hartman
2018-01-10 17:30 ` [PATCH v2] " Jonny Schaefer
2018-01-11 1:11 ` Tobin C. Harding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox