* [PATCH] selftests/ftrace: Add ppc support for kprobe args tests
@ 2018-06-06 9:31 Naveen N. Rao
2018-06-06 11:37 ` Masami Hiramatsu
0 siblings, 1 reply; 4+ messages in thread
From: Naveen N. Rao @ 2018-06-06 9:31 UTC (permalink / raw)
To: Steven Rostedt
Cc: Masami Hiramatsu, Shuah Khan, linux-kernel, Michael Ellerman
Add powerpc support for the recently added kprobe args tests.
Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
---
.../selftests/ftrace/test.d/kprobe/kprobe_args_string.tc | 8 ++++++++
.../selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc | 7 +++++++
2 files changed, 15 insertions(+)
diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
index 5ba73035e1d9..a0002563e9ee 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
@@ -24,6 +24,14 @@ arm*)
ARG2=%r1
OFFS=4
;;
+ppc64*)
+ ARG2=%r4
+ OFFS=8
+;;
+ppc*)
+ ARG2=%r4
+ OFFS=4
+;;
*)
echo "Please implement other architecture here"
exit_untested
diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
index 231bcd2c4eb5..d026ff4e562f 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
@@ -34,6 +34,13 @@ arm*)
GOODREG=%r0
BADREG=%ax
;;
+ppc*)
+ GOODREG=%r3
+ BADREG=%msr
+;;
+*)
+ echo "Please implement other architecture here"
+ exit_untested
esac
test_goodarg() # Good-args
--
2.17.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/ftrace: Add ppc support for kprobe args tests
2018-06-06 9:31 [PATCH] selftests/ftrace: Add ppc support for kprobe args tests Naveen N. Rao
@ 2018-06-06 11:37 ` Masami Hiramatsu
2018-06-06 17:20 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Masami Hiramatsu @ 2018-06-06 11:37 UTC (permalink / raw)
To: Naveen N. Rao
Cc: Steven Rostedt, Masami Hiramatsu, Shuah Khan, linux-kernel,
Michael Ellerman
On Wed, 6 Jun 2018 15:01:54 +0530
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
> Add powerpc support for the recently added kprobe args tests.
Thank you for adding powerpc support!
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
>
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> ---
> .../selftests/ftrace/test.d/kprobe/kprobe_args_string.tc | 8 ++++++++
> .../selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc | 7 +++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> index 5ba73035e1d9..a0002563e9ee 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> @@ -24,6 +24,14 @@ arm*)
> ARG2=%r1
> OFFS=4
> ;;
> +ppc64*)
> + ARG2=%r4
> + OFFS=8
> +;;
> +ppc*)
> + ARG2=%r4
> + OFFS=4
> +;;
> *)
> echo "Please implement other architecture here"
> exit_untested
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> index 231bcd2c4eb5..d026ff4e562f 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> @@ -34,6 +34,13 @@ arm*)
> GOODREG=%r0
> BADREG=%ax
> ;;
> +ppc*)
> + GOODREG=%r3
> + BADREG=%msr
> +;;
> +*)
> + echo "Please implement other architecture here"
> + exit_untested
> esac
>
> test_goodarg() # Good-args
> --
> 2.17.0
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/ftrace: Add ppc support for kprobe args tests
2018-06-06 11:37 ` Masami Hiramatsu
@ 2018-06-06 17:20 ` Steven Rostedt
2018-06-06 19:38 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2018-06-06 17:20 UTC (permalink / raw)
To: Shuah Khan, linux-kernel
Cc: Masami Hiramatsu, Naveen N. Rao, Michael Ellerman
Shuah,
Can you take this in your tree?
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
On Wed, 6 Jun 2018 20:37:52 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> On Wed, 6 Jun 2018 15:01:54 +0530
> "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
>
> > Add powerpc support for the recently added kprobe args tests.
>
> Thank you for adding powerpc support!
>
> Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/ftrace: Add ppc support for kprobe args tests
2018-06-06 17:20 ` Steven Rostedt
@ 2018-06-06 19:38 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2018-06-06 19:38 UTC (permalink / raw)
To: Steven Rostedt, linux-kernel
Cc: Masami Hiramatsu, Naveen N. Rao, Michael Ellerman, Shuah Khan
On 06/06/2018 11:20 AM, Steven Rostedt wrote:
>
> Shuah,
>
> Can you take this in your tree?
>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> -- Steve
>
>
> On Wed, 6 Jun 2018 20:37:52 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
>> On Wed, 6 Jun 2018 15:01:54 +0530
>> "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
>>
>>> Add powerpc support for the recently added kprobe args tests.
>>
>> Thank you for adding powerpc support!
>>
>> Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
>>
>
Yes. I will get this in.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-06 19:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-06 9:31 [PATCH] selftests/ftrace: Add ppc support for kprobe args tests Naveen N. Rao
2018-06-06 11:37 ` Masami Hiramatsu
2018-06-06 17:20 ` Steven Rostedt
2018-06-06 19:38 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox