* Build/qemu test results for v4.18-rc4
@ 2018-07-09 17:55 Guenter Roeck
2018-07-09 18:06 ` Kees Cook
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2018-07-09 17:55 UTC (permalink / raw)
To: linux-kernel
Cc: Masahiro Yamada, Kees Cook, Linus Torvalds, Martin Schwidefsky,
linux-s390
Build results:
total: 134 pass: 130 fail: 4
Failed builds:
nds32:defconfig
nds32:allnoconfig
s390:allmodconfig
sparc32:allmodconfig
Qemu test results:
total: 158 pass: 158 fail: 0
---
nds32:defconfig:
nds32le-linux-ld: kernel/time/timekeeping.o: in function `timekeeping_init':
timekeeping.c:(.init.text+0x1a8): undefined reference to `__ashldi3'
nds32le-linux-ld: timekeeping.c:(.init.text+0x1ac): undefined reference to `__ashldi3'
nds32le-linux-ld: timekeeping.c:(.init.text+0x1ec): undefined reference to `__lshrdi3'
nds32le-linux-ld: timekeeping.c:(.init.text+0x1f0): undefined reference to `__lshrdi3'
Fix is available in -next with commit 78945c357f5 ("nds32: Fix build error
caused by configuration flag rename").
---
s390:allmodconfig:
arch/s390/kernel/als.o: In function `verify_facilities':
als.c:(.init.text+0x24): undefined reference to `latent_entropy'
als.c:(.init.text+0xae): undefined reference to `latent_entropy'
make[3]: *** [arch/s390/boot/compressed/vmlinux] Error 1
make[2]: *** [arch/s390/boot/compressed/vmlinux] Error 2
make[1]: *** [bzImage] Error 2
This problem is only seen when using a compiler which has the relevant
plugins enabled. Bisect points to commit 1658dcee3d43ed ("gcc-plugins:
allow to enable GCC_PLUGINS for COMPILE_TEST") as the culprit. I don't
know if a fix for v4.18 has been submitted. The s390 boot code in -next
has been rearranged and the problem is no longer seen there.
---
sparc32:allmodconfig:
include/linux/highmem.h: In function 'clear_user_highpage':
include/linux/highmem.h:137:31: error:
passing argument 1 of 'sparc_flush_page_to_ram' from incompatible pointer type
A possible fix is available at https://patchwork.kernel.org/patch/10497941/.
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Build/qemu test results for v4.18-rc4 2018-07-09 17:55 Build/qemu test results for v4.18-rc4 Guenter Roeck @ 2018-07-09 18:06 ` Kees Cook 2018-07-09 18:16 ` Christian Borntraeger 0 siblings, 1 reply; 6+ messages in thread From: Kees Cook @ 2018-07-09 18:06 UTC (permalink / raw) To: Guenter Roeck Cc: LKML, Masahiro Yamada, Linus Torvalds, Martin Schwidefsky, linux-s390 On Mon, Jul 9, 2018 at 10:55 AM, Guenter Roeck <linux@roeck-us.net> wrote: > s390:allmodconfig: > > arch/s390/kernel/als.o: In function `verify_facilities': > als.c:(.init.text+0x24): undefined reference to `latent_entropy' > als.c:(.init.text+0xae): undefined reference to `latent_entropy' > make[3]: *** [arch/s390/boot/compressed/vmlinux] Error 1 > make[2]: *** [arch/s390/boot/compressed/vmlinux] Error 2 > make[1]: *** [bzImage] Error 2 > > This problem is only seen when using a compiler which has the relevant > plugins enabled. Bisect points to commit 1658dcee3d43ed ("gcc-plugins: > allow to enable GCC_PLUGINS for COMPILE_TEST") as the culprit. I don't > know if a fix for v4.18 has been submitted. The s390 boot code in -next > has been rearranged and the problem is no longer seen there. Hm, that would imply that mm/page_alloc.o wasn't visible during the als.o linking? But ... if the problem is gone, I guess... good? -Kees -- Kees Cook Pixel Security ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Build/qemu test results for v4.18-rc4 2018-07-09 18:06 ` Kees Cook @ 2018-07-09 18:16 ` Christian Borntraeger 2018-07-09 18:19 ` Kees Cook 2018-07-09 18:29 ` Guenter Roeck 0 siblings, 2 replies; 6+ messages in thread From: Christian Borntraeger @ 2018-07-09 18:16 UTC (permalink / raw) To: Kees Cook, Guenter Roeck Cc: LKML, Masahiro Yamada, Linus Torvalds, Martin Schwidefsky, linux-s390 On 07/09/2018 08:06 PM, Kees Cook wrote: > On Mon, Jul 9, 2018 at 10:55 AM, Guenter Roeck <linux@roeck-us.net> wrote: >> s390:allmodconfig: >> >> arch/s390/kernel/als.o: In function `verify_facilities': >> als.c:(.init.text+0x24): undefined reference to `latent_entropy' >> als.c:(.init.text+0xae): undefined reference to `latent_entropy' >> make[3]: *** [arch/s390/boot/compressed/vmlinux] Error 1 >> make[2]: *** [arch/s390/boot/compressed/vmlinux] Error 2 >> make[1]: *** [bzImage] Error 2 >> >> This problem is only seen when using a compiler which has the relevant >> plugins enabled. Bisect points to commit 1658dcee3d43ed ("gcc-plugins: >> allow to enable GCC_PLUGINS for COMPILE_TEST") as the culprit. I don't >> know if a fix for v4.18 has been submitted. The s390 boot code in -next >> has been rearranged and the problem is no longer seen there. > > Hm, that would imply that mm/page_alloc.o wasn't visible during the > als.o linking? But ... if the problem is gone, I guess... good? als.o is used to detect if the kernel was compiled for a newer generation than the hardware that we are running on (very early). So it is compiled without gcov, kcov,ubsan and with a different march -in other words special. In linux-next we moved the als part to the decompressor which avoids all these kind of special handling. As this is part of a bigger patch set it would be non-trivial to backport that for 4.18. So unless we want to have it fixed for 4.18 I think we are fine. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Build/qemu test results for v4.18-rc4 2018-07-09 18:16 ` Christian Borntraeger @ 2018-07-09 18:19 ` Kees Cook 2018-07-09 18:30 ` Guenter Roeck 2018-07-09 18:29 ` Guenter Roeck 1 sibling, 1 reply; 6+ messages in thread From: Kees Cook @ 2018-07-09 18:19 UTC (permalink / raw) To: Christian Borntraeger Cc: Guenter Roeck, LKML, Masahiro Yamada, Linus Torvalds, Martin Schwidefsky, linux-s390 On Mon, Jul 9, 2018 at 11:16 AM, Christian Borntraeger <borntraeger@de.ibm.com> wrote: > > > On 07/09/2018 08:06 PM, Kees Cook wrote: >> On Mon, Jul 9, 2018 at 10:55 AM, Guenter Roeck <linux@roeck-us.net> wrote: >>> s390:allmodconfig: >>> >>> arch/s390/kernel/als.o: In function `verify_facilities': >>> als.c:(.init.text+0x24): undefined reference to `latent_entropy' >>> als.c:(.init.text+0xae): undefined reference to `latent_entropy' >>> make[3]: *** [arch/s390/boot/compressed/vmlinux] Error 1 >>> make[2]: *** [arch/s390/boot/compressed/vmlinux] Error 2 >>> make[1]: *** [bzImage] Error 2 >>> >>> This problem is only seen when using a compiler which has the relevant >>> plugins enabled. Bisect points to commit 1658dcee3d43ed ("gcc-plugins: >>> allow to enable GCC_PLUGINS for COMPILE_TEST") as the culprit. I don't >>> know if a fix for v4.18 has been submitted. The s390 boot code in -next >>> has been rearranged and the problem is no longer seen there. >> >> Hm, that would imply that mm/page_alloc.o wasn't visible during the >> als.o linking? But ... if the problem is gone, I guess... good? > > als.o is used to detect if the kernel was compiled for a newer generation > than the hardware that we are running on (very early). So it is compiled > without gcov, kcov,ubsan and with a different march -in other words special. > In linux-next we moved the als part to the decompressor which avoids all > these kind of special handling. As this is part of a bigger patch set it > would be non-trivial to backport that for 4.18. > So unless we want to have it fixed for 4.18 I think we are fine. Okay, cool. If you want to fix it for 4.18, it should just be something like this in the Makefile: CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) -Kees -- Kees Cook Pixel Security ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Build/qemu test results for v4.18-rc4 2018-07-09 18:19 ` Kees Cook @ 2018-07-09 18:30 ` Guenter Roeck 0 siblings, 0 replies; 6+ messages in thread From: Guenter Roeck @ 2018-07-09 18:30 UTC (permalink / raw) To: Kees Cook Cc: Christian Borntraeger, LKML, Masahiro Yamada, Linus Torvalds, Martin Schwidefsky, linux-s390 On Mon, Jul 09, 2018 at 11:19:17AM -0700, Kees Cook wrote: > On Mon, Jul 9, 2018 at 11:16 AM, Christian Borntraeger > <borntraeger@de.ibm.com> wrote: > > > > > > On 07/09/2018 08:06 PM, Kees Cook wrote: > >> On Mon, Jul 9, 2018 at 10:55 AM, Guenter Roeck <linux@roeck-us.net> wrote: > >>> s390:allmodconfig: > >>> > >>> arch/s390/kernel/als.o: In function `verify_facilities': > >>> als.c:(.init.text+0x24): undefined reference to `latent_entropy' > >>> als.c:(.init.text+0xae): undefined reference to `latent_entropy' > >>> make[3]: *** [arch/s390/boot/compressed/vmlinux] Error 1 > >>> make[2]: *** [arch/s390/boot/compressed/vmlinux] Error 2 > >>> make[1]: *** [bzImage] Error 2 > >>> > >>> This problem is only seen when using a compiler which has the relevant > >>> plugins enabled. Bisect points to commit 1658dcee3d43ed ("gcc-plugins: > >>> allow to enable GCC_PLUGINS for COMPILE_TEST") as the culprit. I don't > >>> know if a fix for v4.18 has been submitted. The s390 boot code in -next > >>> has been rearranged and the problem is no longer seen there. > >> > >> Hm, that would imply that mm/page_alloc.o wasn't visible during the > >> als.o linking? But ... if the problem is gone, I guess... good? > > > > als.o is used to detect if the kernel was compiled for a newer generation > > than the hardware that we are running on (very early). So it is compiled > > without gcov, kcov,ubsan and with a different march -in other words special. > > In linux-next we moved the als part to the decompressor which avoids all > > these kind of special handling. As this is part of a bigger patch set it > > would be non-trivial to backport that for 4.18. > > So unless we want to have it fixed for 4.18 I think we are fine. > > Okay, cool. If you want to fix it for 4.18, it should just be > something like this in the Makefile: > > CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) > Yes, I confirmed that this fixes the problem. Thanks, Guenter ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Build/qemu test results for v4.18-rc4 2018-07-09 18:16 ` Christian Borntraeger 2018-07-09 18:19 ` Kees Cook @ 2018-07-09 18:29 ` Guenter Roeck 1 sibling, 0 replies; 6+ messages in thread From: Guenter Roeck @ 2018-07-09 18:29 UTC (permalink / raw) To: Christian Borntraeger Cc: Kees Cook, LKML, Masahiro Yamada, Linus Torvalds, Martin Schwidefsky, linux-s390 On Mon, Jul 09, 2018 at 08:16:04PM +0200, Christian Borntraeger wrote: > > > On 07/09/2018 08:06 PM, Kees Cook wrote: > > On Mon, Jul 9, 2018 at 10:55 AM, Guenter Roeck <linux@roeck-us.net> wrote: > >> s390:allmodconfig: > >> > >> arch/s390/kernel/als.o: In function `verify_facilities': > >> als.c:(.init.text+0x24): undefined reference to `latent_entropy' > >> als.c:(.init.text+0xae): undefined reference to `latent_entropy' > >> make[3]: *** [arch/s390/boot/compressed/vmlinux] Error 1 > >> make[2]: *** [arch/s390/boot/compressed/vmlinux] Error 2 > >> make[1]: *** [bzImage] Error 2 > >> > >> This problem is only seen when using a compiler which has the relevant > >> plugins enabled. Bisect points to commit 1658dcee3d43ed ("gcc-plugins: > >> allow to enable GCC_PLUGINS for COMPILE_TEST") as the culprit. I don't > >> know if a fix for v4.18 has been submitted. The s390 boot code in -next > >> has been rearranged and the problem is no longer seen there. > > > > Hm, that would imply that mm/page_alloc.o wasn't visible during the > > als.o linking? But ... if the problem is gone, I guess... good? > > als.o is used to detect if the kernel was compiled for a newer generation > than the hardware that we are running on (very early). So it is compiled > without gcov, kcov,ubsan and with a different march -in other words special. > In linux-next we moved the als part to the decompressor which avoids all > these kind of special handling. As this is part of a bigger patch set it > would be non-trivial to backport that for 4.18. > So unless we want to have it fixed for 4.18 I think we are fine. > Fine with me. Please let me know if the problem won't be fixed, and I'll disable allmodconfig test builds for s390 images in v4.18. Thanks, Guenter ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-09 18:31 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-07-09 17:55 Build/qemu test results for v4.18-rc4 Guenter Roeck 2018-07-09 18:06 ` Kees Cook 2018-07-09 18:16 ` Christian Borntraeger 2018-07-09 18:19 ` Kees Cook 2018-07-09 18:30 ` Guenter Roeck 2018-07-09 18:29 ` Guenter Roeck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox