* [PATCH] drm/print: Fix DRM_DEBUG_DP macro
@ 2018-07-18 21:57 Lyude Paul
2018-07-18 23:07 ` Rodrigo Vivi
0 siblings, 1 reply; 3+ messages in thread
From: Lyude Paul @ 2018-07-18 21:57 UTC (permalink / raw)
To: dri-devel
Cc: Gustavo Padovan, Maarten Lankhorst, Sean Paul, David Airlie,
linux-kernel
This isn't supposed to take dev as an argument, I guess no one noticed!
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
include/drm/drm_print.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index 767c90b654c5..fc08584a5101 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -310,7 +310,7 @@ void drm_err(const char *format, ...);
#define DRM_DEV_DEBUG_DP(dev, fmt, ...) \
drm_dev_dbg(dev, DRM_UT_DP, fmt, ## __VA_ARGS__)
-#define DRM_DEBUG_DP(dev, fmt, ...) \
+#define DRM_DEBUG_DP(fmt, ...) \
drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__)
#define _DRM_DEV_DEFINE_DEBUG_RATELIMITED(dev, category, fmt, ...) \
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/print: Fix DRM_DEBUG_DP macro
2018-07-18 21:57 [PATCH] drm/print: Fix DRM_DEBUG_DP macro Lyude Paul
@ 2018-07-18 23:07 ` Rodrigo Vivi
2018-07-18 23:08 ` Lyude Paul
0 siblings, 1 reply; 3+ messages in thread
From: Rodrigo Vivi @ 2018-07-18 23:07 UTC (permalink / raw)
To: Lyude Paul; +Cc: dri-devel, David Airlie, linux-kernel
On Wed, Jul 18, 2018 at 05:57:16PM -0400, Lyude Paul wrote:
> This isn't supposed to take dev as an argument, I guess no one noticed!
Apparently no one using it... Why don't we just kill it?
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
anyways, if you prefer to keep or have plans to use:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> include/drm/drm_print.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
> index 767c90b654c5..fc08584a5101 100644
> --- a/include/drm/drm_print.h
> +++ b/include/drm/drm_print.h
> @@ -310,7 +310,7 @@ void drm_err(const char *format, ...);
>
> #define DRM_DEV_DEBUG_DP(dev, fmt, ...) \
> drm_dev_dbg(dev, DRM_UT_DP, fmt, ## __VA_ARGS__)
> -#define DRM_DEBUG_DP(dev, fmt, ...) \
> +#define DRM_DEBUG_DP(fmt, ...) \
> drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__)
>
> #define _DRM_DEV_DEFINE_DEBUG_RATELIMITED(dev, category, fmt, ...) \
> --
> 2.17.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/print: Fix DRM_DEBUG_DP macro
2018-07-18 23:07 ` Rodrigo Vivi
@ 2018-07-18 23:08 ` Lyude Paul
0 siblings, 0 replies; 3+ messages in thread
From: Lyude Paul @ 2018-07-18 23:08 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: dri-devel, David Airlie, linux-kernel
On Wed, 2018-07-18 at 16:07 -0700, Rodrigo Vivi wrote:
> On Wed, Jul 18, 2018 at 05:57:16PM -0400, Lyude Paul wrote:
> > This isn't supposed to take dev as an argument, I guess no one noticed!
>
> Apparently no one using it... Why don't we just kill it?
Yeah-I've got plans to hopefully use this at some point in the future
>
> >
> > Signed-off-by: Lyude Paul <lyude@redhat.com>
>
> anyways, if you prefer to keep or have plans to use:
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
>
> > ---
> > include/drm/drm_print.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
> > index 767c90b654c5..fc08584a5101 100644
> > --- a/include/drm/drm_print.h
> > +++ b/include/drm/drm_print.h
> > @@ -310,7 +310,7 @@ void drm_err(const char *format, ...);
> >
> > #define DRM_DEV_DEBUG_DP(dev, fmt, ...)
> > \
> > drm_dev_dbg(dev, DRM_UT_DP, fmt, ## __VA_ARGS__)
> > -#define DRM_DEBUG_DP(dev, fmt, ...)
> > \
> > +#define DRM_DEBUG_DP(fmt, ...)
> > \
> > drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__)
> >
> > #define _DRM_DEV_DEFINE_DEBUG_RATELIMITED(dev, category, fmt, ...)
> > \
> > --
> > 2.17.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Cheers,
Lyude Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-18 23:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-18 21:57 [PATCH] drm/print: Fix DRM_DEBUG_DP macro Lyude Paul
2018-07-18 23:07 ` Rodrigo Vivi
2018-07-18 23:08 ` Lyude Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox