From: Greg KH <gregkh@linuxfoundation.org>
To: richard.gong@linux.intel.com
Cc: atull@kernel.org, dinguyen@kernel.org,
linux-kernel@vger.kernel.org, todd.riffel@intel.com,
Richard Gong <richard.gong@intel.com>
Subject: Re: [PATCHv1] firmware: intel_stratix10_service: add hardware dependency
Date: Wed, 23 Jan 2019 17:00:19 +0100 [thread overview]
Message-ID: <20190123160019.GB4764@kroah.com> (raw)
In-Reply-To: <1548258476-16821-1-git-send-email-richard.gong@linux.intel.com>
On Wed, Jan 23, 2019 at 09:47:56AM -0600, richard.gong@linux.intel.com wrote:
> From: Richard Gong <richard.gong@intel.com>
>
> Add a Kconfig dependency to ensure Intel Stratix10 service layer driver
> can be built only on the platform that supports it.
>
> Signed-off-by: Richard Gong <richard.gong@intel.com>
> ---
> drivers/firmware/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index f754578..cac16c4 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -218,7 +218,7 @@ config FW_CFG_SYSFS_CMDLINE
>
> config INTEL_STRATIX10_SERVICE
> tristate "Intel Stratix10 Service Layer"
> - depends on HAVE_ARM_SMCCC
> + depends on ARCH_STRATIX10 && HAVE_ARM_SMCCC
That's lame, what about building for testing?
And is this needed now, for 5.0-final, or can it wait for 5.1? What
changed to require this?
tahnks,
greg k-h
next prev parent reply other threads:[~2019-01-23 16:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 15:47 [PATCHv1] firmware: intel_stratix10_service: add hardware dependency richard.gong
2019-01-23 16:00 ` Greg KH [this message]
2019-01-23 16:37 ` Alan Tull
2019-01-23 16:42 ` Dinh Nguyen
2019-01-23 17:01 ` Alan Tull
2019-01-23 17:04 ` Dinh Nguyen
2019-01-23 16:43 ` Greg KH
2019-01-23 16:59 ` Richard Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123160019.GB4764@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=atull@kernel.org \
--cc=dinguyen@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.gong@intel.com \
--cc=richard.gong@linux.intel.com \
--cc=todd.riffel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox