* [PATCH] mm: fix comments based on per-node memcg
@ 2019-10-22 15:06 Hao Lee
2019-10-22 16:10 ` Roman Gushchin
2019-10-22 17:06 ` Michal Hocko
0 siblings, 2 replies; 3+ messages in thread
From: Hao Lee @ 2019-10-22 15:06 UTC (permalink / raw)
To: akpm
Cc: hannes, guro, shakeelb, mhocko, chris, yang.shi, tj, tglx,
linux-kernel, haolee.swjtu
These comments should be updated as memcg limit enforcement has been moved
from zones to nodes.
Signed-off-by: Hao Lee <haolee.swjtu@gmail.com>
---
include/linux/memcontrol.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index ae703ea3ef48..12c29f74c02a 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -112,7 +112,7 @@ struct memcg_shrinker_map {
};
/*
- * per-zone information in memory controller.
+ * per-node information in memory controller.
*/
struct mem_cgroup_per_node {
struct lruvec lruvec;
@@ -399,8 +399,7 @@ mem_cgroup_nodeinfo(struct mem_cgroup *memcg, int nid)
* @memcg: memcg of the wanted lruvec
*
* Returns the lru list vector holding pages for a given @node or a given
- * @memcg and @zone. This can be the node lruvec, if the memory controller
- * is disabled.
+ * @memcg. This can be the node lruvec, if the memory controller is disabled.
*/
static inline struct lruvec *mem_cgroup_lruvec(struct pglist_data *pgdat,
struct mem_cgroup *memcg)
--
2.14.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mm: fix comments based on per-node memcg
2019-10-22 15:06 [PATCH] mm: fix comments based on per-node memcg Hao Lee
@ 2019-10-22 16:10 ` Roman Gushchin
2019-10-22 17:06 ` Michal Hocko
1 sibling, 0 replies; 3+ messages in thread
From: Roman Gushchin @ 2019-10-22 16:10 UTC (permalink / raw)
To: Hao Lee
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
shakeelb@google.com, mhocko@kernel.org, chris@chrisdown.name,
yang.shi@linux.alibaba.com, tj@kernel.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org
On Tue, Oct 22, 2019 at 03:06:18PM +0000, Hao Lee wrote:
> These comments should be updated as memcg limit enforcement has been moved
> from zones to nodes.
>
> Signed-off-by: Hao Lee <haolee.swjtu@gmail.com>
Acked-by: Roman Gushchin <guro@fb.com>
Thanks!
> ---
> include/linux/memcontrol.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index ae703ea3ef48..12c29f74c02a 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -112,7 +112,7 @@ struct memcg_shrinker_map {
> };
>
> /*
> - * per-zone information in memory controller.
> + * per-node information in memory controller.
> */
> struct mem_cgroup_per_node {
> struct lruvec lruvec;
> @@ -399,8 +399,7 @@ mem_cgroup_nodeinfo(struct mem_cgroup *memcg, int nid)
> * @memcg: memcg of the wanted lruvec
> *
> * Returns the lru list vector holding pages for a given @node or a given
> - * @memcg and @zone. This can be the node lruvec, if the memory controller
> - * is disabled.
> + * @memcg. This can be the node lruvec, if the memory controller is disabled.
> */
> static inline struct lruvec *mem_cgroup_lruvec(struct pglist_data *pgdat,
> struct mem_cgroup *memcg)
> --
> 2.14.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: fix comments based on per-node memcg
2019-10-22 15:06 [PATCH] mm: fix comments based on per-node memcg Hao Lee
2019-10-22 16:10 ` Roman Gushchin
@ 2019-10-22 17:06 ` Michal Hocko
1 sibling, 0 replies; 3+ messages in thread
From: Michal Hocko @ 2019-10-22 17:06 UTC (permalink / raw)
To: Hao Lee
Cc: akpm, hannes, guro, shakeelb, chris, yang.shi, tj, tglx,
linux-kernel
On Tue 22-10-19 15:06:18, Hao Lee wrote:
> These comments should be updated as memcg limit enforcement has been moved
> from zones to nodes.
>
> Signed-off-by: Hao Lee <haolee.swjtu@gmail.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> include/linux/memcontrol.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index ae703ea3ef48..12c29f74c02a 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -112,7 +112,7 @@ struct memcg_shrinker_map {
> };
>
> /*
> - * per-zone information in memory controller.
> + * per-node information in memory controller.
> */
> struct mem_cgroup_per_node {
> struct lruvec lruvec;
> @@ -399,8 +399,7 @@ mem_cgroup_nodeinfo(struct mem_cgroup *memcg, int nid)
> * @memcg: memcg of the wanted lruvec
> *
> * Returns the lru list vector holding pages for a given @node or a given
> - * @memcg and @zone. This can be the node lruvec, if the memory controller
> - * is disabled.
> + * @memcg. This can be the node lruvec, if the memory controller is disabled.
> */
> static inline struct lruvec *mem_cgroup_lruvec(struct pglist_data *pgdat,
> struct mem_cgroup *memcg)
> --
> 2.14.5
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-22 17:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-22 15:06 [PATCH] mm: fix comments based on per-node memcg Hao Lee
2019-10-22 16:10 ` Roman Gushchin
2019-10-22 17:06 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox