* Re: [PATCH] i2c: i2c-cros-ec-tunnel: Fix slave device enumeration
2019-11-21 9:06 [PATCH] i2c: i2c-cros-ec-tunnel: Fix slave device enumeration Akshu Agrawal
@ 2019-11-25 15:32 ` Enric Balletbo i Serra
2019-11-25 18:08 ` Raul Rangel
2019-11-25 18:09 ` Raul Rangel
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Enric Balletbo i Serra @ 2019-11-25 15:32 UTC (permalink / raw)
To: Akshu Agrawal
Cc: rrangel, Benson Leung, Guenter Roeck, Wolfram Sang,
Neil Armstrong, Chanwoo Choi,
open list:I2C SUBSYSTEM HOST DRIVERS, open list
Hi Akshu,
On 21/11/19 10:06, Akshu Agrawal wrote:
> During adding of the adapter the slave device registration
> use to fail as the acpi companion field was not populated.
>
I am wondering if this a fix that needs to picked on stable kernels? Which
chrome platform are you using?
Thanks,
Enric
> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
> ---
> drivers/i2c/busses/i2c-cros-ec-tunnel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> index c551aa96a2e3..aca8070393bd 100644
> --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> @@ -273,6 +273,7 @@ static int ec_i2c_probe(struct platform_device *pdev)
> bus->adap.dev.parent = &pdev->dev;
> bus->adap.dev.of_node = np;
> bus->adap.retries = I2C_MAX_RETRIES;
> + ACPI_COMPANION_SET(&bus->adap.dev, ACPI_COMPANION(&pdev->dev));
>
> err = i2c_add_adapter(&bus->adap);
> if (err)
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] i2c: i2c-cros-ec-tunnel: Fix slave device enumeration
2019-11-25 15:32 ` Enric Balletbo i Serra
@ 2019-11-25 18:08 ` Raul Rangel
0 siblings, 0 replies; 6+ messages in thread
From: Raul Rangel @ 2019-11-25 18:08 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: Akshu Agrawal, Benson Leung, Guenter Roeck, Wolfram Sang,
Neil Armstrong, Chanwoo Choi,
open list:I2C SUBSYSTEM HOST DRIVERS, open list
On Mon, Nov 25, 2019 at 8:32 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Akshu,
>
> On 21/11/19 10:06, Akshu Agrawal wrote:
> > During adding of the adapter the slave device registration
> > use to fail as the acpi companion field was not populated.
> >
>
> I am wondering if this a fix that needs to picked on stable kernels? Which
> chrome platform are you using?
>
It's a fixup of https://lore.kernel.org/patchwork/patch/1151436/ so
unless that patch has been ported to stable kernels, I wouldn't worry
about it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: i2c-cros-ec-tunnel: Fix slave device enumeration
2019-11-21 9:06 [PATCH] i2c: i2c-cros-ec-tunnel: Fix slave device enumeration Akshu Agrawal
2019-11-25 15:32 ` Enric Balletbo i Serra
@ 2019-11-25 18:09 ` Raul Rangel
2019-11-26 10:23 ` Enric Balletbo i Serra
2020-01-31 7:45 ` Wolfram Sang
3 siblings, 0 replies; 6+ messages in thread
From: Raul Rangel @ 2019-11-25 18:09 UTC (permalink / raw)
To: Akshu Agrawal
Cc: Benson Leung, Enric Balletbo i Serra, Guenter Roeck, Wolfram Sang,
Neil Armstrong, Chanwoo Choi,
open list:I2C SUBSYSTEM HOST DRIVERS, open list
On Thu, Nov 21, 2019 at 2:06 AM Akshu Agrawal <akshu.agrawal@amd.com> wrote:
>
> During adding of the adapter the slave device registration
> use to fail as the acpi companion field was not populated.
>
> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
> ---
> drivers/i2c/busses/i2c-cros-ec-tunnel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> index c551aa96a2e3..aca8070393bd 100644
> --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> @@ -273,6 +273,7 @@ static int ec_i2c_probe(struct platform_device *pdev)
> bus->adap.dev.parent = &pdev->dev;
> bus->adap.dev.of_node = np;
> bus->adap.retries = I2C_MAX_RETRIES;
> + ACPI_COMPANION_SET(&bus->adap.dev, ACPI_COMPANION(&pdev->dev));
>
> err = i2c_add_adapter(&bus->adap);
> if (err)
> --
> 2.17.1
>
Acked-by: Raul E Rangel <rrangel@chromium.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: i2c-cros-ec-tunnel: Fix slave device enumeration
2019-11-21 9:06 [PATCH] i2c: i2c-cros-ec-tunnel: Fix slave device enumeration Akshu Agrawal
2019-11-25 15:32 ` Enric Balletbo i Serra
2019-11-25 18:09 ` Raul Rangel
@ 2019-11-26 10:23 ` Enric Balletbo i Serra
2020-01-31 7:45 ` Wolfram Sang
3 siblings, 0 replies; 6+ messages in thread
From: Enric Balletbo i Serra @ 2019-11-26 10:23 UTC (permalink / raw)
To: Akshu Agrawal
Cc: rrangel, Benson Leung, Guenter Roeck, Wolfram Sang,
Neil Armstrong, Chanwoo Choi,
open list:I2C SUBSYSTEM HOST DRIVERS, open list
Hi,
On 21/11/19 10:06, Akshu Agrawal wrote:
> During adding of the adapter the slave device registration
> use to fail as the acpi companion field was not populated.
>
> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
Looks good to me.
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> drivers/i2c/busses/i2c-cros-ec-tunnel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> index c551aa96a2e3..aca8070393bd 100644
> --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> @@ -273,6 +273,7 @@ static int ec_i2c_probe(struct platform_device *pdev)
> bus->adap.dev.parent = &pdev->dev;
> bus->adap.dev.of_node = np;
> bus->adap.retries = I2C_MAX_RETRIES;
> + ACPI_COMPANION_SET(&bus->adap.dev, ACPI_COMPANION(&pdev->dev));
>
> err = i2c_add_adapter(&bus->adap);
> if (err)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: i2c-cros-ec-tunnel: Fix slave device enumeration
2019-11-21 9:06 [PATCH] i2c: i2c-cros-ec-tunnel: Fix slave device enumeration Akshu Agrawal
` (2 preceding siblings ...)
2019-11-26 10:23 ` Enric Balletbo i Serra
@ 2020-01-31 7:45 ` Wolfram Sang
3 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2020-01-31 7:45 UTC (permalink / raw)
To: Akshu Agrawal
Cc: rrangel, Benson Leung, Enric Balletbo i Serra, Guenter Roeck,
Neil Armstrong, Chanwoo Choi,
open list:I2C SUBSYSTEM HOST DRIVERS, open list
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
On Thu, Nov 21, 2019 at 02:36:17PM +0530, Akshu Agrawal wrote:
> During adding of the adapter the slave device registration
> use to fail as the acpi companion field was not populated.
>
> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
Applied to for-next (v5.6) with Fixes tag added, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread