public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86: Kconfig: make CMDLINE_OVERRIDE depend on CMDLINE
@ 2020-01-24 11:46 Anders Roxell
  2020-02-24 21:36 ` Borislav Petkov
  2020-02-26 12:37 ` [tip: x86/build] x86/Kconfig: Make CMDLINE_OVERRIDE depend on non-empty CMDLINE tip-bot2 for Anders Roxell
  0 siblings, 2 replies; 3+ messages in thread
From: Anders Roxell @ 2020-01-24 11:46 UTC (permalink / raw)
  To: tglx, mingo, bp; +Cc: x86, linux-kernel, Anders Roxell

When trying to boot an allmodconfig kernel that is build with
KCONFIG_ALLCONFIG=$(pwd)/arch/x86/configs/x86_64_defconfig, it doesn't
boot since CONFIG_CMDLINE_OVERRIDE gets enabled. Which forces the user
to pass the full cmdline to CONFIG_CMDLINE="...".

Rework so that CONFIG_CMDLINE_OVERRIDE gets set only if CONFIG_CMDLINE
is set to something except an empty string.

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 arch/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index f2dcd9ab6ef6..598b6325a027 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2447,7 +2447,7 @@ config CMDLINE
 
 config CMDLINE_OVERRIDE
 	bool "Built-in command line overrides boot loader arguments"
-	depends on CMDLINE_BOOL
+	depends on CMDLINE_BOOL && CMDLINE != ""
 	---help---
 	  Set this option to 'Y' to have the kernel ignore the boot loader
 	  command line, and use ONLY the built-in command line.
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-26 12:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-24 11:46 [PATCH] x86: Kconfig: make CMDLINE_OVERRIDE depend on CMDLINE Anders Roxell
2020-02-24 21:36 ` Borislav Petkov
2020-02-26 12:37 ` [tip: x86/build] x86/Kconfig: Make CMDLINE_OVERRIDE depend on non-empty CMDLINE tip-bot2 for Anders Roxell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox