* [PATCH 1/1] platform/chrome: chromeos_pstore: set user space log size
@ 2020-04-02 0:15 Sarthak Kukreti
2020-04-02 7:10 ` Kees Cook
2020-04-14 13:14 ` Enric Balletbo i Serra
0 siblings, 2 replies; 3+ messages in thread
From: Sarthak Kukreti @ 2020-04-02 0:15 UTC (permalink / raw)
To: bleung, enric.balletbo
Cc: keescook, anton, linux-kernel, ccross, tony.luck, gwendal,
Sarthak Kukreti
On x86 ChromiumOS devices, the pmsg_size is set to 0 (check
/sys/module/ramoops/parameters/pmsg_size): this prevents use of
pstore-pmsg, even if CONFIG_PSTORE_PMSG is enabled. Set pmsg_size
to a value that is consistent with the size used on non-x86 ChromiumOS
devices.
Signed-off-by: Sarthak Kukreti <sarthakkukreti@chromium.org>
---
drivers/platform/chrome/chromeos_pstore.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/chrome/chromeos_pstore.c b/drivers/platform/chrome/chromeos_pstore.c
index d13770785fb5..82dea8cb5da1 100644
--- a/drivers/platform/chrome/chromeos_pstore.c
+++ b/drivers/platform/chrome/chromeos_pstore.c
@@ -57,6 +57,7 @@ static struct ramoops_platform_data chromeos_ramoops_data = {
.record_size = 0x40000,
.console_size = 0x20000,
.ftrace_size = 0x20000,
+ .pmsg_size = 0x20000,
.dump_oops = 1,
};
--
2.26.0.rc2.310.g2932bb562d-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] platform/chrome: chromeos_pstore: set user space log size
2020-04-02 0:15 [PATCH 1/1] platform/chrome: chromeos_pstore: set user space log size Sarthak Kukreti
@ 2020-04-02 7:10 ` Kees Cook
2020-04-14 13:14 ` Enric Balletbo i Serra
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2020-04-02 7:10 UTC (permalink / raw)
To: Sarthak Kukreti
Cc: bleung, enric.balletbo, anton, linux-kernel, ccross, tony.luck,
gwendal
On Wed, Apr 01, 2020 at 05:15:48PM -0700, Sarthak Kukreti wrote:
> On x86 ChromiumOS devices, the pmsg_size is set to 0 (check
> /sys/module/ramoops/parameters/pmsg_size): this prevents use of
> pstore-pmsg, even if CONFIG_PSTORE_PMSG is enabled. Set pmsg_size
> to a value that is consistent with the size used on non-x86 ChromiumOS
> devices.
>
> Signed-off-by: Sarthak Kukreti <sarthakkukreti@chromium.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> drivers/platform/chrome/chromeos_pstore.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/chrome/chromeos_pstore.c b/drivers/platform/chrome/chromeos_pstore.c
> index d13770785fb5..82dea8cb5da1 100644
> --- a/drivers/platform/chrome/chromeos_pstore.c
> +++ b/drivers/platform/chrome/chromeos_pstore.c
> @@ -57,6 +57,7 @@ static struct ramoops_platform_data chromeos_ramoops_data = {
> .record_size = 0x40000,
> .console_size = 0x20000,
> .ftrace_size = 0x20000,
> + .pmsg_size = 0x20000,
> .dump_oops = 1,
> };
>
> --
> 2.26.0.rc2.310.g2932bb562d-goog
>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] platform/chrome: chromeos_pstore: set user space log size
2020-04-02 0:15 [PATCH 1/1] platform/chrome: chromeos_pstore: set user space log size Sarthak Kukreti
2020-04-02 7:10 ` Kees Cook
@ 2020-04-14 13:14 ` Enric Balletbo i Serra
1 sibling, 0 replies; 3+ messages in thread
From: Enric Balletbo i Serra @ 2020-04-14 13:14 UTC (permalink / raw)
To: Sarthak Kukreti, bleung
Cc: keescook, anton, linux-kernel, ccross, tony.luck, gwendal
Hi Sarthak,
Thank you for your patch.
On 2/4/20 2:15, Sarthak Kukreti wrote:
> On x86 ChromiumOS devices, the pmsg_size is set to 0 (check
> /sys/module/ramoops/parameters/pmsg_size): this prevents use of
> pstore-pmsg, even if CONFIG_PSTORE_PMSG is enabled. Set pmsg_size
> to a value that is consistent with the size used on non-x86 ChromiumOS
> devices.
>
> Signed-off-by: Sarthak Kukreti <sarthakkukreti@chromium.org>
> ---
Applied for 5.8
> drivers/platform/chrome/chromeos_pstore.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/chrome/chromeos_pstore.c b/drivers/platform/chrome/chromeos_pstore.c
> index d13770785fb5..82dea8cb5da1 100644
> --- a/drivers/platform/chrome/chromeos_pstore.c
> +++ b/drivers/platform/chrome/chromeos_pstore.c
> @@ -57,6 +57,7 @@ static struct ramoops_platform_data chromeos_ramoops_data = {
> .record_size = 0x40000,
> .console_size = 0x20000,
> .ftrace_size = 0x20000,
> + .pmsg_size = 0x20000,
> .dump_oops = 1,
> };
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-14 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-02 0:15 [PATCH 1/1] platform/chrome: chromeos_pstore: set user space log size Sarthak Kukreti
2020-04-02 7:10 ` Kees Cook
2020-04-14 13:14 ` Enric Balletbo i Serra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox