From: Steven Rostedt <rostedt@goodmis.org>
To: Joe Perches <joe@perches.com>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
devel@driverdev.osuosl.org, lkml <linux-kernel@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Douglas Anderson <dianders@chromium.org>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed
Date: Thu, 20 Aug 2020 23:08:04 -0400 [thread overview]
Message-ID: <20200820230804.7a9015af@oasis.local.home> (raw)
In-Reply-To: <20200820230459.2471c892@oasis.local.home>
On Thu, 20 Aug 2020 23:04:59 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 20 Aug 2020 19:49:59 -0700
> Joe Perches <joe@perches.com> wrote:
>
> > Perhaps make trace_printk dependent on #define DEBUG?
>
> This is basically what Nicolas's patch series does in this very patch!
>
> And no, I hate it. We are currently discussing ways of not having to
> modify the config in order to allow trace_printk() to be used.
>
> We don't want to burden the developer to take a config, add a bunch of
> trace_printks() and find that it's compiled out!
>
This also breaks another use case. You may be working on a module for a
production kernel. It is fine to include trace_printk() in your module,
and load it on the production kernel. You will get that banner when you
load your module, but that's OK because it is still under development.
But something like this change will prevent that from happening.
-- Steve
next prev parent reply other threads:[~2020-08-21 3:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 9:14 [PATCH v4 1/3, RESEND] media: camss: vfe: Use trace_printk for debugging only Nicolas Boichat
2020-08-20 9:14 ` [PATCH v4 2/3] kernel/trace: Add TRACING_ALLOW_PRINTK config option Nicolas Boichat
2020-08-20 9:14 ` [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed Nicolas Boichat
2020-08-20 14:23 ` Steven Rostedt
2020-08-21 0:13 ` Nicolas Boichat
2020-08-21 0:36 ` Steven Rostedt
2020-08-21 1:39 ` Nicolas Boichat
2020-08-21 1:57 ` Steven Rostedt
2020-08-21 2:36 ` Joe Perches
2020-08-21 2:42 ` Nicolas Boichat
2020-08-21 2:49 ` Joe Perches
2020-08-21 3:04 ` Steven Rostedt
2020-08-21 3:08 ` Steven Rostedt [this message]
2020-08-21 2:44 ` Steven Rostedt
2020-08-21 2:39 ` Nicolas Boichat
2020-08-21 3:01 ` Steven Rostedt
2020-08-21 12:19 ` Nicolas Boichat
2020-08-21 8:48 ` David Laight
2020-08-21 10:27 ` Nicolas Boichat
2020-08-21 11:32 ` David Laight
2020-08-21 12:07 ` Nicolas Boichat
2020-08-21 12:18 ` David Laight
2020-08-21 12:37 ` Nicolas Boichat
2020-08-20 14:21 ` [PATCH v4 1/3, RESEND] media: camss: vfe: Use trace_printk for debugging only Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820230804.7a9015af@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dianders@chromium.org \
--cc=drinkcat@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=joe@perches.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=peterz@infradead.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox