* [PATCH phy] PHY: Ingenic: fix unconditional build of phy-ingenic-usb
@ 2020-12-22 13:10 Alexander Lobakin
2020-12-23 4:29 ` Vinod Koul
2020-12-23 14:18 ` Zhou Yanjie
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Lobakin @ 2020-12-22 13:10 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul
Cc: 漆鹏振, Alexander Lobakin, Paul Cercueil,
周琰杰, Linus Torvalds, linux-kernel
Currently drivers/phy/ingenic/Makefile adds phy-ingenic-usb to targets
not depending on actual Kconfig symbol CONFIG_PHY_INGENIC_USB, so this
driver always gets built[-in] on every system.
Add missing dependency.
Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic PHY framework.")
Signed-off-by: Alexander Lobakin <alobakin@pm.me>
---
drivers/phy/ingenic/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/ingenic/Makefile b/drivers/phy/ingenic/Makefile
index 65d5ea00fc9d..1cb158d7233f 100644
--- a/drivers/phy/ingenic/Makefile
+++ b/drivers/phy/ingenic/Makefile
@@ -1,2 +1,2 @@
# SPDX-License-Identifier: GPL-2.0
-obj-y += phy-ingenic-usb.o
+obj-$(CONFIG_PHY_INGENIC_USB) += phy-ingenic-usb.o
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH phy] PHY: Ingenic: fix unconditional build of phy-ingenic-usb
2020-12-22 13:10 [PATCH phy] PHY: Ingenic: fix unconditional build of phy-ingenic-usb Alexander Lobakin
@ 2020-12-23 4:29 ` Vinod Koul
2020-12-23 14:18 ` Zhou Yanjie
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2020-12-23 4:29 UTC (permalink / raw)
To: Alexander Lobakin
Cc: Kishon Vijay Abraham I, 漆鹏振, Paul Cercueil,
周琰杰, Linus Torvalds, linux-kernel
On 22-12-20, 13:10, Alexander Lobakin wrote:
> Currently drivers/phy/ingenic/Makefile adds phy-ingenic-usb to targets
> not depending on actual Kconfig symbol CONFIG_PHY_INGENIC_USB, so this
> driver always gets built[-in] on every system.
> Add missing dependency.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH phy] PHY: Ingenic: fix unconditional build of phy-ingenic-usb
2020-12-22 13:10 [PATCH phy] PHY: Ingenic: fix unconditional build of phy-ingenic-usb Alexander Lobakin
2020-12-23 4:29 ` Vinod Koul
@ 2020-12-23 14:18 ` Zhou Yanjie
1 sibling, 0 replies; 3+ messages in thread
From: Zhou Yanjie @ 2020-12-23 14:18 UTC (permalink / raw)
To: Alexander Lobakin, Kishon Vijay Abraham I, Vinod Koul
Cc: 漆鹏振, Paul Cercueil, Linus Torvalds,
linux-kernel
Hi Alexander,
On 2020/12/22 下午9:10, Alexander Lobakin wrote:
> Currently drivers/phy/ingenic/Makefile adds phy-ingenic-usb to targets
> not depending on actual Kconfig symbol CONFIG_PHY_INGENIC_USB, so this
> driver always gets built[-in] on every system.
> Add missing dependency.
>
> Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic PHY framework.")
> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> ---
> drivers/phy/ingenic/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Apologize for my carelessness, and
Tested-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
Thanks and best regards!
> diff --git a/drivers/phy/ingenic/Makefile b/drivers/phy/ingenic/Makefile
> index 65d5ea00fc9d..1cb158d7233f 100644
> --- a/drivers/phy/ingenic/Makefile
> +++ b/drivers/phy/ingenic/Makefile
> @@ -1,2 +1,2 @@
> # SPDX-License-Identifier: GPL-2.0
> -obj-y += phy-ingenic-usb.o
> +obj-$(CONFIG_PHY_INGENIC_USB) += phy-ingenic-usb.o
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-23 14:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-22 13:10 [PATCH phy] PHY: Ingenic: fix unconditional build of phy-ingenic-usb Alexander Lobakin
2020-12-23 4:29 ` Vinod Koul
2020-12-23 14:18 ` Zhou Yanjie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox