* [PATCH -next] mtd: st_spi_fsm: use resource_size
@ 2021-01-06 13:18 Zheng Yongjun
2021-01-06 14:51 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2021-01-06 13:18 UTC (permalink / raw)
To: miquel.raynal, richard, vigneshr, linux-mtd, linux-kernel; +Cc: Zheng Yongjun
Use resource_size rather than a verbose computation on
the end and start fields.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/mtd/devices/st_spi_fsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
index 1888523d9745..983999c020d6 100644
--- a/drivers/mtd/devices/st_spi_fsm.c
+++ b/drivers/mtd/devices/st_spi_fsm.c
@@ -924,7 +924,7 @@ static int stfsm_read_status(struct stfsm *fsm, uint8_t cmd,
BUG_ON(bytes != 1 && bytes != 2);
seq->seq_opc[0] = (SEQ_OPC_PADS_1 | SEQ_OPC_CYCLES(8) |
- SEQ_OPC_OPCODE(cmd)),
+ SEQ_OPC_OPCODE(cmd));
stfsm_load_seq(fsm, seq);
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] mtd: st_spi_fsm: use resource_size
2021-01-06 13:18 [PATCH -next] mtd: st_spi_fsm: use resource_size Zheng Yongjun
@ 2021-01-06 14:51 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2021-01-06 14:51 UTC (permalink / raw)
To: Zheng Yongjun; +Cc: richard, vigneshr, linux-mtd, linux-kernel
Hello,
Zheng Yongjun <zhengyongjun3@huawei.com> wrote on Wed, 6 Jan 2021
21:18:47 +0800:
> Use resource_size rather than a verbose computation on
> the end and start fields.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/mtd/devices/st_spi_fsm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
> index 1888523d9745..983999c020d6 100644
> --- a/drivers/mtd/devices/st_spi_fsm.c
> +++ b/drivers/mtd/devices/st_spi_fsm.c
> @@ -924,7 +924,7 @@ static int stfsm_read_status(struct stfsm *fsm, uint8_t cmd,
> BUG_ON(bytes != 1 && bytes != 2);
>
> seq->seq_opc[0] = (SEQ_OPC_PADS_1 | SEQ_OPC_CYCLES(8) |
> - SEQ_OPC_OPCODE(cmd)),
> + SEQ_OPC_OPCODE(cmd));
>
> stfsm_load_seq(fsm, seq);
>
Same remark again, description and actual change do not match.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-06 14:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-06 13:18 [PATCH -next] mtd: st_spi_fsm: use resource_size Zheng Yongjun
2021-01-06 14:51 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox