From: Daniel Scally <djrscally@gmail.com>
To: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
Maximilian Luz <luzmaximilian@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: [RFC PATCH v2 2/3] Documentation: power: Document regulator_lookup_list
Date: Wed, 25 Aug 2021 00:06:19 +0100 [thread overview]
Message-ID: <20210824230620.1003828-3-djrscally@gmail.com> (raw)
In-Reply-To: <20210824230620.1003828-1-djrscally@gmail.com>
Add some explanatory documentation to machine.rst detailing when and
how to use the new regulator lookup functionality.
Signed-off-by: Daniel Scally <djrscally@gmail.com>
---
Changes in v2:
- Patch introduced
Documentation/power/regulator/machine.rst | 31 +++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/Documentation/power/regulator/machine.rst b/Documentation/power/regulator/machine.rst
index 22fffefaa3ad..7ad64e59b649 100644
--- a/Documentation/power/regulator/machine.rst
+++ b/Documentation/power/regulator/machine.rst
@@ -95,3 +95,34 @@ Finally the regulator devices must be registered in the usual manner::
/* register regulator 2 device */
platform_device_register(®ulator_devices[1]);
+
+Alternatively, if the struct regulator_init_data is being created in a process
+distinct from the registration of the regulator devices themselves (for example
+if the regulator devices themselves are enumerated through devicetree or ACPI
+but the system lacks regulator_init_data in firmware), then it must be added to
+a lookup table that will be checked when the regulator devices are registered.
+
+ static struct regulator_lookup regulator1_lookup = {
+ .device_name = "regulator.1",
+ .regulator_name = "Regulator-1",
+ .init_data = {
+ .constraints = {
+ .name = "Regulator-1",
+ .min_uV = 3300000,
+ .max_uV = 3300000,
+ .valid_ops_mask = REGULATOR_MODE_NORMAL,
+ },
+ .num_consumer_supplies = ARRAY_SIZE(regulator1_consumers),
+ .consumer_supplies = regulator1_consumers,
+ },
+ };
+
+ regulator_add_lookup(®ulator1_lookup);
+
+The .device_name field should match that of the struct device that the
+regulator driver will bind to. The .regulator_name field should match the name
+field in the struct regulator_desc that is used to register the regulator that
+this regulator_init_data is intended to be mapped to. Neither field can be null
+since regulator_register() will not allow the name field of the regulator_desc
+to be null, and without at least the device name we cannot guarantee we're
+passing the init_data to the right regulator.
--
2.25.1
next prev parent reply other threads:[~2021-08-24 23:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 23:06 [RFC PATCH v2 0/3] Add regulator_lookup_list and API Daniel Scally
2021-08-24 23:06 ` [RFC PATCH v2 1/3] regulator: core: Add regulator_lookup_list Daniel Scally
2021-08-25 10:33 ` Mark Brown
2021-08-25 11:10 ` Andy Shevchenko
2021-08-25 11:30 ` Mark Brown
2021-08-25 12:26 ` Andy Shevchenko
2021-08-25 13:11 ` Mark Brown
2021-08-25 13:59 ` Laurent Pinchart
2021-08-25 14:03 ` Laurent Pinchart
2021-08-25 14:33 ` Andy Shevchenko
2021-08-25 14:12 ` Daniel Scally
2021-08-25 14:22 ` Laurent Pinchart
2021-08-25 14:52 ` Mark Brown
2021-08-25 22:09 ` Daniel Scally
2021-08-26 12:40 ` Mark Brown
2021-08-25 14:41 ` Mark Brown
2021-08-25 14:48 ` Hans de Goede
2021-08-25 15:27 ` Mark Brown
2021-08-25 15:42 ` Laurent Pinchart
2021-08-25 16:13 ` Mark Brown
2021-08-25 20:25 ` Hans de Goede
2021-08-25 20:40 ` Laurent Pinchart
2021-08-25 21:24 ` Daniel Scally
2021-08-25 21:17 ` Daniel Scally
2021-08-24 23:06 ` Daniel Scally [this message]
2021-08-24 23:06 ` [RFC PATCH v2 3/3] platform/surface: Add Surface Go 2 board file Daniel Scally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824230620.1003828-3-djrscally@gmail.com \
--to=djrscally@gmail.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox