From: Mark Brown <broonie@kernel.org>
To: Daniel Scally <djrscally@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
Maximilian Luz <luzmaximilian@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Sakari Ailus <sakari.ailus@iki.fi>
Subject: Re: [RFC PATCH v2 1/3] regulator: core: Add regulator_lookup_list
Date: Thu, 26 Aug 2021 13:40:17 +0100 [thread overview]
Message-ID: <20210826124017.GC4148@sirena.org.uk> (raw)
In-Reply-To: <bce63128-3dde-f4c6-b0cd-00818293ebc3@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
On Wed, Aug 25, 2021 at 11:09:09PM +0100, Daniel Scally wrote:
> Alright; and what about parsing the platform data into a struct
> regulator_init_data then...at the moment that's left up to the
> individual regulator drivers. In my mind that's something better left to
> core, so rather than finding the right instance of struct
> regulator_init_data from the regulator_lookup_list the
> regulator_lookup_init_data() function would be finding the right
> instance of the struct from cfg->dev->platform_data instead...what are
> your thoughts on that?
That sounds like a useful helper to have - we need to let drivers have
custom platform data (especially for MFDs) but even there they could
use such a helper if they can point it at an array stored elsewhere.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-08-26 12:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 23:06 [RFC PATCH v2 0/3] Add regulator_lookup_list and API Daniel Scally
2021-08-24 23:06 ` [RFC PATCH v2 1/3] regulator: core: Add regulator_lookup_list Daniel Scally
2021-08-25 10:33 ` Mark Brown
2021-08-25 11:10 ` Andy Shevchenko
2021-08-25 11:30 ` Mark Brown
2021-08-25 12:26 ` Andy Shevchenko
2021-08-25 13:11 ` Mark Brown
2021-08-25 13:59 ` Laurent Pinchart
2021-08-25 14:03 ` Laurent Pinchart
2021-08-25 14:33 ` Andy Shevchenko
2021-08-25 14:12 ` Daniel Scally
2021-08-25 14:22 ` Laurent Pinchart
2021-08-25 14:52 ` Mark Brown
2021-08-25 22:09 ` Daniel Scally
2021-08-26 12:40 ` Mark Brown [this message]
2021-08-25 14:41 ` Mark Brown
2021-08-25 14:48 ` Hans de Goede
2021-08-25 15:27 ` Mark Brown
2021-08-25 15:42 ` Laurent Pinchart
2021-08-25 16:13 ` Mark Brown
2021-08-25 20:25 ` Hans de Goede
2021-08-25 20:40 ` Laurent Pinchart
2021-08-25 21:24 ` Daniel Scally
2021-08-25 21:17 ` Daniel Scally
2021-08-24 23:06 ` [RFC PATCH v2 2/3] Documentation: power: Document regulator_lookup_list Daniel Scally
2021-08-24 23:06 ` [RFC PATCH v2 3/3] platform/surface: Add Surface Go 2 board file Daniel Scally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210826124017.GC4148@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=djrscally@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox