From: Oleksij Rempel <o.rempel@pengutronix.de>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Anton Lundin <glance@acc.umu.se>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH net v1 2/2] net: usb: asix: do not force pause frames support
Date: Tue, 28 Jun 2022 06:49:42 +0200 [thread overview]
Message-ID: <20220628044942.GC13092@pengutronix.de> (raw)
In-Reply-To: <20220624075139.3139300-2-o.rempel@pengutronix.de>
On Fri, Jun 24, 2022 at 09:51:39AM +0200, Oleksij Rempel wrote:
> We should respect link partner capabilities and not force flow control
> support on every link. Even more, in current state the MAC driver do not
> advertises pause support so we should not keep flow control enabled at
> all.
>
> Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support")
> Reported-by: Anton Lundin <glance@acc.umu.se>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
In different mail thread Anton reported as tested.
Tested-by: Anton Lundin <glance@acc.umu.se>
> ---
> drivers/net/usb/asix.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/usb/asix.h b/drivers/net/usb/asix.h
> index 2c81236c6c7c..45d3cc5cc355 100644
> --- a/drivers/net/usb/asix.h
> +++ b/drivers/net/usb/asix.h
> @@ -126,8 +126,7 @@
> AX_MEDIUM_RE)
>
> #define AX88772_MEDIUM_DEFAULT \
> - (AX_MEDIUM_FD | AX_MEDIUM_RFC | \
> - AX_MEDIUM_TFC | AX_MEDIUM_PS | \
> + (AX_MEDIUM_FD | AX_MEDIUM_PS | \
> AX_MEDIUM_AC | AX_MEDIUM_RE)
>
> /* AX88772 & AX88178 RX_CTL values */
> --
> 2.30.2
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-06-28 4:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 7:51 [PATCH net v1 1/2] net: asix: fix "can't send until first packet is send" issue Oleksij Rempel
2022-06-24 7:51 ` [PATCH net v1 2/2] net: usb: asix: do not force pause frames support Oleksij Rempel
2022-06-28 4:49 ` Oleksij Rempel [this message]
2022-06-28 4:49 ` [PATCH net v1 1/2] net: asix: fix "can't send until first packet is send" issue Oleksij Rempel
2022-06-28 7:50 ` Lucas Stach
2022-06-28 8:00 ` Oleksij Rempel
2022-06-28 5:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628044942.GC13092@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=glance@acc.umu.se \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox