* [PATCH v1] drivers/fsl_linflexuart.c : remove redundant uart type
@ 2023-01-03 11:02 lizhe
2023-01-03 11:23 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: lizhe @ 2023-01-03 11:02 UTC (permalink / raw)
To: gregkh, jirislaby; +Cc: linux-serial, linux-kernel, lizhe
in linflex_config_port() the member variable will be
assigned again . see linflex_config_port()
Signed-off-by: lizhe <sensor1010@163.com>
---
drivers/tty/serial/fsl_linflexuart.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
index 6fc21b6684e6..34400cc6ac7f 100644
--- a/drivers/tty/serial/fsl_linflexuart.c
+++ b/drivers/tty/serial/fsl_linflexuart.c
@@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
return PTR_ERR(sport->membase);
sport->dev = &pdev->dev;
- sport->type = PORT_LINFLEXUART;
sport->iotype = UPIO_MEM;
sport->irq = platform_get_irq(pdev, 0);
sport->ops = &linflex_pops;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] drivers/fsl_linflexuart.c : remove redundant uart type
2023-01-03 11:02 [PATCH v1] drivers/fsl_linflexuart.c : remove redundant uart type lizhe
@ 2023-01-03 11:23 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2023-01-03 11:23 UTC (permalink / raw)
To: lizhe, gregkh; +Cc: linux-serial, linux-kernel
On 03. 01. 23, 12:02, lizhe wrote:
> in linflex_config_port() the member variable will be
> assigned again . see linflex_config_port()
Fine, but can you make the subject and the commit message a little bit
saner?
I.e. no tabs, no spaces before semicolons and colons. The subject should
be something like "serial: linflexuart: remove redundant uart type
_assignment_" and so on.
> Signed-off-by: lizhe <sensor1010@163.com>
Is this your legal name?
> ---
> drivers/tty/serial/fsl_linflexuart.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
> index 6fc21b6684e6..34400cc6ac7f 100644
> --- a/drivers/tty/serial/fsl_linflexuart.c
> +++ b/drivers/tty/serial/fsl_linflexuart.c
> @@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
> return PTR_ERR(sport->membase);
>
> sport->dev = &pdev->dev;
> - sport->type = PORT_LINFLEXUART;
> sport->iotype = UPIO_MEM;
> sport->irq = platform_get_irq(pdev, 0);
> sport->ops = &linflex_pops;
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-03 11:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-03 11:02 [PATCH v1] drivers/fsl_linflexuart.c : remove redundant uart type lizhe
2023-01-03 11:23 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox