From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] speakup: Fix warning comparing pointer to 0
Date: Fri, 6 Jan 2023 01:52:01 +0100 [thread overview]
Message-ID: <20230106005201.h3ikdaisqgjupavc@begin> (raw)
In-Reply-To: <20230106004114.72589-1-yang.lee@linux.alibaba.com>
Yang Li, le ven. 06 janv. 2023 08:41:14 +0800, a ecrit:
> ./drivers/accessibility/speakup/utils.h:39:15-16: WARNING comparing pointer to 0
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3636
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/accessibility/speakup/utils.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> index 4ce9a12f7664..db00c962f8e2 100644
> --- a/drivers/accessibility/speakup/utils.h
> +++ b/drivers/accessibility/speakup/utils.h
> @@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
> else
> snprintf(filename, sizeof(filename), "%s", name);
> infile = fopen(filename, "r");
> - if (infile == 0) {
> + if (!infile) {
> fprintf(stderr, "can't open %s\n", filename);
> exit(1);
> }
> --
> 2.20.1.7.g153144c
>
--
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.
prev parent reply other threads:[~2023-01-06 0:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 0:41 [PATCH -next] speakup: Fix warning comparing pointer to 0 Yang Li
2023-01-06 0:52 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230106005201.h3ikdaisqgjupavc@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=abaci@linux.alibaba.com \
--cc=chris@the-brannons.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox