* [PATCH -next] speakup: Fix warning comparing pointer to 0
@ 2023-01-06 0:41 Yang Li
2023-01-06 0:52 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2023-01-06 0:41 UTC (permalink / raw)
To: samuel.thibault
Cc: w.d.hubbs, chris, kirk, speakup, linux-kernel, Yang Li,
Abaci Robot
./drivers/accessibility/speakup/utils.h:39:15-16: WARNING comparing pointer to 0
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3636
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/accessibility/speakup/utils.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
index 4ce9a12f7664..db00c962f8e2 100644
--- a/drivers/accessibility/speakup/utils.h
+++ b/drivers/accessibility/speakup/utils.h
@@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
else
snprintf(filename, sizeof(filename), "%s", name);
infile = fopen(filename, "r");
- if (infile == 0) {
+ if (!infile) {
fprintf(stderr, "can't open %s\n", filename);
exit(1);
}
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] speakup: Fix warning comparing pointer to 0
2023-01-06 0:41 [PATCH -next] speakup: Fix warning comparing pointer to 0 Yang Li
@ 2023-01-06 0:52 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2023-01-06 0:52 UTC (permalink / raw)
To: Yang Li; +Cc: w.d.hubbs, chris, kirk, speakup, linux-kernel, Abaci Robot
Yang Li, le ven. 06 janv. 2023 08:41:14 +0800, a ecrit:
> ./drivers/accessibility/speakup/utils.h:39:15-16: WARNING comparing pointer to 0
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3636
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/accessibility/speakup/utils.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> index 4ce9a12f7664..db00c962f8e2 100644
> --- a/drivers/accessibility/speakup/utils.h
> +++ b/drivers/accessibility/speakup/utils.h
> @@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
> else
> snprintf(filename, sizeof(filename), "%s", name);
> infile = fopen(filename, "r");
> - if (infile == 0) {
> + if (!infile) {
> fprintf(stderr, "can't open %s\n", filename);
> exit(1);
> }
> --
> 2.20.1.7.g153144c
>
--
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-06 0:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-06 0:41 [PATCH -next] speakup: Fix warning comparing pointer to 0 Yang Li
2023-01-06 0:52 ` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox