public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	intel-gvt-dev@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com,
	daniel.vetter@ffwll.ch, seanpaul@chromium.org,
	robdclark@gmail.com, jbaron@akamai.com,
	gregkh@linuxfoundation.org, Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH v2 16/20] test-dyndbg: rename DD_SYS_WRAP to DYNDBG_CLASSMAP_PARAM
Date: Fri, 13 Jan 2023 12:30:12 -0700	[thread overview]
Message-ID: <20230113193016.749791-17-jim.cromie@gmail.com> (raw)
In-Reply-To: <20230113193016.749791-1-jim.cromie@gmail.com>

Original name was a punt; but the macro is maybe general enough to put
in the API later.  Rename and improve the macro towards that end.

Also tweak internal name constructed in the macro, to add a '_'
between the name components.  This changes the .i file only.

no functional change.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 lib/test_dynamic_debug.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c
index 39d4f63cade1..45e123b29a9b 100644
--- a/lib/test_dynamic_debug.c
+++ b/lib/test_dynamic_debug.c
@@ -44,14 +44,15 @@ module_param_cb(do_prints, &param_ops_do_prints, NULL, 0600);
  * Additionally, here:
  * - tie together sysname, mapname, bitsname, flagsname
  */
-#define DD_SYS_WRAP(_model, _flags)					\
+#define DYNDBG_CLASSMAP_PARAM(_model, _flags)					\
 	static unsigned long bits_##_model;				\
-	static struct ddebug_class_param _flags##_model = {		\
+	static struct ddebug_class_param _flags##_##_model = {		\
 		.bits = &bits_##_model,					\
 		.flags = #_flags,					\
 		.map = &map_##_model,					\
 	};								\
-	module_param_cb(_flags##_##_model, &param_ops_dyndbg_classes, &_flags##_model, 0600)
+	module_param_cb(_flags##_##_model, &param_ops_dyndbg_classes,	\
+			&_flags##_##_model, 0600)
 
 /*
  * dynamic-debug imitates drm.debug model's use of enums (DRM_UT_CORE
@@ -112,23 +113,23 @@ DYNDBG_CLASSMAP_DEFINE(map_disjoint_bits, DD_CLASS_TYPE_DISJOINT_BITS,
 		       D2_LEASE,
 		       D2_DP,
 		       D2_DRMRES);
-DD_SYS_WRAP(disjoint_bits, p);
-DD_SYS_WRAP(disjoint_bits, T);
+DYNDBG_CLASSMAP_PARAM(disjoint_bits, p);
+DYNDBG_CLASSMAP_PARAM(disjoint_bits, T);
 
 DYNDBG_CLASSMAP_DEFINE(map_disjoint_names, DD_CLASS_TYPE_DISJOINT_NAMES,
 		       LOW, MID, HI);
-DD_SYS_WRAP(disjoint_names, p);
-DD_SYS_WRAP(disjoint_names, T);
+DYNDBG_CLASSMAP_PARAM(disjoint_names, p);
+DYNDBG_CLASSMAP_PARAM(disjoint_names, T);
 
 DYNDBG_CLASSMAP_DEFINE(map_level_num, DD_CLASS_TYPE_LEVEL_NUM,
 		       V0, V1, V2, V3, V4, V5, V6, V7);
-DD_SYS_WRAP(level_num, p);
-DD_SYS_WRAP(level_num, T);
+DYNDBG_CLASSMAP_PARAM(level_num, p);
+DYNDBG_CLASSMAP_PARAM(level_num, T);
 
 DYNDBG_CLASSMAP_DEFINE(map_level_names, DD_CLASS_TYPE_LEVEL_NAMES,
 		       L0, L1, L2, L3, L4, L5, L6, L7);
-DD_SYS_WRAP(level_names, p);
-DD_SYS_WRAP(level_names, T);
+DYNDBG_CLASSMAP_PARAM(level_names, p);
+DYNDBG_CLASSMAP_PARAM(level_names, T);
 
 #endif /* TEST_DYNAMIC_DEBUG_SUBMOD */
 
-- 
2.39.0


  parent reply	other threads:[~2023-01-13 19:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 19:29 [PATCH v2 00/20] DRM_USE_DYNAMIC_DEBUG regression Jim Cromie
2023-01-13 19:29 ` [PATCH v2 01/20] test-dyndbg: fixup CLASSMAP usage error Jim Cromie
2023-01-13 19:29 ` [PATCH v2 02/20] test-dyndbg: show that DEBUG enables prdbgs at compiletime Jim Cromie
2023-01-13 19:29 ` [PATCH v2 03/20] dyndbg: replace classmap list with a vector Jim Cromie
2023-01-13 19:30 ` [PATCH v2 04/20] dyndbg: make ddebug_apply_class_bitmap more selective Jim Cromie
2023-01-13 19:30 ` [PATCH v2 05/20] dyndbg: split param_set_dyndbg_classes to inner/outer Jim Cromie
2023-01-13 19:30 ` [PATCH v2 06/20] dyndbg: drop NUM_TYPE_ARRAY Jim Cromie
2023-01-13 19:30 ` [PATCH v2 07/20] dyndbg: reduce verbose/debug clutter Jim Cromie
2023-01-13 19:30 ` [PATCH v2 08/20] dyndbg: tighten ddebug_class_name() 1st arg Jim Cromie
2023-01-13 19:30 ` [PATCH v2 09/20] dyndbg: constify ddebug_apply_class_bitmap args Jim Cromie
2023-01-13 19:30 ` [PATCH v2 10/20] dyndbg-API: split DECLARE_(DYNDBG_CLASSMAP) to $1(_DEFINE|_USE) Jim Cromie
2023-01-13 19:30 ` [PATCH v2 11/20] dyndbg-API: specialize DYNDBG_CLASSMAP_(DEFINE|USE) Jim Cromie
2023-01-13 19:30 ` [PATCH v2 12/20] dyndbg-API: DYNDBG_CLASSMAP_USE drop extra args Jim Cromie
2023-01-13 19:30 ` [PATCH v2 13/20] dyndbg-API: DYNDBG_CLASSMAP_DEFINE() improvements Jim Cromie
2023-01-13 19:30 ` [PATCH v2 14/20] drm_print: fix stale macro-name in comment Jim Cromie
2023-01-13 19:30 ` [PATCH v2 15/20] test-dyndbg: build test_dynamic_debug_submod Jim Cromie
2023-01-13 19:30 ` Jim Cromie [this message]
2023-01-13 19:30 ` [PATCH v2 17/20] test-dyndbg: disable WIP dyndbg-trace params Jim Cromie
2023-01-13 19:30 ` [PATCH v2 18/20] test-dyndbg: tune sub-module behavior Jim Cromie
2023-01-13 19:30 ` [PATCH v2 19/20] dyndbg: unwrap __ddebug_add_module inner function NOTYET Jim Cromie
2023-01-13 19:30 ` [PATCH v2 20/20] jump_label: RFC - tolerate toggled state Jim Cromie
2023-01-17 11:57   ` Peter Zijlstra
2023-02-16 17:21     ` Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230113193016.749791-17-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jbaron@akamai.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=seanpaul@chromium.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox