public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	intel-gvt-dev@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com,
	daniel.vetter@ffwll.ch, seanpaul@chromium.org,
	robdclark@gmail.com, jbaron@akamai.com,
	gregkh@linuxfoundation.org, Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH v2 02/20] test-dyndbg: show that DEBUG enables prdbgs at compiletime
Date: Fri, 13 Jan 2023 12:29:58 -0700	[thread overview]
Message-ID: <20230113193016.749791-3-jim.cromie@gmail.com> (raw)
In-Reply-To: <20230113193016.749791-1-jim.cromie@gmail.com>

Dyndbg is required to enable prdbgs at compile-time if DEBUG is
defined.  Show this works; add the defn to test_dynamic_debug.c,
and manually inspect/verify its effect at module load:

[   15.292810] dyndbg: module:test_dynamic_debug attached 4 classes
[   15.293189] dyndbg:  32 debug prints in module test_dynamic_debug
[   15.293715] test_dd: init start
[   15.293716] test_dd: doing categories
[   15.293716] test_dd: LOW msg
...
[   15.293733] test_dd: L6 msg
[   15.293733] test_dd: L7 msg
[   15.293733] test_dd: init done

NOTES:

As is observable above, define DEBUG enables all prdbgs, including
those in mod_init-fn, and more notably, the class'd ones (callsites
with non-default class_ids).

This differs from the >control interface, which in order to properly
protect a client's class'd prdbgs, requires a "class FOO" in queries
to change them.  If this sounds wrong, note that the DEBUG is in the
module source file, and is thus privileged.

This yields an occaisional surprise; the following disables all the
compile-time enabled plain prdbgs, but leaves the class'd ones
enabled.

 :#> modprobe test_dynamic_debug dyndbg==_

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 lib/test_dynamic_debug.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c
index a01f0193a419..89dd7f285e31 100644
--- a/lib/test_dynamic_debug.c
+++ b/lib/test_dynamic_debug.c
@@ -8,6 +8,8 @@
 
 #define pr_fmt(fmt) "test_dd: " fmt
 
+#define DEBUG /* enable all prdbgs (plain & class'd) at compiletime */
+
 #include <linux/module.h>
 
 /* run tests by reading or writing sysfs node: do_prints */
-- 
2.39.0


  parent reply	other threads:[~2023-01-13 19:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 19:29 [PATCH v2 00/20] DRM_USE_DYNAMIC_DEBUG regression Jim Cromie
2023-01-13 19:29 ` [PATCH v2 01/20] test-dyndbg: fixup CLASSMAP usage error Jim Cromie
2023-01-13 19:29 ` Jim Cromie [this message]
2023-01-13 19:29 ` [PATCH v2 03/20] dyndbg: replace classmap list with a vector Jim Cromie
2023-01-13 19:30 ` [PATCH v2 04/20] dyndbg: make ddebug_apply_class_bitmap more selective Jim Cromie
2023-01-13 19:30 ` [PATCH v2 05/20] dyndbg: split param_set_dyndbg_classes to inner/outer Jim Cromie
2023-01-13 19:30 ` [PATCH v2 06/20] dyndbg: drop NUM_TYPE_ARRAY Jim Cromie
2023-01-13 19:30 ` [PATCH v2 07/20] dyndbg: reduce verbose/debug clutter Jim Cromie
2023-01-13 19:30 ` [PATCH v2 08/20] dyndbg: tighten ddebug_class_name() 1st arg Jim Cromie
2023-01-13 19:30 ` [PATCH v2 09/20] dyndbg: constify ddebug_apply_class_bitmap args Jim Cromie
2023-01-13 19:30 ` [PATCH v2 10/20] dyndbg-API: split DECLARE_(DYNDBG_CLASSMAP) to $1(_DEFINE|_USE) Jim Cromie
2023-01-13 19:30 ` [PATCH v2 11/20] dyndbg-API: specialize DYNDBG_CLASSMAP_(DEFINE|USE) Jim Cromie
2023-01-13 19:30 ` [PATCH v2 12/20] dyndbg-API: DYNDBG_CLASSMAP_USE drop extra args Jim Cromie
2023-01-13 19:30 ` [PATCH v2 13/20] dyndbg-API: DYNDBG_CLASSMAP_DEFINE() improvements Jim Cromie
2023-01-13 19:30 ` [PATCH v2 14/20] drm_print: fix stale macro-name in comment Jim Cromie
2023-01-13 19:30 ` [PATCH v2 15/20] test-dyndbg: build test_dynamic_debug_submod Jim Cromie
2023-01-13 19:30 ` [PATCH v2 16/20] test-dyndbg: rename DD_SYS_WRAP to DYNDBG_CLASSMAP_PARAM Jim Cromie
2023-01-13 19:30 ` [PATCH v2 17/20] test-dyndbg: disable WIP dyndbg-trace params Jim Cromie
2023-01-13 19:30 ` [PATCH v2 18/20] test-dyndbg: tune sub-module behavior Jim Cromie
2023-01-13 19:30 ` [PATCH v2 19/20] dyndbg: unwrap __ddebug_add_module inner function NOTYET Jim Cromie
2023-01-13 19:30 ` [PATCH v2 20/20] jump_label: RFC - tolerate toggled state Jim Cromie
2023-01-17 11:57   ` Peter Zijlstra
2023-02-16 17:21     ` Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230113193016.749791-3-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jbaron@akamai.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=seanpaul@chromium.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox