* [PATCH] remoteproc: pru: remove always true check positive unsigned value
@ 2023-04-04 12:44 Simon Horman
2023-04-04 12:51 ` Mukesh Ojha
2023-04-05 16:59 ` Mathieu Poirier
0 siblings, 2 replies; 3+ messages in thread
From: Simon Horman @ 2023-04-04 12:44 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier
Cc: Dan Carpenter, linux-remoteproc, linux-kernel, kernel test robot,
Simon Horman
In both cases they type of da is u32. And PRU_PDRAM_DA is 0.
So the check da >= PRU_PDRAM_DA is always true and can be removed.
Flagged by Smatch:
drivers/remoteproc/pru_rproc.c:660 pru_d_da_to_va() warn: always true condition '(da >= 0) => (0-u32max >= 0)'
drivers/remoteproc/pru_rproc.c:709 pru_i_da_to_va() warn: always true condition '(da >= 0) => (0-u32max >= 0)'
No functional changes intended.
Compile tested only.
Reported-by: kernel test robot <lkp@intel.com>
Link: https://www.spinics.net/lists/kernel/msg4025983.html
Signed-off-by: Simon Horman <horms@kernel.org>
---
drivers/remoteproc/pru_rproc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
index b76db7fa693d..095f66130f48 100644
--- a/drivers/remoteproc/pru_rproc.c
+++ b/drivers/remoteproc/pru_rproc.c
@@ -657,7 +657,7 @@ static void *pru_d_da_to_va(struct pru_rproc *pru, u32 da, size_t len)
swap(dram0, dram1);
shrd_ram = pruss->mem_regions[PRUSS_MEM_SHRD_RAM2];
- if (da >= PRU_PDRAM_DA && da + len <= PRU_PDRAM_DA + dram0.size) {
+ if (da + len <= PRU_PDRAM_DA + dram0.size) {
offset = da - PRU_PDRAM_DA;
va = (__force void *)(dram0.va + offset);
} else if (da >= PRU_SDRAM_DA &&
@@ -706,8 +706,7 @@ static void *pru_i_da_to_va(struct pru_rproc *pru, u32 da, size_t len)
*/
da &= 0xfffff;
- if (da >= PRU_IRAM_DA &&
- da + len <= PRU_IRAM_DA + pru->mem_regions[PRU_IOMEM_IRAM].size) {
+ if (da + len <= PRU_IRAM_DA + pru->mem_regions[PRU_IOMEM_IRAM].size) {
offset = da - PRU_IRAM_DA;
va = (__force void *)(pru->mem_regions[PRU_IOMEM_IRAM].va +
offset);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] remoteproc: pru: remove always true check positive unsigned value
2023-04-04 12:44 [PATCH] remoteproc: pru: remove always true check positive unsigned value Simon Horman
@ 2023-04-04 12:51 ` Mukesh Ojha
2023-04-05 16:59 ` Mathieu Poirier
1 sibling, 0 replies; 3+ messages in thread
From: Mukesh Ojha @ 2023-04-04 12:51 UTC (permalink / raw)
To: Simon Horman, Bjorn Andersson, Mathieu Poirier
Cc: Dan Carpenter, linux-remoteproc, linux-kernel, kernel test robot
On 4/4/2023 6:14 PM, Simon Horman wrote:
> In both cases they type of da is u32. And PRU_PDRAM_DA is 0.
> So the check da >= PRU_PDRAM_DA is always true and can be removed.
>
> Flagged by Smatch:
>
> drivers/remoteproc/pru_rproc.c:660 pru_d_da_to_va() warn: always true condition '(da >= 0) => (0-u32max >= 0)'
> drivers/remoteproc/pru_rproc.c:709 pru_i_da_to_va() warn: always true condition '(da >= 0) => (0-u32max >= 0)'
>
> No functional changes intended.
> Compile tested only.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://www.spinics.net/lists/kernel/msg4025983.html
> Signed-off-by: Simon Horman <horms@kernel.org>
> ---
> drivers/remoteproc/pru_rproc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
> index b76db7fa693d..095f66130f48 100644
> --- a/drivers/remoteproc/pru_rproc.c
> +++ b/drivers/remoteproc/pru_rproc.c
> @@ -657,7 +657,7 @@ static void *pru_d_da_to_va(struct pru_rproc *pru, u32 da, size_t len)
> swap(dram0, dram1);
> shrd_ram = pruss->mem_regions[PRUSS_MEM_SHRD_RAM2];
>
> - if (da >= PRU_PDRAM_DA && da + len <= PRU_PDRAM_DA + dram0.size) {
> + if (da + len <= PRU_PDRAM_DA + dram0.size) {
> offset = da - PRU_PDRAM_DA;
> va = (__force void *)(dram0.va + offset);
> } else if (da >= PRU_SDRAM_DA &&
> @@ -706,8 +706,7 @@ static void *pru_i_da_to_va(struct pru_rproc *pru, u32 da, size_t len)
> */
> da &= 0xfffff;
>
> - if (da >= PRU_IRAM_DA &&
> - da + len <= PRU_IRAM_DA + pru->mem_regions[PRU_IOMEM_IRAM].size) {
> + if (da + len <= PRU_IRAM_DA + pru->mem_regions[PRU_IOMEM_IRAM].size) {
> offset = da - PRU_IRAM_DA;
> va = (__force void *)(pru->mem_regions[PRU_IOMEM_IRAM].va +
LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
--Mukesh
> offset);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] remoteproc: pru: remove always true check positive unsigned value
2023-04-04 12:44 [PATCH] remoteproc: pru: remove always true check positive unsigned value Simon Horman
2023-04-04 12:51 ` Mukesh Ojha
@ 2023-04-05 16:59 ` Mathieu Poirier
1 sibling, 0 replies; 3+ messages in thread
From: Mathieu Poirier @ 2023-04-05 16:59 UTC (permalink / raw)
To: Simon Horman
Cc: Bjorn Andersson, Dan Carpenter, linux-remoteproc, linux-kernel,
kernel test robot
On Tue, Apr 04, 2023 at 02:44:53PM +0200, Simon Horman wrote:
> In both cases they type of da is u32. And PRU_PDRAM_DA is 0.
> So the check da >= PRU_PDRAM_DA is always true and can be removed.
>
> Flagged by Smatch:
>
> drivers/remoteproc/pru_rproc.c:660 pru_d_da_to_va() warn: always true condition '(da >= 0) => (0-u32max >= 0)'
> drivers/remoteproc/pru_rproc.c:709 pru_i_da_to_va() warn: always true condition '(da >= 0) => (0-u32max >= 0)'
>
> No functional changes intended.
> Compile tested only.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://www.spinics.net/lists/kernel/msg4025983.html
> Signed-off-by: Simon Horman <horms@kernel.org>
> ---
> drivers/remoteproc/pru_rproc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
Applied
Thanks,
Mathieu
> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
> index b76db7fa693d..095f66130f48 100644
> --- a/drivers/remoteproc/pru_rproc.c
> +++ b/drivers/remoteproc/pru_rproc.c
> @@ -657,7 +657,7 @@ static void *pru_d_da_to_va(struct pru_rproc *pru, u32 da, size_t len)
> swap(dram0, dram1);
> shrd_ram = pruss->mem_regions[PRUSS_MEM_SHRD_RAM2];
>
> - if (da >= PRU_PDRAM_DA && da + len <= PRU_PDRAM_DA + dram0.size) {
> + if (da + len <= PRU_PDRAM_DA + dram0.size) {
> offset = da - PRU_PDRAM_DA;
> va = (__force void *)(dram0.va + offset);
> } else if (da >= PRU_SDRAM_DA &&
> @@ -706,8 +706,7 @@ static void *pru_i_da_to_va(struct pru_rproc *pru, u32 da, size_t len)
> */
> da &= 0xfffff;
>
> - if (da >= PRU_IRAM_DA &&
> - da + len <= PRU_IRAM_DA + pru->mem_regions[PRU_IOMEM_IRAM].size) {
> + if (da + len <= PRU_IRAM_DA + pru->mem_regions[PRU_IOMEM_IRAM].size) {
> offset = da - PRU_IRAM_DA;
> va = (__force void *)(pru->mem_regions[PRU_IOMEM_IRAM].va +
> offset);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-05 17:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-04 12:44 [PATCH] remoteproc: pru: remove always true check positive unsigned value Simon Horman
2023-04-04 12:51 ` Mukesh Ojha
2023-04-05 16:59 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox