[PATCHv2 net] selftests: fib_tests: mute cleanup error message

[PATCHv2 net] selftests: fib_tests: mute cleanup error message

[Po-Hsu Lin]

In the end of the test, there will be an error message induced by the
`ip netns del ns1` command in cleanup()

  Tests passed: 201
  Tests failed:   0
  Cannot remove namespace file "/run/netns/ns1": No such file or directory

This can even be reproduced with just `./fib_tests.sh -h` as we're
calling cleanup() on exit.

Redirect the error message to /dev/null to mute it.

V2: Update commit message and fixes tag.

Fixes: b60417a9f2b8 ("selftest: fib_tests: Always cleanup before exit")
Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
---
 tools/testing/selftests/net/fib_tests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh
index 7da8ec8..35d89df 100755
--- a/tools/testing/selftests/net/fib_tests.sh
+++ b/tools/testing/selftests/net/fib_tests.sh
@@ -68,7 +68,7 @@ setup()
 cleanup()
 {
 	$IP link del dev dummy0 &> /dev/null
-	ip netns del ns1
+	ip netns del ns1 &> /dev/null
 	ip netns del ns2 &> /dev/null
 }
 
-- 
2.7.4

Re: [PATCHv2 net] selftests: fib_tests: mute cleanup error message

[Jakub Kicinski]

On Thu, 18 May 2023 11:33:10 +0800 Po-Hsu Lin wrote:
> In the end of the test, there will be an error message induced by the
> `ip netns del ns1` command in cleanup()
> 
>   Tests passed: 201
>   Tests failed:   0
>   Cannot remove namespace file "/run/netns/ns1": No such file or directory
> 
> This can even be reproduced with just `./fib_tests.sh -h` as we're
> calling cleanup() on exit.
> 
> Redirect the error message to /dev/null to mute it.
> 
> V2: Update commit message and fixes tag.
> 
> Fixes: b60417a9f2b8 ("selftest: fib_tests: Always cleanup before exit")
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>

missing cc netdev

Re: [PATCHv2 net] selftests: fib_tests: mute cleanup error message

[Po-Hsu Lin]

On Thu, May 18, 2023 at 11:51 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Thu, 18 May 2023 11:33:10 +0800 Po-Hsu Lin wrote:
> > In the end of the test, there will be an error message induced by the
> > `ip netns del ns1` command in cleanup()
> >
> >   Tests passed: 201
> >   Tests failed:   0
> >   Cannot remove namespace file "/run/netns/ns1": No such file or directory
> >
> > This can even be reproduced with just `./fib_tests.sh -h` as we're
> > calling cleanup() on exit.
> >
> > Redirect the error message to /dev/null to mute it.
> >
> > V2: Update commit message and fixes tag.
> >
> > Fixes: b60417a9f2b8 ("selftest: fib_tests: Always cleanup before exit")
> > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
>
> missing cc netdev
Sorry my bad, wrong copy-paste, will improve the workflow to make sure
this won't happen again.
V3 is on its way