* [PATCHv2 net] selftests: fib_tests: mute cleanup error message
@ 2023-05-18 3:33 Po-Hsu Lin
2023-05-18 3:51 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Po-Hsu Lin @ 2023-05-18 3:33 UTC (permalink / raw)
To: linux-kernel, linux-kselftest
Cc: po-hsu.lin, roxana.nicolescu, shuah, pabeni, kuba, edumazet,
davem
In the end of the test, there will be an error message induced by the
`ip netns del ns1` command in cleanup()
Tests passed: 201
Tests failed: 0
Cannot remove namespace file "/run/netns/ns1": No such file or directory
This can even be reproduced with just `./fib_tests.sh -h` as we're
calling cleanup() on exit.
Redirect the error message to /dev/null to mute it.
V2: Update commit message and fixes tag.
Fixes: b60417a9f2b8 ("selftest: fib_tests: Always cleanup before exit")
Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
---
tools/testing/selftests/net/fib_tests.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh
index 7da8ec8..35d89df 100755
--- a/tools/testing/selftests/net/fib_tests.sh
+++ b/tools/testing/selftests/net/fib_tests.sh
@@ -68,7 +68,7 @@ setup()
cleanup()
{
$IP link del dev dummy0 &> /dev/null
- ip netns del ns1
+ ip netns del ns1 &> /dev/null
ip netns del ns2 &> /dev/null
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCHv2 net] selftests: fib_tests: mute cleanup error message
2023-05-18 3:33 [PATCHv2 net] selftests: fib_tests: mute cleanup error message Po-Hsu Lin
@ 2023-05-18 3:51 ` Jakub Kicinski
2023-05-18 4:30 ` Po-Hsu Lin
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2023-05-18 3:51 UTC (permalink / raw)
To: Po-Hsu Lin
Cc: linux-kernel, linux-kselftest, roxana.nicolescu, shuah, pabeni,
edumazet, davem
On Thu, 18 May 2023 11:33:10 +0800 Po-Hsu Lin wrote:
> In the end of the test, there will be an error message induced by the
> `ip netns del ns1` command in cleanup()
>
> Tests passed: 201
> Tests failed: 0
> Cannot remove namespace file "/run/netns/ns1": No such file or directory
>
> This can even be reproduced with just `./fib_tests.sh -h` as we're
> calling cleanup() on exit.
>
> Redirect the error message to /dev/null to mute it.
>
> V2: Update commit message and fixes tag.
>
> Fixes: b60417a9f2b8 ("selftest: fib_tests: Always cleanup before exit")
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
missing cc netdev
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCHv2 net] selftests: fib_tests: mute cleanup error message
2023-05-18 3:51 ` Jakub Kicinski
@ 2023-05-18 4:30 ` Po-Hsu Lin
0 siblings, 0 replies; 3+ messages in thread
From: Po-Hsu Lin @ 2023-05-18 4:30 UTC (permalink / raw)
To: Jakub Kicinski
Cc: linux-kernel, linux-kselftest, roxana.nicolescu, shuah, pabeni,
edumazet, davem
On Thu, May 18, 2023 at 11:51 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Thu, 18 May 2023 11:33:10 +0800 Po-Hsu Lin wrote:
> > In the end of the test, there will be an error message induced by the
> > `ip netns del ns1` command in cleanup()
> >
> > Tests passed: 201
> > Tests failed: 0
> > Cannot remove namespace file "/run/netns/ns1": No such file or directory
> >
> > This can even be reproduced with just `./fib_tests.sh -h` as we're
> > calling cleanup() on exit.
> >
> > Redirect the error message to /dev/null to mute it.
> >
> > V2: Update commit message and fixes tag.
> >
> > Fixes: b60417a9f2b8 ("selftest: fib_tests: Always cleanup before exit")
> > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
>
> missing cc netdev
Sorry my bad, wrong copy-paste, will improve the workflow to make sure
this won't happen again.
V3 is on its way
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-18 4:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-18 3:33 [PATCHv2 net] selftests: fib_tests: mute cleanup error message Po-Hsu Lin
2023-05-18 3:51 ` Jakub Kicinski
2023-05-18 4:30 ` Po-Hsu Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox