From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Osama Muhammad <osmtendev@gmail.com>,
Sasha Levin <sashal@kernel.org>,
lgirdwood@gmail.com, broonie@kernel.org
Subject: [PATCH AUTOSEL 4.19 05/13] regulator: Fix error checking for debugfs_create_dir
Date: Wed, 31 May 2023 09:45:33 -0400 [thread overview]
Message-ID: <20230531134541.3385043-5-sashal@kernel.org> (raw)
In-Reply-To: <20230531134541.3385043-1-sashal@kernel.org>
From: Osama Muhammad <osmtendev@gmail.com>
[ Upstream commit 2bf1c45be3b8f3a3f898d0756c1282f09719debd ]
This patch fixes the error checking in core.c in debugfs_create_dir.
The correct way to check if an error occurred is 'IS_ERR' inline function.
Signed-off-by: Osama Muhammad <osmtendev@gmail.com
Suggested-by: Ivan Orlov <ivan.orlov0322@gmail.com
Link: https://lore.kernel.org/r/20230515172938.13338-1-osmtendev@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/regulator/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 11656b3836748..14f9977f1ec08 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -4181,7 +4181,7 @@ static void rdev_init_debugfs(struct regulator_dev *rdev)
}
rdev->debugfs = debugfs_create_dir(rname, debugfs_root);
- if (!rdev->debugfs) {
+ if (IS_ERR(rdev->debugfs)) {
rdev_warn(rdev, "Failed to create debugfs directory\n");
return;
}
@@ -4843,7 +4843,7 @@ static int __init regulator_init(void)
ret = class_register(®ulator_class);
debugfs_root = debugfs_create_dir("regulator", NULL);
- if (!debugfs_root)
+ if (IS_ERR(debugfs_root))
pr_warn("regulator: Failed to create debugfs directory\n");
debugfs_create_file("supply_map", 0444, debugfs_root, NULL,
--
2.39.2
next prev parent reply other threads:[~2023-05-31 13:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 13:45 [PATCH AUTOSEL 4.19 01/13] power: supply: ab8500: Fix external_power_changed race Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 02/13] power: supply: bq27xxx: Use mod_delayed_work() instead of cancel() + schedule() Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 03/13] ARM: dts: vexpress: add missing cache properties Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 04/13] power: supply: Ratelimit no data debug output Sasha Levin
2023-05-31 13:45 ` Sasha Levin [this message]
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 06/13] irqchip/meson-gpio: Mark OF related data as maybe unused Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 07/13] power: supply: Fix logic checking if system is running from battery Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 08/13] parisc: Improve cache flushing for PCXL in arch_sync_dma_for_cpu() Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 09/13] parisc: Flush gatt writes and adjust gatt mask in parisc_agp_mask_memory() Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 10/13] MIPS: Restore Au1300 support Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 11/13] MIPS: Alchemy: fix dbdma2 Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 12/13] mips: Move initrd_start check after initrd address sanitisation Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 13/13] xen/blkfront: Only check REQ_FUA for writes Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531134541.3385043-5-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=osmtendev@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox