public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Helge Deller <deller@gmx.de>, Sasha Levin <sashal@kernel.org>,
	James.Bottomley@HansenPartnership.com, airlied@redhat.com,
	linux-parisc@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH AUTOSEL 4.19 09/13] parisc: Flush gatt writes and adjust gatt mask in parisc_agp_mask_memory()
Date: Wed, 31 May 2023 09:45:37 -0400	[thread overview]
Message-ID: <20230531134541.3385043-9-sashal@kernel.org> (raw)
In-Reply-To: <20230531134541.3385043-1-sashal@kernel.org>

From: Helge Deller <deller@gmx.de>

[ Upstream commit d703797380c540bbeac03f104ebcfc364eaf47cc ]

Flush caches after changing gatt entries and calculate entry according
to SBA requirements.

Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/char/agp/parisc-agp.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/drivers/char/agp/parisc-agp.c b/drivers/char/agp/parisc-agp.c
index 1d5510cb6db4e..f6d5a9b52cfe9 100644
--- a/drivers/char/agp/parisc-agp.c
+++ b/drivers/char/agp/parisc-agp.c
@@ -94,6 +94,9 @@ parisc_agp_tlbflush(struct agp_memory *mem)
 {
 	struct _parisc_agp_info *info = &parisc_agp_info;
 
+	/* force fdc ops to be visible to IOMMU */
+	asm_io_sync();
+
 	writeq(info->gart_base | ilog2(info->gart_size), info->ioc_regs+IOC_PCOM);
 	readq(info->ioc_regs+IOC_PCOM);	/* flush */
 }
@@ -162,6 +165,7 @@ parisc_agp_insert_memory(struct agp_memory *mem, off_t pg_start, int type)
 			info->gatt[j] =
 				parisc_agp_mask_memory(agp_bridge,
 					paddr, type);
+			asm_io_fdc(&info->gatt[j]);
 		}
 	}
 
@@ -195,7 +199,16 @@ static unsigned long
 parisc_agp_mask_memory(struct agp_bridge_data *bridge, dma_addr_t addr,
 		       int type)
 {
-	return SBA_PDIR_VALID_BIT | addr;
+	unsigned ci;			/* coherent index */
+	dma_addr_t pa;
+
+	pa = addr & IOVP_MASK;
+	asm("lci 0(%1), %0" : "=r" (ci) : "r" (phys_to_virt(pa)));
+
+	pa |= (ci >> PAGE_SHIFT) & 0xff;/* move CI (8 bits) into lowest byte */
+	pa |= SBA_PDIR_VALID_BIT;	/* set "valid" bit */
+
+	return cpu_to_le64(pa);
 }
 
 static void
-- 
2.39.2


  parent reply	other threads:[~2023-05-31 13:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31 13:45 [PATCH AUTOSEL 4.19 01/13] power: supply: ab8500: Fix external_power_changed race Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 02/13] power: supply: bq27xxx: Use mod_delayed_work() instead of cancel() + schedule() Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 03/13] ARM: dts: vexpress: add missing cache properties Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 04/13] power: supply: Ratelimit no data debug output Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 05/13] regulator: Fix error checking for debugfs_create_dir Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 06/13] irqchip/meson-gpio: Mark OF related data as maybe unused Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 07/13] power: supply: Fix logic checking if system is running from battery Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 08/13] parisc: Improve cache flushing for PCXL in arch_sync_dma_for_cpu() Sasha Levin
2023-05-31 13:45 ` Sasha Levin [this message]
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 10/13] MIPS: Restore Au1300 support Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 11/13] MIPS: Alchemy: fix dbdma2 Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 12/13] mips: Move initrd_start check after initrd address sanitisation Sasha Levin
2023-05-31 13:45 ` [PATCH AUTOSEL 4.19 13/13] xen/blkfront: Only check REQ_FUA for writes Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230531134541.3385043-9-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=airlied@redhat.com \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox