* [PATCHSET 0/2] Get rid of import_single_range()
@ 2023-12-04 17:43 Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2023-12-04 17:43 UTC (permalink / raw)
To: linux-kernel; +Cc: viro, brauner
Hi,
While looking at this today, I noticed that the 'iov' argument to this
function is totally dead code. Patch 1 gets rid of it, and with this
function and import_ubuf() now being identical, converts the callers
to just use import_ubuf().
No functional changes here, just a cleanup removing some dead code.
drivers/block/ublk_drv.c | 9 ++-------
drivers/char/random.c | 6 ++----
fs/aio.c | 2 +-
include/linux/uio.h | 2 --
kernel/trace/trace_events_user.c | 4 +---
lib/iov_iter.c | 13 -------------
net/ipv4/tcp.c | 10 ++++------
net/socket.c | 6 ++----
security/keys/keyctl.c | 5 ++---
9 files changed, 14 insertions(+), 43 deletions(-)
--
Jens Axboe
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCHSET 0/2] Get rid of import_single_range()
@ 2023-12-04 17:47 Jens Axboe
2023-12-05 10:57 ` Christian Brauner
0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2023-12-04 17:47 UTC (permalink / raw)
To: linux-kernel; +Cc: viro, brauner
Hi,
While looking at this today, I noticed that the 'iov' argument to this
function is totally dead code. Patch 1 gets rid of it, and with this
function and import_ubuf() now being identical, converts the callers
to just use import_ubuf().
No functional changes here, just a cleanup removing some dead code.
drivers/block/ublk_drv.c | 9 ++-------
drivers/char/random.c | 6 ++----
fs/aio.c | 2 +-
include/linux/uio.h | 2 --
kernel/trace/trace_events_user.c | 4 +---
lib/iov_iter.c | 13 -------------
net/ipv4/tcp.c | 10 ++++------
net/socket.c | 6 ++----
security/keys/keyctl.c | 5 ++---
9 files changed, 14 insertions(+), 43 deletions(-)
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHSET 0/2] Get rid of import_single_range()
2023-12-04 17:47 Jens Axboe
@ 2023-12-05 10:57 ` Christian Brauner
2023-12-05 13:46 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Christian Brauner @ 2023-12-05 10:57 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-kernel, viro
On Mon, Dec 04, 2023 at 10:47:48AM -0700, Jens Axboe wrote:
> Hi,
>
> While looking at this today, I noticed that the 'iov' argument to this
> function is totally dead code. Patch 1 gets rid of it, and with this
> function and import_ubuf() now being identical, converts the callers
> to just use import_ubuf().
>
> No functional changes here, just a cleanup removing some dead code.
Looks good. I've picked this up into vfs.iov_iter but let me know if
you're already carrying this.
Christian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHSET 0/2] Get rid of import_single_range()
2023-12-05 10:57 ` Christian Brauner
@ 2023-12-05 13:46 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2023-12-05 13:46 UTC (permalink / raw)
To: Christian Brauner; +Cc: linux-kernel, viro
On 12/5/23 3:57 AM, Christian Brauner wrote:
> On Mon, Dec 04, 2023 at 10:47:48AM -0700, Jens Axboe wrote:
>> Hi,
>>
>> While looking at this today, I noticed that the 'iov' argument to this
>> function is totally dead code. Patch 1 gets rid of it, and with this
>> function and import_ubuf() now being identical, converts the callers
>> to just use import_ubuf().
>>
>> No functional changes here, just a cleanup removing some dead code.
>
> Looks good. I've picked this up into vfs.iov_iter but let me know if
> you're already carrying this.
That's fine thanks, I don't have them stashed anywhere.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-05 13:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-04 17:43 [PATCHSET 0/2] Get rid of import_single_range() Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2023-12-04 17:47 Jens Axboe
2023-12-05 10:57 ` Christian Brauner
2023-12-05 13:46 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox