From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: Russell King <linux@armlinux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Grégory Clement" <gregory.clement@bootlin.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>
Subject: [PATCH v6 0/8] Cleanup AMBA PL011 driver
Date: Thu, 07 Dec 2023 18:56:05 +0100 [thread overview]
Message-ID: <20231207-mbly-uart-v6-0-e384afa5e78c@bootlin.com> (raw)
Hi,
While adding upstream support to a new platform (Mobileye EyeQ5[1]) that
uses the AMBA PL011 driver, I took some time to look at the PL011
driver and ended up with a few patches that cleanup parts of it. The
line-diff is big mostly because of the checkpatch-fixing commits.
The driver hadn't received any love for quite some time. See commit
messages for more information.
v6 drops [PATCH v5 1/9] as it has been applied by Greg KH. It also fixes
[PATCH v5 2/9] that broke on ARCH=arm ep93xx_defconfig because the header file
is included from assembly.
[1]: https://lore.kernel.org/all/202310050726.GDpZbMDO-lkp@intel.com/T/
Have a nice day,
Théo Lebrun
Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
---
Changes in v6:
- Address kernel test robot failure; amba/serial.h is included from assembly.
- Drop [PATCH v5 1/9] as it has been applied by Greg KH.
- Link to v5: https://lore.kernel.org/r/20231130-mbly-uart-v5-0-6566703a04b5@bootlin.com
Changes in v5:
- Rebase upon v6.7-rc1.
- Add #include <linux/bitfield.h> in include/linux/amba/serial.h.
- Split [PATCH v4 3/6] into 5 manageable commits.
- Link to v4: https://lore.kernel.org/r/20231123-mbly-uart-v4-0-7f913a74ff89@bootlin.com
Changes in v4:
- Fix reverse if logic bug in [PATCH V3 6/6].
- Link to v3: https://lore.kernel.org/r/20231120-mbly-uart-v3-0-07ae35979f1f@bootlin.com
Changes in v3:
- Replace magic constants in linux/amba/serial.h by FIELD_PREP_CONST calls
- Refactor QDF2400 SoC erratum 44 handling out of probe in a new patch
- A nit in "unindent pl011_console_get_options function body"
- Link to v2: https://lore.kernel.org/r/20231116-mbly-uart-v2-0-863f665ce520@bootlin.com
Changes in v2:
- [PATCH 2]: add #include <linux/bits.h> in include/linux/amba/serial.h
as we use the BIT() macro.
- Move one whitespace cleanup from [PATCH 4/6] to [PATCH v2 3/5] where
it belongs.
- Drop [PATCH 6/6]: console will never have a word length of 5 or 6.
- Link to v1: https://lore.kernel.org/r/20231026-mbly-uart-v1-0-9258eea297d3@bootlin.com
---
Théo Lebrun (8):
tty: serial: amba: Use linux/{bits,bitfield}.h macros
tty: serial: amba-pl011: fix whitespace formatting
tty: serial: amba-pl011: replace TIOCMBIT macros by static functions
tty: serial: amba-pl011: avoid quoted string split across lines
tty: serial: amba-pl011: fix formatting of conditions
tty: serial: amba-pl011: fix miscellaneous checkpatch warnings
tty: serial: amba-pl011: unindent pl011_console_get_options function body
tty: serial: amba-pl011: factor QDF2400 SoC erratum 44 out of probe
drivers/tty/serial/amba-pl011.c | 261 +++++++++++++++++++++-------------------
include/linux/amba/serial.h | 251 +++++++++++++++++++-------------------
2 files changed, 264 insertions(+), 248 deletions(-)
---
base-commit: bfc1fa3f077a32febb518c1df54e1ee922eee05d
change-id: 20231023-mbly-uart-afcacbb98f8b
Best regards,
--
Théo Lebrun <theo.lebrun@bootlin.com>
next reply other threads:[~2023-12-07 17:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 17:56 Théo Lebrun [this message]
2023-12-07 17:56 ` [PATCH v6 1/8] tty: serial: amba: Use linux/{bits,bitfield}.h macros Théo Lebrun
2023-12-07 17:56 ` [PATCH v6 2/8] tty: serial: amba-pl011: fix whitespace formatting Théo Lebrun
2023-12-07 17:56 ` [PATCH v6 3/8] tty: serial: amba-pl011: replace TIOCMBIT macros by static functions Théo Lebrun
2023-12-07 17:56 ` [PATCH v6 4/8] tty: serial: amba-pl011: avoid quoted string split across lines Théo Lebrun
2023-12-07 17:56 ` [PATCH v6 5/8] tty: serial: amba-pl011: fix formatting of conditions Théo Lebrun
2023-12-07 17:56 ` [PATCH v6 6/8] tty: serial: amba-pl011: fix miscellaneous checkpatch warnings Théo Lebrun
2023-12-07 17:56 ` [PATCH v6 7/8] tty: serial: amba-pl011: unindent pl011_console_get_options function body Théo Lebrun
2023-12-07 17:56 ` [PATCH v6 8/8] tty: serial: amba-pl011: factor QDF2400 SoC erratum 44 out of probe Théo Lebrun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207-mbly-uart-v6-0-e384afa5e78c@bootlin.com \
--to=theo.lebrun@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=tawfik.bayouk@mobileye.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox