From: Daniel Wagner <dwagner@suse.de>
To: James Smart <james.smart@broadcom.com>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Daniel Wagner <dwagner@suse.de>
Subject: [PATCH v4 12/12] nvmet-fc: use RCU list iterator for assoc_list
Date: Tue, 30 Jan 2024 10:49:38 +0100 [thread overview]
Message-ID: <20240130094938.1575-13-dwagner@suse.de> (raw)
In-Reply-To: <20240130094938.1575-1-dwagner@suse.de>
The assoc_list is a RCU protected list, thus use the RCU flavor of list
functions.
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
drivers/nvme/target/fc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index 671d096745a5..b8d3e30f2ddb 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -1151,7 +1151,9 @@ nvmet_fc_alloc_target_assoc(struct nvmet_fc_tgtport *tgtport, void *hosthandle)
spin_lock_irqsave(&tgtport->lock, flags);
needrandom = false;
- list_for_each_entry(tmpassoc, &tgtport->assoc_list, a_list) {
+ rcu_read_lock();
+ list_for_each_entry_rcu(tmpassoc, &tgtport->assoc_list, a_list) {
+
if (ran == tmpassoc->association_id) {
needrandom = true;
break;
@@ -1161,6 +1163,7 @@ nvmet_fc_alloc_target_assoc(struct nvmet_fc_tgtport *tgtport, void *hosthandle)
assoc->association_id = ran;
list_add_tail_rcu(&assoc->a_list, &tgtport->assoc_list);
}
+ rcu_read_unlock();
spin_unlock_irqrestore(&tgtport->lock, flags);
}
--
2.43.0
next prev parent reply other threads:[~2024-01-30 9:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 9:49 [PATCH v4 00/12] enable nvmet-fc for blktests Daniel Wagner
2024-01-30 9:49 ` [PATCH v4 01/12] nvme-fc: do not wait in vain when unloading module Daniel Wagner
2024-01-30 9:49 ` [PATCH v4 02/12] nvmet-fcloop: swap the list_add_tail arguments Daniel Wagner
2024-01-31 6:26 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 03/12] nvmet-fc: release reference on target port Daniel Wagner
2024-01-31 6:26 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 04/12] nvmet-fc: defer cleanup using RCU properly Daniel Wagner
2024-01-31 6:26 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 05/12] nvmet-fc: free queue and assoc directly Daniel Wagner
2024-01-31 6:27 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 06/12] nvmet-fc: hold reference on hostport match Daniel Wagner
2024-01-31 6:27 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 07/12] nvmet-fc: remove null hostport pointer check Daniel Wagner
2024-01-31 6:27 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 08/12] nvmet-fc: do not tack refs on tgtports from assoc Daniel Wagner
2024-01-31 6:28 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 09/12] nvmet-fc: abort command when there is no binding Daniel Wagner
2024-01-31 6:28 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 10/12] nvmet-fc: avoid deadlock on delete association path Daniel Wagner
2024-01-31 6:28 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 11/12] nvmet-fc: take ref count on tgtport before delete assoc Daniel Wagner
2024-01-31 6:28 ` Christoph Hellwig
2024-01-30 9:49 ` Daniel Wagner [this message]
2024-01-31 6:29 ` [PATCH v4 12/12] nvmet-fc: use RCU list iterator for assoc_list Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130094938.1575-13-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox