From: Daniel Wagner <dwagner@suse.de>
To: James Smart <james.smart@broadcom.com>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Daniel Wagner <dwagner@suse.de>
Subject: [PATCH v4 07/12] nvmet-fc: remove null hostport pointer check
Date: Tue, 30 Jan 2024 10:49:33 +0100 [thread overview]
Message-ID: <20240130094938.1575-8-dwagner@suse.de> (raw)
In-Reply-To: <20240130094938.1575-1-dwagner@suse.de>
An association has always a valid hostport pointer. Remove useless
null pointer check.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
drivers/nvme/target/fc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index 205a12b1e841..849d9b17c60a 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -488,8 +488,7 @@ nvmet_fc_xmt_disconnect_assoc(struct nvmet_fc_tgt_assoc *assoc)
* message is normal. Otherwise, send unless the hostport has
* already been invalidated by the lldd.
*/
- if (!tgtport->ops->ls_req || !assoc->hostport ||
- assoc->hostport->invalid)
+ if (!tgtport->ops->ls_req || assoc->hostport->invalid)
return;
lsop = kzalloc((sizeof(*lsop) +
@@ -1524,8 +1523,7 @@ nvmet_fc_invalidate_host(struct nvmet_fc_target_port *target_port,
spin_lock_irqsave(&tgtport->lock, flags);
list_for_each_entry_safe(assoc, next,
&tgtport->assoc_list, a_list) {
- if (!assoc->hostport ||
- assoc->hostport->hosthandle != hosthandle)
+ if (assoc->hostport->hosthandle != hosthandle)
continue;
if (!nvmet_fc_tgt_a_get(assoc))
continue;
--
2.43.0
next prev parent reply other threads:[~2024-01-30 9:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 9:49 [PATCH v4 00/12] enable nvmet-fc for blktests Daniel Wagner
2024-01-30 9:49 ` [PATCH v4 01/12] nvme-fc: do not wait in vain when unloading module Daniel Wagner
2024-01-30 9:49 ` [PATCH v4 02/12] nvmet-fcloop: swap the list_add_tail arguments Daniel Wagner
2024-01-31 6:26 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 03/12] nvmet-fc: release reference on target port Daniel Wagner
2024-01-31 6:26 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 04/12] nvmet-fc: defer cleanup using RCU properly Daniel Wagner
2024-01-31 6:26 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 05/12] nvmet-fc: free queue and assoc directly Daniel Wagner
2024-01-31 6:27 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 06/12] nvmet-fc: hold reference on hostport match Daniel Wagner
2024-01-31 6:27 ` Christoph Hellwig
2024-01-30 9:49 ` Daniel Wagner [this message]
2024-01-31 6:27 ` [PATCH v4 07/12] nvmet-fc: remove null hostport pointer check Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 08/12] nvmet-fc: do not tack refs on tgtports from assoc Daniel Wagner
2024-01-31 6:28 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 09/12] nvmet-fc: abort command when there is no binding Daniel Wagner
2024-01-31 6:28 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 10/12] nvmet-fc: avoid deadlock on delete association path Daniel Wagner
2024-01-31 6:28 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 11/12] nvmet-fc: take ref count on tgtport before delete assoc Daniel Wagner
2024-01-31 6:28 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 12/12] nvmet-fc: use RCU list iterator for assoc_list Daniel Wagner
2024-01-31 6:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130094938.1575-8-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox