From: Daniel Wagner <dwagner@suse.de>
To: James Smart <james.smart@broadcom.com>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Daniel Wagner <dwagner@suse.de>
Subject: [PATCH v4 02/12] nvmet-fcloop: swap the list_add_tail arguments
Date: Tue, 30 Jan 2024 10:49:28 +0100 [thread overview]
Message-ID: <20240130094938.1575-3-dwagner@suse.de> (raw)
In-Reply-To: <20240130094938.1575-1-dwagner@suse.de>
The first argument of list_add_tail function is the new element which
should be added to the list which is the second argument. Swap the
arguments to allow processing more than one element at a time.
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
drivers/nvme/target/fcloop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c
index c1faeb1e9e55..1471af250ea6 100644
--- a/drivers/nvme/target/fcloop.c
+++ b/drivers/nvme/target/fcloop.c
@@ -358,7 +358,7 @@ fcloop_h2t_ls_req(struct nvme_fc_local_port *localport,
if (!rport->targetport) {
tls_req->status = -ECONNREFUSED;
spin_lock(&rport->lock);
- list_add_tail(&rport->ls_list, &tls_req->ls_list);
+ list_add_tail(&tls_req->ls_list, &rport->ls_list);
spin_unlock(&rport->lock);
queue_work(nvmet_wq, &rport->ls_work);
return ret;
@@ -391,7 +391,7 @@ fcloop_h2t_xmt_ls_rsp(struct nvmet_fc_target_port *targetport,
if (remoteport) {
rport = remoteport->private;
spin_lock(&rport->lock);
- list_add_tail(&rport->ls_list, &tls_req->ls_list);
+ list_add_tail(&tls_req->ls_list, &rport->ls_list);
spin_unlock(&rport->lock);
queue_work(nvmet_wq, &rport->ls_work);
}
@@ -446,7 +446,7 @@ fcloop_t2h_ls_req(struct nvmet_fc_target_port *targetport, void *hosthandle,
if (!tport->remoteport) {
tls_req->status = -ECONNREFUSED;
spin_lock(&tport->lock);
- list_add_tail(&tport->ls_list, &tls_req->ls_list);
+ list_add_tail(&tls_req->ls_list, &tport->ls_list);
spin_unlock(&tport->lock);
queue_work(nvmet_wq, &tport->ls_work);
return ret;
--
2.43.0
next prev parent reply other threads:[~2024-01-30 9:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 9:49 [PATCH v4 00/12] enable nvmet-fc for blktests Daniel Wagner
2024-01-30 9:49 ` [PATCH v4 01/12] nvme-fc: do not wait in vain when unloading module Daniel Wagner
2024-01-30 9:49 ` Daniel Wagner [this message]
2024-01-31 6:26 ` [PATCH v4 02/12] nvmet-fcloop: swap the list_add_tail arguments Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 03/12] nvmet-fc: release reference on target port Daniel Wagner
2024-01-31 6:26 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 04/12] nvmet-fc: defer cleanup using RCU properly Daniel Wagner
2024-01-31 6:26 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 05/12] nvmet-fc: free queue and assoc directly Daniel Wagner
2024-01-31 6:27 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 06/12] nvmet-fc: hold reference on hostport match Daniel Wagner
2024-01-31 6:27 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 07/12] nvmet-fc: remove null hostport pointer check Daniel Wagner
2024-01-31 6:27 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 08/12] nvmet-fc: do not tack refs on tgtports from assoc Daniel Wagner
2024-01-31 6:28 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 09/12] nvmet-fc: abort command when there is no binding Daniel Wagner
2024-01-31 6:28 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 10/12] nvmet-fc: avoid deadlock on delete association path Daniel Wagner
2024-01-31 6:28 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 11/12] nvmet-fc: take ref count on tgtport before delete assoc Daniel Wagner
2024-01-31 6:28 ` Christoph Hellwig
2024-01-30 9:49 ` [PATCH v4 12/12] nvmet-fc: use RCU list iterator for assoc_list Daniel Wagner
2024-01-31 6:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130094938.1575-3-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox