* [PATCH] samples: mei: remove unused parameter
@ 2024-01-19 4:00 alexs
2024-02-01 11:58 ` kuiliang Shi
0 siblings, 1 reply; 3+ messages in thread
From: alexs @ 2024-01-19 4:00 UTC (permalink / raw)
To: Tomas Winkler, linux-kernel; +Cc: Alex Shi
From: Alex Shi <alexs@kernel.org>
The timeout parameter isn't used in func mei_send_msg(), better to
remove it.
Signed-off-by: Alex Shi <alexs@kernel.org>
To: linux-kernel@vger.kernel.org
To: Tomas Winkler <tomas.winkler@intel.com>
---
samples/mei/mei-amt-version.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/samples/mei/mei-amt-version.c b/samples/mei/mei-amt-version.c
index 867debd3b912..bf14d8a819b9 100644
--- a/samples/mei/mei-amt-version.c
+++ b/samples/mei/mei-amt-version.c
@@ -195,8 +195,7 @@ static ssize_t mei_recv_msg(struct mei *me, unsigned char *buffer,
return rc;
}
-static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer,
- ssize_t len, unsigned long timeout)
+static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer, ssize_t len)
{
ssize_t written;
ssize_t rc;
@@ -391,8 +390,7 @@ static uint32_t amt_host_if_call(struct amt_host_if *acmd,
memset(*read_buf, 0, in_buf_sz);
msg_hdr = (struct amt_host_if_resp_header *)*read_buf;
- written = mei_send_msg(&acmd->mei_cl,
- command, command_sz, acmd->send_timeout);
+ written = mei_send_msg(&acmd->mei_cl, command, command_sz);
if (written != command_sz)
return AMT_STATUS_INTERNAL_ERROR;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] samples: mei: remove unused parameter
2024-01-19 4:00 alexs
@ 2024-02-01 11:58 ` kuiliang Shi
0 siblings, 0 replies; 3+ messages in thread
From: kuiliang Shi @ 2024-02-01 11:58 UTC (permalink / raw)
To: alexs, Tomas Winkler, linux-kernel
ping
On 1/19/24 12:00 PM, alexs@kernel.org wrote:
> From: Alex Shi <alexs@kernel.org>
>
> The timeout parameter isn't used in func mei_send_msg(), better to
> remove it.
>
> Signed-off-by: Alex Shi <alexs@kernel.org>
> To: linux-kernel@vger.kernel.org
> To: Tomas Winkler <tomas.winkler@intel.com>
> ---
> samples/mei/mei-amt-version.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/samples/mei/mei-amt-version.c b/samples/mei/mei-amt-version.c
> index 867debd3b912..bf14d8a819b9 100644
> --- a/samples/mei/mei-amt-version.c
> +++ b/samples/mei/mei-amt-version.c
> @@ -195,8 +195,7 @@ static ssize_t mei_recv_msg(struct mei *me, unsigned char *buffer,
> return rc;
> }
>
> -static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer,
> - ssize_t len, unsigned long timeout)
> +static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer, ssize_t len)
> {
> ssize_t written;
> ssize_t rc;
> @@ -391,8 +390,7 @@ static uint32_t amt_host_if_call(struct amt_host_if *acmd,
> memset(*read_buf, 0, in_buf_sz);
> msg_hdr = (struct amt_host_if_resp_header *)*read_buf;
>
> - written = mei_send_msg(&acmd->mei_cl,
> - command, command_sz, acmd->send_timeout);
> + written = mei_send_msg(&acmd->mei_cl, command, command_sz);
> if (written != command_sz)
> return AMT_STATUS_INTERNAL_ERROR;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] samples: mei: remove unused parameter
@ 2024-03-27 4:02 alexs
0 siblings, 0 replies; 3+ messages in thread
From: alexs @ 2024-03-27 4:02 UTC (permalink / raw)
To: Tomas Winkler, open list:INTEL MANAGEMENT ENGINE (mei)
Cc: linux-kernel, Alex Shi
From: Alex Shi <alexs@kernel.org>
The timeout parameter isn't used in func mei_send_msg(), better to
remove it.
Signed-off-by: Alex Shi <alexs@kernel.org>
Cc: Tomas Winkler <tomas.winkler@intel.com>
---
samples/mei/mei-amt-version.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/samples/mei/mei-amt-version.c b/samples/mei/mei-amt-version.c
index 867debd3b912..bf14d8a819b9 100644
--- a/samples/mei/mei-amt-version.c
+++ b/samples/mei/mei-amt-version.c
@@ -195,8 +195,7 @@ static ssize_t mei_recv_msg(struct mei *me, unsigned char *buffer,
return rc;
}
-static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer,
- ssize_t len, unsigned long timeout)
+static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer, ssize_t len)
{
ssize_t written;
ssize_t rc;
@@ -391,8 +390,7 @@ static uint32_t amt_host_if_call(struct amt_host_if *acmd,
memset(*read_buf, 0, in_buf_sz);
msg_hdr = (struct amt_host_if_resp_header *)*read_buf;
- written = mei_send_msg(&acmd->mei_cl,
- command, command_sz, acmd->send_timeout);
+ written = mei_send_msg(&acmd->mei_cl, command, command_sz);
if (written != command_sz)
return AMT_STATUS_INTERNAL_ERROR;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-27 3:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-27 4:02 [PATCH] samples: mei: remove unused parameter alexs
-- strict thread matches above, loose matches on Subject: below --
2024-01-19 4:00 alexs
2024-02-01 11:58 ` kuiliang Shi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox