* [PATCH] iio: dac: ad9739a: drop COMPILE_TEST option
@ 2024-05-28 12:12 Arnd Bergmann
2024-05-29 7:20 ` Nuno Sá
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2024-05-28 12:12 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Arnd Bergmann, Lars-Peter Clausen, Nuno Sa, Dragos Bogdan,
Anshul Dalal, Andrea Collamati, linux-iio, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Build testing without SPI results in a warning:
WARNING: unmet direct dependencies detected for REGMAP_SPI
Depends on [n]: SPI [=n]
Selected by [m]:
- AD9739A [=m] && IIO [=m] && (SPI [=n] || COMPILE_TEST [=y])
There is no need for this particular COMPILE_TEST option, as allmodconfig
and randconfig testing can just assume that SPI is enabled separately.
Drop it to avoid the warning.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/iio/dac/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
index 3c2bf620f00f..ee0d9798d8b4 100644
--- a/drivers/iio/dac/Kconfig
+++ b/drivers/iio/dac/Kconfig
@@ -133,7 +133,7 @@ config AD5624R_SPI
config AD9739A
tristate "Analog Devices AD9739A RF DAC spi driver"
- depends on SPI || COMPILE_TEST
+ depends on SPI
select REGMAP_SPI
select IIO_BACKEND
help
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: dac: ad9739a: drop COMPILE_TEST option
2024-05-28 12:12 [PATCH] iio: dac: ad9739a: drop COMPILE_TEST option Arnd Bergmann
@ 2024-05-29 7:20 ` Nuno Sá
2024-05-29 7:23 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Nuno Sá @ 2024-05-29 7:20 UTC (permalink / raw)
To: Arnd Bergmann, Jonathan Cameron
Cc: Arnd Bergmann, Lars-Peter Clausen, Nuno Sa, Dragos Bogdan,
Anshul Dalal, Andrea Collamati, linux-iio, linux-kernel
On Tue, 2024-05-28 at 14:12 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Build testing without SPI results in a warning:
>
> WARNING: unmet direct dependencies detected for REGMAP_SPI
> Depends on [n]: SPI [=n]
> Selected by [m]:
> - AD9739A [=m] && IIO [=m] && (SPI [=n] || COMPILE_TEST [=y])
>
> There is no need for this particular COMPILE_TEST option, as allmodconfig
> and randconfig testing can just assume that SPI is enabled separately.
>
> Drop it to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Only for my understanding. When does COMPILE_TEST makes sense to add?
- Nuno Sá
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: dac: ad9739a: drop COMPILE_TEST option
2024-05-29 7:20 ` Nuno Sá
@ 2024-05-29 7:23 ` Arnd Bergmann
2024-05-29 8:09 ` Nuno Sá
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2024-05-29 7:23 UTC (permalink / raw)
To: Nuno Sá, Arnd Bergmann, Jonathan Cameron
Cc: Lars-Peter Clausen, Nuno Sá, Dragos Bogdan, Anshul Dalal,
Andrea Collamati, linux-iio, linux-kernel
On Wed, May 29, 2024, at 09:20, Nuno Sá wrote:
> On Tue, 2024-05-28 at 14:12 +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Build testing without SPI results in a warning:
>>
>> WARNING: unmet direct dependencies detected for REGMAP_SPI
>> Depends on [n]: SPI [=n]
>> Selected by [m]:
>> - AD9739A [=m] && IIO [=m] && (SPI [=n] || COMPILE_TEST [=y])
>>
>> There is no need for this particular COMPILE_TEST option, as allmodconfig
>> and randconfig testing can just assume that SPI is enabled separately.
>>
>> Drop it to avoid the warning.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
>
> Only for my understanding. When does COMPILE_TEST makes sense to add?
The most common use is to enable building a driver
that is platform specific on x86 allmodconfig
or on randconfig, e.g.
config LPC18XX_DAC
tristate "NXP LPC18xx DAC driver"
depends on ARCH_LPC18XX || COMPILE_TEST
depends on HAS_IOMEM
Since ARCH_LPC18XX is only visible on arch/arm, the
driver would never be build tested on anything else
without the ||COMPILE_TEST.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] iio: dac: ad9739a: drop COMPILE_TEST option
2024-05-29 7:23 ` Arnd Bergmann
@ 2024-05-29 8:09 ` Nuno Sá
2024-06-02 12:14 ` Jonathan Cameron
0 siblings, 1 reply; 5+ messages in thread
From: Nuno Sá @ 2024-05-29 8:09 UTC (permalink / raw)
To: Arnd Bergmann, Arnd Bergmann, Jonathan Cameron
Cc: Lars-Peter Clausen, Nuno Sá, Dragos Bogdan, Anshul Dalal,
Andrea Collamati, linux-iio, linux-kernel
On Wed, 2024-05-29 at 09:23 +0200, Arnd Bergmann wrote:
> On Wed, May 29, 2024, at 09:20, Nuno Sá wrote:
> > On Tue, 2024-05-28 at 14:12 +0200, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > Build testing without SPI results in a warning:
> > >
> > > WARNING: unmet direct dependencies detected for REGMAP_SPI
> > > Depends on [n]: SPI [=n]
> > > Selected by [m]:
> > > - AD9739A [=m] && IIO [=m] && (SPI [=n] || COMPILE_TEST [=y])
> > >
> > > There is no need for this particular COMPILE_TEST option, as allmodconfig
> > > and randconfig testing can just assume that SPI is enabled separately.
> > >
> > > Drop it to avoid the warning.
> > >
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> >
> > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> >
> > Only for my understanding. When does COMPILE_TEST makes sense to add?
>
> The most common use is to enable building a driver
> that is platform specific on x86 allmodconfig
> or on randconfig, e.g.
>
> config LPC18XX_DAC
> tristate "NXP LPC18xx DAC driver"
> depends on ARCH_LPC18XX || COMPILE_TEST
> depends on HAS_IOMEM
>
> Since ARCH_LPC18XX is only visible on arch/arm, the
> driver would never be build tested on anything else
> without the ||COMPILE_TEST.
Makes sense... Thanks!
- Nuno Sá
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: dac: ad9739a: drop COMPILE_TEST option
2024-05-29 8:09 ` Nuno Sá
@ 2024-06-02 12:14 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2024-06-02 12:14 UTC (permalink / raw)
To: Nuno Sá
Cc: Arnd Bergmann, Arnd Bergmann, Lars-Peter Clausen, Nuno Sá,
Dragos Bogdan, Anshul Dalal, Andrea Collamati, linux-iio,
linux-kernel
On Wed, 29 May 2024 10:09:28 +0200
Nuno Sá <noname.nuno@gmail.com> wrote:
> On Wed, 2024-05-29 at 09:23 +0200, Arnd Bergmann wrote:
> > On Wed, May 29, 2024, at 09:20, Nuno Sá wrote:
> > > On Tue, 2024-05-28 at 14:12 +0200, Arnd Bergmann wrote:
> > > > From: Arnd Bergmann <arnd@arndb.de>
> > > >
> > > > Build testing without SPI results in a warning:
> > > >
> > > > WARNING: unmet direct dependencies detected for REGMAP_SPI
> > > > Depends on [n]: SPI [=n]
> > > > Selected by [m]:
> > > > - AD9739A [=m] && IIO [=m] && (SPI [=n] || COMPILE_TEST [=y])
> > > >
> > > > There is no need for this particular COMPILE_TEST option, as allmodconfig
> > > > and randconfig testing can just assume that SPI is enabled separately.
> > > >
> > > > Drop it to avoid the warning.
> > > >
> > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > > ---
> > >
> > > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> > >
> > > Only for my understanding. When does COMPILE_TEST makes sense to add?
> >
> > The most common use is to enable building a driver
> > that is platform specific on x86 allmodconfig
> > or on randconfig, e.g.
> >
> > config LPC18XX_DAC
> > tristate "NXP LPC18xx DAC driver"
> > depends on ARCH_LPC18XX || COMPILE_TEST
> > depends on HAS_IOMEM
> >
> > Since ARCH_LPC18XX is only visible on arch/arm, the
> > driver would never be build tested on anything else
> > without the ||COMPILE_TEST.
>
> Makes sense... Thanks!
>
> - Nuno Sá
>
Applied. Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-06-02 12:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-28 12:12 [PATCH] iio: dac: ad9739a: drop COMPILE_TEST option Arnd Bergmann
2024-05-29 7:20 ` Nuno Sá
2024-05-29 7:23 ` Arnd Bergmann
2024-05-29 8:09 ` Nuno Sá
2024-06-02 12:14 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox