From: "Xin Li (Intel)" <xin@zytor.com>
To: linux-kernel@vger.kernel.org
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
peterz@infradead.org, andrew.cooper3@citrix.com,
nik.borisov@suse.com, houwenlong.hwl@antgroup.com
Subject: [PATCH v1 0/4] Enable FRED earlier
Date: Wed, 3 Jul 2024 01:54:22 -0700 [thread overview]
Message-ID: <20240703085426.274801-1-xin@zytor.com> (raw)
Wenlong Hou from Ant group reported two problems during the FRED
initialization:
https://lore.kernel.org/lkml/cover.1718972598.git.houwenlong.hwl@antgroup.com/
The first problem is that spurious_interrupt() gets called on the
HYPERVISOR_CALLBACK_VECTOR vector. Because kvm_guest_init(), being
executed way before trap_init() in which it is decided that whether
FRED will be enabled or not, calls sysvec_install() to install
HYPERVISOR_CALLBACK_VECTOR's interrupt handler into FRED system
vector dispatch table or IDT depending on whether FRED is enabled.
The other problem is that the #PF handler gets a wrong faulting
address from the stack instead of CR2 before FRED is enabled.
Because the #PF handler fetches its faulting addresss from the
stack or CR2 based on whether FRED is available rather than active.
This patchset fixes the 2 problems with suggestions from tglx:
1) Parse cmdline param "fred=" in cpu_parse_early_param() to
minimize the gap mentioned above, before kvm_guest_init().
2) Enable FRED right after init_mem_mapping() to switch to FRED
from early IDT ASAP, avoid intermediately using the IDT #PF
handler.
Xin Li (Intel) (4):
x86/fred: Parse cmdline param "fred=" in cpu_parse_early_param()
x86/fred: Write to FRED MSRs with wrmsrns()
x86/fred: Split FRED RSP initialization into a separate function
x86/fred: Enable FRED right after init_mem_mapping()
arch/x86/include/asm/fred.h | 2 ++
arch/x86/kernel/cpu/common.c | 9 ++++---
arch/x86/kernel/fred.c | 50 +++++++++++++++++++++---------------
arch/x86/kernel/setup.c | 7 ++++-
arch/x86/kernel/smpboot.c | 6 +++++
arch/x86/kernel/traps.c | 30 +++-------------------
6 files changed, 54 insertions(+), 50 deletions(-)
base-commit: e70c87e103e2e3842bf4c55a66c83560a1387925
--
2.45.2
next reply other threads:[~2024-07-03 8:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 8:54 Xin Li (Intel) [this message]
2024-07-03 8:54 ` [PATCH v1 1/4] x86/fred: Parse cmdline param "fred=" in cpu_parse_early_param() Xin Li (Intel)
2024-07-04 11:20 ` Nikolay Borisov
2024-07-07 17:42 ` Xin Li
2024-07-03 8:54 ` [PATCH v1 2/4] x86/fred: Write to FRED MSRs with wrmsrns() Xin Li (Intel)
2024-07-03 15:43 ` Dave Hansen
2024-07-03 15:54 ` Borislav Petkov
2024-07-03 16:00 ` Andrew Cooper
2024-07-03 16:06 ` H. Peter Anvin
2024-07-03 16:17 ` Borislav Petkov
2024-07-05 2:45 ` H. Peter Anvin
2024-07-05 9:44 ` Borislav Petkov
2024-07-05 10:30 ` Andrew Cooper
2024-07-05 13:45 ` Borislav Petkov
2024-07-09 13:58 ` Xin Li
2024-07-09 20:51 ` H. Peter Anvin
2024-07-03 16:18 ` Andrew Cooper
2024-07-04 5:57 ` Xin Li
2024-07-04 7:58 ` H. Peter Anvin
2024-07-04 8:23 ` Borislav Petkov
2024-07-04 8:28 ` H. Peter Anvin
2024-07-03 16:43 ` Dave Hansen
2024-07-03 22:48 ` Xin Li
2024-07-05 9:28 ` Peter Zijlstra
2024-07-05 11:33 ` H. Peter Anvin
2024-07-03 8:54 ` [PATCH v1 3/4] x86/fred: Split FRED RSP initialization into a separate function Xin Li (Intel)
2024-07-03 8:54 ` [PATCH v1 4/4] x86/fred: Enable FRED right after init_mem_mapping() Xin Li (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703085426.274801-1-xin@zytor.com \
--to=xin@zytor.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=houwenlong.hwl@antgroup.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox