From: "Xin Li (Intel)" <xin@zytor.com>
To: linux-kernel@vger.kernel.org
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
peterz@infradead.org, andrew.cooper3@citrix.com,
nik.borisov@suse.com, houwenlong.hwl@antgroup.com
Subject: [PATCH v1 4/4] x86/fred: Enable FRED right after init_mem_mapping()
Date: Wed, 3 Jul 2024 01:54:26 -0700 [thread overview]
Message-ID: <20240703085426.274801-5-xin@zytor.com> (raw)
In-Reply-To: <20240703085426.274801-1-xin@zytor.com>
Enable FRED right after init_mem_mapping() to avoid #PF handler,
exc_page_fault(), fetching its faulting address from the stack
before FRED is enabled.
Fixes: 14619d912b65 ("x86/fred: FRED entry/exit and dispatch code")
Reported-by: Hou Wenlong <houwenlong.hwl@antgroup.com>
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Xin Li (Intel) <xin@zytor.com>
---
arch/x86/kernel/cpu/common.c | 6 +-----
arch/x86/kernel/setup.c | 7 ++++++-
arch/x86/kernel/smpboot.c | 6 ++++++
arch/x86/kernel/traps.c | 4 ++++
4 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 022ae4ba7997..8d454b6f7def 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -2195,12 +2195,8 @@ void cpu_init_exception_handling(void)
/* GHCB needs to be setup to handle #VC. */
setup_ghcb();
- if (cpu_feature_enabled(X86_FEATURE_FRED)) {
- cpu_init_fred_exceptions();
- cpu_init_fred_rsps();
- } else {
+ if (!cpu_feature_enabled(X86_FEATURE_FRED))
load_current_idt();
- }
}
/*
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 728927e4ba51..d866136a89ff 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -39,6 +39,7 @@
#include <asm/coco.h>
#include <asm/cpu.h>
#include <asm/efi.h>
+#include <asm/fred.h>
#include <asm/gart.h>
#include <asm/hypervisor.h>
#include <asm/io_apic.h>
@@ -1040,7 +1041,11 @@ void __init setup_arch(char **cmdline_p)
init_mem_mapping();
- idt_setup_early_pf();
+ /* Switch to FRED from early IDT ASAP */
+ if (cpu_feature_enabled(X86_FEATURE_FRED))
+ cpu_init_fred_exceptions();
+ else
+ idt_setup_early_pf();
/*
* Update mmu_cr4_features (and, indirectly, trampoline_cr4_features)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 0c35207320cb..0d83377f9dcd 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -64,6 +64,7 @@
#include <asm/acpi.h>
#include <asm/cacheinfo.h>
#include <asm/desc.h>
+#include <asm/fred.h>
#include <asm/nmi.h>
#include <asm/irq.h>
#include <asm/realmode.h>
@@ -248,6 +249,11 @@ static void notrace start_secondary(void *unused)
cpu_init_exception_handling();
+ if (cpu_feature_enabled(X86_FEATURE_FRED)) {
+ cpu_init_fred_exceptions();
+ cpu_init_fred_rsps();
+ }
+
/*
* Load the microcode before reaching the AP alive synchronization
* point below so it is not part of the full per CPU serialized
diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index 6afb41e6cbbb..81648bd07576 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -1407,6 +1407,10 @@ void __init trap_init(void)
/* Init cpu_entry_area before IST entries are set up */
setup_cpu_entry_areas();
+ /* FRED RSPs pointing to memory from CPU entry areas */
+ if (cpu_feature_enabled(X86_FEATURE_FRED))
+ cpu_init_fred_rsps();
+
/* Init GHCB memory pages when running as an SEV-ES guest */
sev_es_init_vc_handling();
--
2.45.2
prev parent reply other threads:[~2024-07-03 8:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 8:54 [PATCH v1 0/4] Enable FRED earlier Xin Li (Intel)
2024-07-03 8:54 ` [PATCH v1 1/4] x86/fred: Parse cmdline param "fred=" in cpu_parse_early_param() Xin Li (Intel)
2024-07-04 11:20 ` Nikolay Borisov
2024-07-07 17:42 ` Xin Li
2024-07-03 8:54 ` [PATCH v1 2/4] x86/fred: Write to FRED MSRs with wrmsrns() Xin Li (Intel)
2024-07-03 15:43 ` Dave Hansen
2024-07-03 15:54 ` Borislav Petkov
2024-07-03 16:00 ` Andrew Cooper
2024-07-03 16:06 ` H. Peter Anvin
2024-07-03 16:17 ` Borislav Petkov
2024-07-05 2:45 ` H. Peter Anvin
2024-07-05 9:44 ` Borislav Petkov
2024-07-05 10:30 ` Andrew Cooper
2024-07-05 13:45 ` Borislav Petkov
2024-07-09 13:58 ` Xin Li
2024-07-09 20:51 ` H. Peter Anvin
2024-07-03 16:18 ` Andrew Cooper
2024-07-04 5:57 ` Xin Li
2024-07-04 7:58 ` H. Peter Anvin
2024-07-04 8:23 ` Borislav Petkov
2024-07-04 8:28 ` H. Peter Anvin
2024-07-03 16:43 ` Dave Hansen
2024-07-03 22:48 ` Xin Li
2024-07-05 9:28 ` Peter Zijlstra
2024-07-05 11:33 ` H. Peter Anvin
2024-07-03 8:54 ` [PATCH v1 3/4] x86/fred: Split FRED RSP initialization into a separate function Xin Li (Intel)
2024-07-03 8:54 ` Xin Li (Intel) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703085426.274801-5-xin@zytor.com \
--to=xin@zytor.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=houwenlong.hwl@antgroup.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox