From: Dave Hansen <dave.hansen@intel.com>
To: "Xin Li (Intel)" <xin@zytor.com>, linux-kernel@vger.kernel.org
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
peterz@infradead.org, andrew.cooper3@citrix.com,
nik.borisov@suse.com, houwenlong.hwl@antgroup.com
Subject: Re: [PATCH v1 2/4] x86/fred: Write to FRED MSRs with wrmsrns()
Date: Wed, 3 Jul 2024 08:43:46 -0700 [thread overview]
Message-ID: <9063b0fe-e8f3-44ff-b323-b2b6c338690f@intel.com> (raw)
In-Reply-To: <20240703085426.274801-3-xin@zytor.com>
On 7/3/24 01:54, Xin Li (Intel) wrote:
> Do FRED MSR writes with wrmsrns() rather than wrmsrl().
A longer changelog would be appreciated here. The wrmsrns() is
presumably to avoid the WRMSR serialization overhead and the CR4 write
provides all of the serialization that we need.
I'm also not clear how this fits into the series other than being FRED
related.
> No functional change intended.
I think I know what this was trying to convey, but I'm not sure this
phrase is appropriate to use here. Sure, WRMSR and WRMSRNS have the
same general purpose, but I'd never say they are functionally equivalent.
next prev parent reply other threads:[~2024-07-03 15:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 8:54 [PATCH v1 0/4] Enable FRED earlier Xin Li (Intel)
2024-07-03 8:54 ` [PATCH v1 1/4] x86/fred: Parse cmdline param "fred=" in cpu_parse_early_param() Xin Li (Intel)
2024-07-04 11:20 ` Nikolay Borisov
2024-07-07 17:42 ` Xin Li
2024-07-03 8:54 ` [PATCH v1 2/4] x86/fred: Write to FRED MSRs with wrmsrns() Xin Li (Intel)
2024-07-03 15:43 ` Dave Hansen [this message]
2024-07-03 15:54 ` Borislav Petkov
2024-07-03 16:00 ` Andrew Cooper
2024-07-03 16:06 ` H. Peter Anvin
2024-07-03 16:17 ` Borislav Petkov
2024-07-05 2:45 ` H. Peter Anvin
2024-07-05 9:44 ` Borislav Petkov
2024-07-05 10:30 ` Andrew Cooper
2024-07-05 13:45 ` Borislav Petkov
2024-07-09 13:58 ` Xin Li
2024-07-09 20:51 ` H. Peter Anvin
2024-07-03 16:18 ` Andrew Cooper
2024-07-04 5:57 ` Xin Li
2024-07-04 7:58 ` H. Peter Anvin
2024-07-04 8:23 ` Borislav Petkov
2024-07-04 8:28 ` H. Peter Anvin
2024-07-03 16:43 ` Dave Hansen
2024-07-03 22:48 ` Xin Li
2024-07-05 9:28 ` Peter Zijlstra
2024-07-05 11:33 ` H. Peter Anvin
2024-07-03 8:54 ` [PATCH v1 3/4] x86/fred: Split FRED RSP initialization into a separate function Xin Li (Intel)
2024-07-03 8:54 ` [PATCH v1 4/4] x86/fred: Enable FRED right after init_mem_mapping() Xin Li (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9063b0fe-e8f3-44ff-b323-b2b6c338690f@intel.com \
--to=dave.hansen@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=houwenlong.hwl@antgroup.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox