From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH] tracing: remove tracing_is_on export
Date: Thu, 25 Jul 2024 14:52:24 +0200 [thread overview]
Message-ID: <2024072506-aghast-appointee-7f83@gregkh> (raw)
In-Reply-To: <20240725083102.38950c1c@gandalf.local.home>
On Thu, Jul 25, 2024 at 08:31:02AM -0400, Steven Rostedt wrote:
> On Thu, 25 Jul 2024 11:36:08 +0200
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> > The function tracing_is_on() is only called by in-kernel code, not by
> > any modules, so no need to export it as a symbol at all.
>
> Hmm, this is part of the debugging code along with:
>
> tracing_on(); tracing_off();
>
> I had it exported in case a module needed to use it in debugging.
What module? There is no in-kernel user of it as a module that I could
find, what am I missing?
thanks,
greg k-h
next prev parent reply other threads:[~2024-07-25 12:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 9:36 [PATCH] tracing: remove tracing_is_on export Greg Kroah-Hartman
2024-07-25 12:31 ` Steven Rostedt
2024-07-25 12:52 ` Greg Kroah-Hartman [this message]
2024-07-25 13:26 ` Steven Rostedt
2024-07-25 13:35 ` Greg Kroah-Hartman
2024-07-25 13:53 ` Steven Rostedt
2024-07-25 14:41 ` Greg Kroah-Hartman
2024-07-25 16:17 ` Steven Rostedt
2024-07-26 8:15 ` Greg Kroah-Hartman
2024-07-26 14:22 ` Steven Rostedt
2024-07-25 14:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024072506-aghast-appointee-7f83@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).