From: Steven Rostedt <rostedt@goodmis.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH] tracing: remove tracing_is_on export
Date: Fri, 26 Jul 2024 10:22:08 -0400 [thread overview]
Message-ID: <20240726102208.41996fbf@rorschach.local.home> (raw)
In-Reply-To: <2024072611-unrelated-aflame-bf41@gregkh>
On Fri, 26 Jul 2024 10:15:14 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > This has been exported since 2008. Has it ever been a problem in the last
> > 16 years?
>
> As I am finding out, yes, external modules are "abusing" this to do
> different types of logic depending on if tracing is enabled or not for
> various unknown reasons. As there was no in-kernel user of this symbol,
> I assumed it was just an oversight and should be removed.
>
> I'll go ask the distro involved to just remove the symbol from their
> kernels instead, but that feels like the wrong thing to do to me.
Interesting as I was unaware of this. I'm not against removing the
"is_on" from being exported, as that really was only there to be
consistent with the others.
-- Steve
next prev parent reply other threads:[~2024-07-26 14:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 9:36 [PATCH] tracing: remove tracing_is_on export Greg Kroah-Hartman
2024-07-25 12:31 ` Steven Rostedt
2024-07-25 12:52 ` Greg Kroah-Hartman
2024-07-25 13:26 ` Steven Rostedt
2024-07-25 13:35 ` Greg Kroah-Hartman
2024-07-25 13:53 ` Steven Rostedt
2024-07-25 14:41 ` Greg Kroah-Hartman
2024-07-25 16:17 ` Steven Rostedt
2024-07-26 8:15 ` Greg Kroah-Hartman
2024-07-26 14:22 ` Steven Rostedt [this message]
2024-07-25 14:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240726102208.41996fbf@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox