* [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn
@ 2024-12-09 12:09 Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 01/14] ASoC: dt-bindings: Add bindings for WCD934x DAIs Dzmitry Sankouski
` (14 more replies)
0 siblings, 15 replies; 21+ messages in thread
From: Dzmitry Sankouski @ 2024-12-09 12:09 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Dzmitry Sankouski, Konrad Dybcio, Konrad Dybcio
Contains starqltechn device tree changes.
Add support for new features:
- sound (headphones and mics only)
- gpu
- panel
- buttons
- MAX77705 MFD:
- charger
- fuelgauge
- haptic
- led
Binding Dependencies:
- s2dos05: https://lore.kernel.org/r/20241007-starqltechn_integration_upstream-v6-0-264309aa66de@gmail.com
- This series was applied to krzk/linux.git (for-next)
- max77705: https://lore.kernel.org/r/20241209-starqltechn_integration_upstream-v11-4-dc0598828e01@gmail.com
- s6e3ha8 panel: https://lore.kernel.org/r/20241006-starqltechn_integration_upstream-v6-0-8336b9cd6c34@gmail.com
- applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)
Runtime Dependencies:
- gcc845 gp clock: https://lore.kernel.org/r/20241007-starqltechn_integration_upstream-v6-0-dd75c06c708d@gmail.com
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes in v8:
- add reviewed tags
- minor fixes
- remove 'reg' property in fuel-gauge to comply with v11 max77705 mfd
- Link to v7: https://lore.kernel.org/r/20241205-starqltechn_integration_upstream-v7-0-84f9a3547803@gmail.com
Changes in v7:
- review fixes.
- new patch with dt-binding header for wcd934x
- Link to v6: https://lore.kernel.org/r/20241008-starqltechn_integration_upstream-v6-0-5445365d3052@gmail.com
Changes in v6:
- refactor: no space between tags in commit message
- rename starqltechn to sdm845-starqltechn in commit summaries
- Link to v5: https://lore.kernel.org/r/20240926-starqltechn_integration_upstream-v5-0-d2084672ff2f@gmail.com
Changes in v5:
- Split patchset per subsystem
- Add links to subsystem patchsets in description
- Link to v4: https://lore.kernel.org/r/20240913-starqltechn_integration_upstream-v4-0-2d2efd5c5877@gmail.com
Changes in v4:
- Rewrite max77705, max77705_charger, max77705_fuel_gauge from scratch
- Reorder patches:
- squash max77705 subdevice bindings in core file because
no resources there
- split device tree changes
- Use _ as space for filenames in power/supply like the majority
- Replace gcc-845 freq_tbl frequencies patch with new approach,
based on automatic m/n/pre_div value generation
- Link to v3: https://lore.kernel.org/r/20240618-starqltechn_integration_upstream-v3-0-e3f6662017ac@gmail.com
Changes in version 3:
- disable crypto patch removed(disabled on distro level)
- dts framebuffer node along with related patches removed,
because panel driver added
- fix 'make O=.output_arm64 CHECK_DTBS=y qcom/sdm845-samsung-starqltechn.dtb'
errors, but it still complains on 'monitored-battery' and
'power-supplies' though I have 'power-supply.yaml' link in charger
and fuel gauge bindings.
---
Dzmitry Sankouski (14):
ASoC: dt-bindings: Add bindings for WCD934x DAIs
ASoC: codecs: wcd934x: use wcd934x binding header
arm64: dts: qcom: sdm845: enable gmu
arm64: dts: qcom: sdm845-starqltechn: remove wifi
arm64: dts: qcom: sdm845-starqltechn: fix usb regulator mistake
arm64: dts: qcom: sdm845-starqltechn: refactor node order
arm64: dts: qcom: sdm845-starqltechn: remove excess reserved gpios
arm64: dts: qcom: sdm845-starqltechn: add gpio keys
arm64: dts: qcom: sdm845-starqltechn: add max77705 PMIC
arm64: dts: qcom: sdm845-starqltechn: add display PMIC
arm64: dts: qcom: sdm845-starqltechn: add touchscreen support
arm64: dts: qcom: sdm845-starqltechn: add initial sound support
arm64: dts: qcom: sdm845-starqltechn: add graphics support
arm64: dts: qcom: sdm845-starqltechn: add modem support
MAINTAINERS | 1 +
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 4 -
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 -
arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 4 -
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 4 -
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 595 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 4 -
arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi | 4 -
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 4 -
arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 4 -
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 -
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 -
include/dt-bindings/sound/qcom,wcd934x.h | 16 ++++
sound/soc/codecs/wcd934x.c | 16 +---
14 files changed, 606 insertions(+), 60 deletions(-)
---
base-commit: d1486dca38afd08ca279ae94eb3a397f10737824
change-id: 20240617-starqltechn_integration_upstream-bc86850b2fe3
Best regards,
--
Dzmitry Sankouski <dsankouski@gmail.com>
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v8 01/14] ASoC: dt-bindings: Add bindings for WCD934x DAIs
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
@ 2024-12-09 12:09 ` Dzmitry Sankouski
2024-12-10 8:10 ` Krzysztof Kozlowski
2024-12-09 12:09 ` [PATCH v8 02/14] ASoC: codecs: wcd934x: use wcd934x binding header Dzmitry Sankouski
` (13 subsequent siblings)
14 siblings, 1 reply; 21+ messages in thread
From: Dzmitry Sankouski @ 2024-12-09 12:09 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Dzmitry Sankouski
Add bindings for the DAIs available in WCD934x to avoid
having to use unclear number indices in device trees.
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes in v8:
- remove #define NUM_CODEC_DAIS, because not binding constant
- fix intendation
---
MAINTAINERS | 1 +
include/dt-bindings/sound/qcom,wcd934x.h | 16 ++++++++++++++++
2 files changed, 17 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7700208f6ccf..f69ef5851298 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19015,6 +19015,7 @@ F: Documentation/devicetree/bindings/soc/qcom/qcom,apr*
F: Documentation/devicetree/bindings/sound/qcom,*
F: drivers/soc/qcom/apr.c
F: include/dt-bindings/sound/qcom,wcd9335.h
+F: include/dt-bindings/sound/qcom,wcd934x.h
F: sound/soc/codecs/lpass-rx-macro.*
F: sound/soc/codecs/lpass-tx-macro.*
F: sound/soc/codecs/lpass-va-macro.c
diff --git a/include/dt-bindings/sound/qcom,wcd934x.h b/include/dt-bindings/sound/qcom,wcd934x.h
new file mode 100644
index 000000000000..8b30d34fcc87
--- /dev/null
+++ b/include/dt-bindings/sound/qcom,wcd934x.h
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+
+#ifndef __DT_SOUND_QCOM_WCD934x_H
+#define __DT_SOUND_QCOM_WCD934x_H
+
+#define AIF1_PB 0
+#define AIF1_CAP 1
+#define AIF2_PB 2
+#define AIF2_CAP 3
+#define AIF3_PB 4
+#define AIF3_CAP 5
+#define AIF4_PB 6
+#define AIF4_VIFEED 7
+#define AIF4_MAD_TX 8
+
+#endif
--
2.39.5
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v8 02/14] ASoC: codecs: wcd934x: use wcd934x binding header
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 01/14] ASoC: dt-bindings: Add bindings for WCD934x DAIs Dzmitry Sankouski
@ 2024-12-09 12:09 ` Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 03/14] arm64: dts: qcom: sdm845: enable gmu Dzmitry Sankouski
` (12 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Dzmitry Sankouski @ 2024-12-09 12:09 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Dzmitry Sankouski
Replace AIF* enum with binding header include.
This allow to get rid of mysterious indeces in dts.
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes in v8:
- add #define NUM_CODEC_DAIS
---
sound/soc/codecs/wcd934x.c | 16 +++-------------
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c
index 910852eb9698..dd0cda394bf1 100644
--- a/sound/soc/codecs/wcd934x.c
+++ b/sound/soc/codecs/wcd934x.c
@@ -23,6 +23,8 @@
#include "wcd-clsh-v2.h"
#include "wcd-mbhc-v2.h"
+#include <dt-bindings/sound/qcom,wcd934x.h>
+
#define WCD934X_RATES_MASK (SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |\
SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_48000 |\
SNDRV_PCM_RATE_96000 | SNDRV_PCM_RATE_192000)
@@ -307,6 +309,7 @@
{"SLIM TX" #id, NULL, "CDC_IF TX" #id " MUX"}
#define WCD934X_MAX_MICBIAS MIC_BIAS_4
+#define NUM_CODEC_DAIS 9
enum {
SIDO_SOURCE_INTERNAL,
@@ -434,19 +437,6 @@ enum {
COMPANDER_MAX,
};
-enum {
- AIF1_PB = 0,
- AIF1_CAP,
- AIF2_PB,
- AIF2_CAP,
- AIF3_PB,
- AIF3_CAP,
- AIF4_PB,
- AIF4_VIFEED,
- AIF4_MAD_TX,
- NUM_CODEC_DAIS,
-};
-
enum {
INTn_1_INP_SEL_ZERO = 0,
INTn_1_INP_SEL_DEC0,
--
2.39.5
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v8 03/14] arm64: dts: qcom: sdm845: enable gmu
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 01/14] ASoC: dt-bindings: Add bindings for WCD934x DAIs Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 02/14] ASoC: codecs: wcd934x: use wcd934x binding header Dzmitry Sankouski
@ 2024-12-09 12:09 ` Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 04/14] arm64: dts: qcom: sdm845-starqltechn: remove wifi Dzmitry Sankouski
` (11 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Dzmitry Sankouski @ 2024-12-09 12:09 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Dzmitry Sankouski, Konrad Dybcio
Leave gmu enabled, because it's only probed when
GPU is.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes in v5:
- delete gmu node from sdm850-lenovo-yoga-c630
(it's imported from sdm845.dtsi)
---
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 4 ----
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ----
arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 4 ----
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 4 ----
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 4 ----
arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi | 4 ----
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 4 ----
arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 4 ----
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 --
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ----
10 files changed, 38 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
index 743c339ba108..b7e514f81f92 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
@@ -741,10 +741,6 @@ touchscreen@10 {
};
};
-&gmu {
- status = "okay";
-};
-
&gpu {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index 1cc0f571e1f7..92f8cc7e2fed 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -444,10 +444,6 @@ &gcc {
<GCC_LPASS_SWAY_CLK>;
};
-&gmu {
- status = "okay";
-};
-
&gpi_dma0 {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
index 2391f842c903..d31efad8a321 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
@@ -414,10 +414,6 @@ &gcc {
<GCC_LPASS_SWAY_CLK>;
};
-&gmu {
- status = "okay";
-};
-
&gpu {
status = "okay";
diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index 46e25c53829a..8a0f154bffc3 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -345,10 +345,6 @@ &gcc {
<GCC_LPASS_SWAY_CLK>;
};
-&gmu {
- status = "okay";
-};
-
&gpu {
status = "okay";
diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
index 486ce175e6bc..87fc4021e024 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
@@ -419,10 +419,6 @@ &gcc {
<GCC_LPASS_SWAY_CLK>;
};
-&gmu {
- status = "okay";
-};
-
&gpu {
status = "okay";
diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
index b02a1dc5fecd..a3a304e1ac87 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
@@ -415,10 +415,6 @@ &gcc {
<GCC_LPASS_SWAY_CLK>;
};
-&gmu {
- status = "okay";
-};
-
&gpi_dma0 {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
index 617b17b2d7d9..f790eb73abdd 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
@@ -239,10 +239,6 @@ &gcc {
<GCC_LPASS_SWAY_CLK>;
};
-&gmu {
- status = "okay";
-};
-
&gpu {
status = "okay";
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
index e386b504e978..501575c9beda 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
@@ -381,10 +381,6 @@ &gcc {
<GCC_LPASS_SWAY_CLK>;
};
-&gmu {
- status = "okay";
-};
-
&gpi_dma0 {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 1ed794638a7c..e9d5565b52e2 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -4948,8 +4948,6 @@ gmu: gmu@506a000 {
operating-points-v2 = <&gmu_opp_table>;
- status = "disabled";
-
gmu_opp_table: opp-table {
compatible = "operating-points-v2";
diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index f18050848cd8..ca81f3664abd 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -355,10 +355,6 @@ &gcc {
<GCC_LPASS_SWAY_CLK>;
};
-&gmu {
- status = "okay";
-};
-
&gpu {
status = "okay";
zap-shader {
--
2.39.5
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v8 04/14] arm64: dts: qcom: sdm845-starqltechn: remove wifi
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
` (2 preceding siblings ...)
2024-12-09 12:09 ` [PATCH v8 03/14] arm64: dts: qcom: sdm845: enable gmu Dzmitry Sankouski
@ 2024-12-09 12:09 ` Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 05/14] arm64: dts: qcom: sdm845-starqltechn: fix usb regulator mistake Dzmitry Sankouski
` (10 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Dzmitry Sankouski @ 2024-12-09 12:09 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Dzmitry Sankouski, Konrad Dybcio
Starqltechn has broadcom chip for wifi, so sdm845 wifi part
can be disabled.
Fixes: d711b22eee55 ("arm64: dts: qcom: starqltechn: add initial device tree for starqltechn")
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes in v6:
- refactor: no space between tag in commit message.
- refactor: s/starqltechn/sdm845-starqltechn in subject.
---
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
index d37a433130b9..6fc30fd1262b 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
@@ -418,14 +418,6 @@ &usb_1_qmpphy {
status = "okay";
};
-&wifi {
- vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
- vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
- vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
- vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
- status = "okay";
-};
-
&tlmm {
gpio-reserved-ranges = <0 4>, <27 4>, <81 4>, <85 4>;
--
2.39.5
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v8 05/14] arm64: dts: qcom: sdm845-starqltechn: fix usb regulator mistake
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
` (3 preceding siblings ...)
2024-12-09 12:09 ` [PATCH v8 04/14] arm64: dts: qcom: sdm845-starqltechn: remove wifi Dzmitry Sankouski
@ 2024-12-09 12:09 ` Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 06/14] arm64: dts: qcom: sdm845-starqltechn: refactor node order Dzmitry Sankouski
` (9 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Dzmitry Sankouski @ 2024-12-09 12:09 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Dzmitry Sankouski, Konrad Dybcio
Usb regulator was wrongly pointed to vreg_l1a_0p875.
However, on starqltechn it's powered from vreg_l5a_0p8.
Fixes: d711b22eee55 ("arm64: dts: qcom: starqltechn: add initial device tree for starqltechn")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes in v8:
- add tag: Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Changes in v6:
- refactor: no space between tag in commit message.
- refactor: s/starqltechn/sdm845-starqltechn in subject.
---
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
index 6fc30fd1262b..f3f2b25883d8 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
@@ -135,8 +135,6 @@ vdda_pll_cc_ebi23:
vdda_sp_sensor:
vdda_ufs1_core:
vdda_ufs2_core:
- vdda_usb1_ss_core:
- vdda_usb2_ss_core:
vreg_l1a_0p875: ldo1 {
regulator-min-microvolt = <880000>;
regulator-max-microvolt = <880000>;
@@ -157,6 +155,7 @@ vreg_l3a_1p0: ldo3 {
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
+ vdda_usb1_ss_core:
vdd_wcss_cx:
vdd_wcss_mx:
vdda_wcss_pll:
--
2.39.5
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v8 06/14] arm64: dts: qcom: sdm845-starqltechn: refactor node order
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
` (4 preceding siblings ...)
2024-12-09 12:09 ` [PATCH v8 05/14] arm64: dts: qcom: sdm845-starqltechn: fix usb regulator mistake Dzmitry Sankouski
@ 2024-12-09 12:09 ` Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 07/14] arm64: dts: qcom: sdm845-starqltechn: remove excess reserved gpios Dzmitry Sankouski
` (8 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Dzmitry Sankouski @ 2024-12-09 12:09 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Dzmitry Sankouski
Fixes: d711b22eee55 ("arm64: dts: qcom: starqltechn: add initial device tree for starqltechn")
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes in v6:
- refactor: no space between tag in commit message.
- refactor: s/starqltechn/sdm845-starqltechn in subject.
---
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
index f3f2b25883d8..8a0d63bd594b 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
@@ -382,8 +382,8 @@ &ufs_mem_phy {
};
&sdhc_2 {
- pinctrl-names = "default";
pinctrl-0 = <&sdc2_clk_state &sdc2_cmd_state &sdc2_data_state &sd_card_det_n_state>;
+ pinctrl-names = "default";
cd-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
vmmc-supply = <&vreg_l21a_2p95>;
vqmmc-supply = <&vddpx_2>;
--
2.39.5
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v8 07/14] arm64: dts: qcom: sdm845-starqltechn: remove excess reserved gpios
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
` (5 preceding siblings ...)
2024-12-09 12:09 ` [PATCH v8 06/14] arm64: dts: qcom: sdm845-starqltechn: refactor node order Dzmitry Sankouski
@ 2024-12-09 12:09 ` Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 08/14] arm64: dts: qcom: sdm845-starqltechn: add gpio keys Dzmitry Sankouski
` (7 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Dzmitry Sankouski @ 2024-12-09 12:09 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Dzmitry Sankouski, Konrad Dybcio
Starqltechn has 2 reserved gpio ranges <27 4>, <85 4>.
<27 4> is spi for eSE(embedded Secure Element).
<85 4> is spi for fingerprint.
Remove excess reserved gpio regions.
Fixes: d711b22eee55 ("arm64: dts: qcom: starqltechn: add initial device tree for starqltechn")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes in v6:
- refactor: no space between tag in commit message.
- refactor: s/starqltechn/sdm845-starqltechn in subject.
---
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
index 8a0d63bd594b..5948b401165c 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
@@ -418,7 +418,8 @@ &usb_1_qmpphy {
};
&tlmm {
- gpio-reserved-ranges = <0 4>, <27 4>, <81 4>, <85 4>;
+ gpio-reserved-ranges = <27 4>, /* SPI (eSE - embedded Secure Element) */
+ <85 4>; /* SPI (fingerprint reader) */
sdc2_clk_state: sdc2-clk-state {
pins = "sdc2_clk";
--
2.39.5
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v8 08/14] arm64: dts: qcom: sdm845-starqltechn: add gpio keys
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
` (6 preceding siblings ...)
2024-12-09 12:09 ` [PATCH v8 07/14] arm64: dts: qcom: sdm845-starqltechn: remove excess reserved gpios Dzmitry Sankouski
@ 2024-12-09 12:09 ` Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 09/14] arm64: dts: qcom: sdm845-starqltechn: add max77705 PMIC Dzmitry Sankouski
` (6 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Dzmitry Sankouski @ 2024-12-09 12:09 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Dzmitry Sankouski, Konrad Dybcio
Add support for phone buttons.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes in v8:
- add tag: Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Changes in v7:
- s/_/-/ in node name
- rename key labels
- move pm8998_gpios with chg_int_default pin
Changes in v6:
- refactor: s/starqltechn/sdm845-starqltechn in subject.
---
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
index 5948b401165c..38c09e50ccfb 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
@@ -7,9 +7,11 @@
/dts-v1/;
+#include <dt-bindings/input/linux-event-codes.h>
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
#include "sdm845.dtsi"
+#include "pm8998.dtsi"
/ {
chassis-type = "handset";
@@ -69,6 +71,25 @@ memory@a1300000 {
pmsg-size = <0x40000>;
};
};
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ autorepeat;
+
+ key-vol-up {
+ label = "Volume Up";
+ gpios = <&pm8998_gpios 6 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_VOLUMEUP>;
+ debounce-interval = <15>;
+ };
+
+ key-wink {
+ label = "Bixby";
+ gpios = <&pm8998_gpios 19 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_ENTER>;
+ debounce-interval = <15>;
+ };
+ };
};
@@ -417,6 +438,11 @@ &usb_1_qmpphy {
status = "okay";
};
+&pm8998_resin {
+ linux,code = <KEY_VOLUMEDOWN>;
+ status = "okay";
+};
+
&tlmm {
gpio-reserved-ranges = <27 4>, /* SPI (eSE - embedded Secure Element) */
<85 4>; /* SPI (fingerprint reader) */
--
2.39.5
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v8 09/14] arm64: dts: qcom: sdm845-starqltechn: add max77705 PMIC
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
` (7 preceding siblings ...)
2024-12-09 12:09 ` [PATCH v8 08/14] arm64: dts: qcom: sdm845-starqltechn: add gpio keys Dzmitry Sankouski
@ 2024-12-09 12:09 ` Dzmitry Sankouski
2024-12-13 23:57 ` Konrad Dybcio
2024-12-09 12:09 ` [PATCH v8 10/14] arm64: dts: qcom: sdm845-starqltechn: add display PMIC Dzmitry Sankouski
` (5 subsequent siblings)
14 siblings, 1 reply; 21+ messages in thread
From: Dzmitry Sankouski @ 2024-12-09 12:09 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Dzmitry Sankouski
Add support for max77705 MFD device. Supported sub-devices:
charger, fuelgauge, haptic, led
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes in v8:
- revert: add fuelgauge reg property
- rename chg_int_default to pmic_int_default, because used not only for
charging
Changes in v7:
- adjust fuelgauge node for max17042 driver
(remove monitored-battery because not supprted, rename
shunt resistor property)
- reorder 'haptic' fixed regulator node
- move 'haptic' fixed regulator node to regulators
- change leds compatible *-led *-rgb
- wrap leds into multi-led node
- add fuelgauge reg property
- wrap led properties into multi-led
- add chg_int_default pinctrl
Changes in v6:
- refactor: s/starqltechn/sdm845-starqltechn in subject
- refactor: 'm' < 's', so putting motor tlmm nodes first
Changes in v5:
- fix according to binding changes
- reorder vib_pwm node
---
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 125 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 125 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
index 38c09e50ccfb..7ed5aa23ba71 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
@@ -9,6 +9,7 @@
#include <dt-bindings/input/linux-event-codes.h>
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
#include "sdm845.dtsi"
#include "pm8998.dtsi"
@@ -18,6 +19,16 @@ / {
model = "Samsung Galaxy S9 SM-G9600";
compatible = "samsung,starqltechn", "qcom,sdm845";
+ battery: battery {
+ compatible = "simple-battery";
+ constant-charge-current-max-microamp = <2150000>;
+ charge-full-design-microamp-hours = <3000000>;
+
+ over-voltage-threshold-microvolt = <4500000>;
+ voltage-min-design-microvolt = <3400000>;
+ voltage-max-design-microvolt = <4350000>;
+ };
+
chosen {
#address-cells = <2>;
#size-cells = <2>;
@@ -32,6 +43,19 @@ framebuffer: framebuffer@9d400000 {
};
};
+ vib_regulator: gpio-regulator {
+ compatible = "regulator-fixed";
+
+ regulator-name = "haptic";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+
+ gpio = <&pm8998_gpios 18 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+
+ regulator-boot-on;
+ };
+
vph_pwr: vph-pwr-regulator {
compatible = "regulator-fixed";
regulator-name = "vph_pwr";
@@ -90,6 +114,17 @@ key-wink {
debounce-interval = <15>;
};
};
+
+ vib_pwm: pwm {
+ compatible = "clk-pwm";
+ #pwm-cells = <2>;
+ assigned-clock-parents = <&rpmhcc RPMH_CXO_CLK>;
+ assigned-clocks = <&gcc GCC_GP1_CLK_SRC>;
+ clocks = <&gcc GCC_GP1_CLK>;
+ pinctrl-0 = <&motor_pwm_default_state>;
+ pinctrl-1 = <&motor_pwm_suspend_state>;
+ pinctrl-names = "default", "suspend";
+ };
};
@@ -385,10 +420,74 @@ &qupv3_id_1 {
status = "okay";
};
+&gpi_dma1 {
+ status = "okay";
+};
+
&uart9 {
status = "okay";
};
+&i2c14 {
+ status = "okay";
+
+ pmic@66 {
+ compatible = "maxim,max77705";
+ reg = <0x66>;
+ interrupt-parent = <&pm8998_gpios>;
+ interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-0 = <&pmic_int_default>;
+ pinctrl-names = "default";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ leds {
+ compatible = "maxim,max77705-rgb";
+
+ multi-led {
+ color = <LED_COLOR_ID_RGB>;
+ function = LED_FUNCTION_STATUS;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_RED>;
+ };
+
+ led@2 {
+ reg = <2>;
+ color = <LED_COLOR_ID_GREEN>;
+ };
+
+ led@3 {
+ reg = <3>;
+ color = <LED_COLOR_ID_BLUE>;
+ };
+ };
+ };
+
+ max77705_charger: charger {
+ compatible = "maxim,max77705-charger";
+ monitored-battery = <&battery>;
+ };
+
+ fuel-gauge {
+ compatible = "maxim,max77705-battery";
+ power-supplies = <&max77705_charger>;
+ maxim,rsns-microohm = <5000>;
+ interrupt-parent = <&pm8998_gpios>;
+ interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+ };
+
+ haptic {
+ compatible = "maxim,max77705-haptic";
+ haptic-supply = <&vib_regulator>;
+ pwms = <&vib_pwm 0 100000>;
+ };
+ };
+};
+
&ufs_mem_hc {
reset-gpios = <&tlmm 150 GPIO_ACTIVE_LOW>;
vcc-supply = <&vreg_l20a_2p95>;
@@ -443,10 +542,36 @@ &pm8998_resin {
status = "okay";
};
+&pm8998_gpios {
+ pmic_int_default: pmic-int-default-state {
+ pins = "gpio11";
+ function = "normal";
+ input-enable;
+ bias-disable;
+ power-source = <0>;
+ };
+};
+
&tlmm {
gpio-reserved-ranges = <27 4>, /* SPI (eSE - embedded Secure Element) */
<85 4>; /* SPI (fingerprint reader) */
+ motor_pwm_default_state: motor-pwm-active-state {
+ pins = "gpio57";
+ function = "gcc_gp1";
+ drive-strength = <2>;
+ bias-disable;
+ output-high;
+ };
+
+ motor_pwm_suspend_state: motor-pwm-suspend-state {
+ pins = "gpio57";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ output-low;
+ };
+
sdc2_clk_state: sdc2-clk-state {
pins = "sdc2_clk";
bias-disable;
--
2.39.5
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v8 10/14] arm64: dts: qcom: sdm845-starqltechn: add display PMIC
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
` (8 preceding siblings ...)
2024-12-09 12:09 ` [PATCH v8 09/14] arm64: dts: qcom: sdm845-starqltechn: add max77705 PMIC Dzmitry Sankouski
@ 2024-12-09 12:09 ` Dzmitry Sankouski
2024-12-13 23:55 ` Konrad Dybcio
2024-12-09 12:09 ` [PATCH v8 11/14] arm64: dts: qcom: sdm845-starqltechn: add touchscreen support Dzmitry Sankouski
` (4 subsequent siblings)
14 siblings, 1 reply; 21+ messages in thread
From: Dzmitry Sankouski @ 2024-12-09 12:09 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Dzmitry Sankouski
Add support for s2dos05 display / touchscreen PMIC
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes in v7:
- move i2c21 node before gpio-keys
Changes in v6:
- refactor: s/starqltechn/sdm845-starqltechn in subject
- refactor: 'i' < 'm', so put tlmm i2c node before motor*
Changes in v5:
- simplify regulator names
- remove single buck index
---
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 77 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
index 7ed5aa23ba71..c4d8d7c0bf36 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
@@ -40,6 +40,9 @@ framebuffer: framebuffer@9d400000 {
height = <2960>;
stride = <(1440 * 4)>;
format = "a8r8g8b8";
+ vci-supply = <&s2dos05_ldo4>;
+ vddr-supply = <&s2dos05_buck>;
+ vdd3-supply = <&s2dos05_ldo1>;
};
};
@@ -96,6 +99,66 @@ memory@a1300000 {
};
};
+ i2c21 {
+ compatible = "i2c-gpio";
+ sda-gpios = <&tlmm 127 GPIO_ACTIVE_HIGH>;
+ scl-gpios = <&tlmm 128 GPIO_ACTIVE_HIGH>;
+ i2c-gpio,delay-us = <2>;
+ pinctrl-0 = <&i2c21_sda_state &i2c21_scl_state>;
+ pinctrl-names = "default";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@60 {
+ compatible = "samsung,s2dos05";
+ reg = <0x60>;
+
+ regulators {
+ s2dos05_ldo1: ldo1 {
+ regulator-active-discharge = <1>;
+ regulator-enable-ramp-delay = <12000>;
+ regulator-min-microvolt = <1500000>;
+ regulator-max-microvolt = <2000000>;
+ regulator-name = "ldo1";
+ };
+
+ s2dos05_ldo2: ldo2 {
+ regulator-active-discharge = <1>;
+ regulator-boot-on;
+ regulator-enable-ramp-delay = <12000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "ldo2";
+ };
+
+ s2dos05_ldo3: ldo3 {
+ regulator-active-discharge = <1>;
+ regulator-boot-on;
+ regulator-enable-ramp-delay = <12000>;
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-name = "ldo3";
+ };
+
+ s2dos05_ldo4: ldo4 {
+ regulator-active-discharge = <1>;
+ regulator-enable-ramp-delay = <12000>;
+ regulator-min-microvolt = <2700000>;
+ regulator-max-microvolt = <3775000>;
+ regulator-name = "ldo4";
+ };
+
+ s2dos05_buck: buck {
+ regulator-active-discharge = <1>;
+ regulator-enable-ramp-delay = <12000>;
+ regulator-min-microvolt = <850000>;
+ regulator-max-microvolt = <2100000>;
+ regulator-name = "buck";
+ };
+ };
+ };
+ };
+
gpio-keys {
compatible = "gpio-keys";
autorepeat;
@@ -556,6 +619,20 @@ &tlmm {
gpio-reserved-ranges = <27 4>, /* SPI (eSE - embedded Secure Element) */
<85 4>; /* SPI (fingerprint reader) */
+ i2c21_sda_state: i2c21-sda-state {
+ pins = "gpio127";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ i2c21_scl_state: i2c21-scl-state {
+ pins = "gpio128";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
motor_pwm_default_state: motor-pwm-active-state {
pins = "gpio57";
function = "gcc_gp1";
--
2.39.5
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v8 11/14] arm64: dts: qcom: sdm845-starqltechn: add touchscreen support
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
` (9 preceding siblings ...)
2024-12-09 12:09 ` [PATCH v8 10/14] arm64: dts: qcom: sdm845-starqltechn: add display PMIC Dzmitry Sankouski
@ 2024-12-09 12:09 ` Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 12/14] arm64: dts: qcom: sdm845-starqltechn: add initial sound support Dzmitry Sankouski
` (3 subsequent siblings)
14 siblings, 0 replies; 21+ messages in thread
From: Dzmitry Sankouski @ 2024-12-09 12:09 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Dzmitry Sankouski, Konrad Dybcio
Add support for samsung,s6sy761 touchscreen.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes in v8:
- add tag: Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Changes in v6:
- refactor: s/starqltechn/sdm845-starqltechn in subject
---
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
index c4d8d7c0bf36..65f33be55da3 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
@@ -573,6 +573,23 @@ &sdhc_2 {
status = "okay";
};
+&i2c11 {
+ clock-frequency = <400000>;
+ status = "okay";
+
+ touchscreen@48 {
+ compatible = "samsung,s6sy761";
+ reg = <0x48>;
+ interrupt-parent = <&tlmm>;
+ interrupts = <120 IRQ_TYPE_LEVEL_HIGH>;
+ vdd-supply = <&s2dos05_ldo2>;
+ avdd-supply = <&s2dos05_ldo3>;
+
+ pinctrl-0 = <&touch_irq_state>;
+ pinctrl-names = "default";
+ };
+};
+
&usb_1 {
status = "okay";
};
@@ -677,4 +694,15 @@ sd_card_det_n_state: sd-card-det-n-state {
function = "gpio";
bias-pull-up;
};
+
+ touch_irq_state: touch-irq-state {
+ pins = "gpio120";
+ function = "gpio";
+ bias-disable;
+ };
+};
+
+&qup_i2c11_default {
+ drive-strength = <2>;
+ bias-disable;
};
--
2.39.5
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v8 12/14] arm64: dts: qcom: sdm845-starqltechn: add initial sound support
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
` (10 preceding siblings ...)
2024-12-09 12:09 ` [PATCH v8 11/14] arm64: dts: qcom: sdm845-starqltechn: add touchscreen support Dzmitry Sankouski
@ 2024-12-09 12:09 ` Dzmitry Sankouski
2024-12-13 23:55 ` Konrad Dybcio
2024-12-09 12:09 ` [PATCH v8 13/14] arm64: dts: qcom: sdm845-starqltechn: add graphics support Dzmitry Sankouski
` (2 subsequent siblings)
14 siblings, 1 reply; 21+ messages in thread
From: Dzmitry Sankouski @ 2024-12-09 12:09 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Dzmitry Sankouski
Add support for sound (headphones and mics only)
Also redefine slpi reserved memory, because adsp_mem overlaps with
slpi_mem inherited from sdm845.dtsi.
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes in v8:
- clarify FM with FM -> FM radio
Changes in v7:
- replace indeces with constants from dt-bindings/sound/qcom,wcd9340.h
- add spaces after 'link-name' node
- remove not connected digital mics from audio routing
- add DMIC(0|2) -> MCLK routing, because digital mics
need clocks
- align mapping comments, add dmics comment
Changes in v6:
- refactor: s/starqltechn/sdm845-starqltechn in subject.
---
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 223 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 223 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
index 65f33be55da3..3a049459aeb3 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
@@ -11,8 +11,16 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+#include <dt-bindings/sound/qcom,q6afe.h>
+#include <dt-bindings/sound/qcom,q6asm.h>
+#include <dt-bindings/sound/qcom,wcd934x.h>
+
#include "sdm845.dtsi"
#include "pm8998.dtsi"
+#include "sdm845-wcd9340.dtsi"
+
+/delete-node/ &adsp_mem;
+/delete-node/ &slpi_mem;
/ {
chassis-type = "handset";
@@ -97,6 +105,16 @@ memory@a1300000 {
ftrace-size = <0x40000>;
pmsg-size = <0x40000>;
};
+
+ slpi_mem: slpi@96700000 {
+ reg = <0 0x96700000 0 0xf00000>;
+ no-map;
+ };
+
+ adsp_mem: memory@97800000 {
+ reg = <0 0x97800000 0 0x2000000>;
+ no-map;
+ };
};
i2c21 {
@@ -590,6 +608,211 @@ touchscreen@48 {
};
};
+&adsp_pas {
+ firmware-name = "qcom/sdm845/starqltechn/adsp.mbn";
+ status = "okay";
+};
+
+&lpasscc {
+ status = "okay";
+};
+
+&wcd9340 {
+ reset-gpios = <&tlmm 64 GPIO_ACTIVE_HIGH>;
+ vdd-buck-supply = <&vreg_s4a_1p8>;
+ vdd-buck-sido-supply = <&vreg_s4a_1p8>;
+ vdd-tx-supply = <&vreg_s4a_1p8>;
+ vdd-rx-supply = <&vreg_s4a_1p8>;
+ vdd-io-supply = <&vreg_s4a_1p8>;
+ qcom,micbias1-microvolt = <1800000>;
+ qcom,micbias2-microvolt = <2700000>;
+ qcom,micbias3-microvolt = <1800000>;
+ qcom,micbias4-microvolt = <1800000>;
+};
+
+&sound {
+ compatible = "qcom,sdm845-sndcard";
+ model = "Samsung Galaxy S9";
+ pinctrl-0 = <&quat_mi2s_active &quat_mi2s_sd0_active &quat_mi2s_sd1_active>;
+ pinctrl-names = "default";
+ status = "okay";
+
+ audio-routing = "RX_BIAS", "MCLK",
+ "AMIC2", "MIC BIAS2", /* Headset Mic */
+ "AMIC3", "MIC BIAS2", /* FM radio left Tx */
+ "AMIC4", "MIC BIAS2", /* FM radio right Tx */
+ "DMIC0", "MCLK", /* Bottom Mic */
+ "DMIC0", "MIC BIAS1",
+ "DMIC2", "MCLK", /* Top Mic */
+ "DMIC2", "MIC BIAS3";
+
+ mm1-dai-link {
+ link-name = "MultiMedia1";
+
+ cpu {
+ sound-dai = <&q6asmdai MSM_FRONTEND_DAI_MULTIMEDIA1>;
+ };
+ };
+
+ mm2-dai-link {
+ link-name = "MultiMedia2";
+
+ cpu {
+ sound-dai = <&q6asmdai MSM_FRONTEND_DAI_MULTIMEDIA2>;
+ };
+ };
+
+ mm3-dai-link {
+ link-name = "MultiMedia3";
+
+ cpu {
+ sound-dai = <&q6asmdai MSM_FRONTEND_DAI_MULTIMEDIA3>;
+ };
+ };
+
+ mm4-dai-link {
+ link-name = "MultiMedia4";
+
+ cpu {
+ sound-dai = <&q6asmdai MSM_FRONTEND_DAI_MULTIMEDIA4>;
+ };
+ };
+
+ mm5-dai-link {
+ link-name = "MultiMedia5";
+
+ cpu {
+ sound-dai = <&q6asmdai MSM_FRONTEND_DAI_MULTIMEDIA5>;
+ };
+ };
+
+ mm6-dai-link {
+ link-name = "MultiMedia6";
+
+ cpu {
+ sound-dai = <&q6asmdai MSM_FRONTEND_DAI_MULTIMEDIA6>;
+ };
+ };
+
+ slim-dai-link {
+ link-name = "SLIM Playback 1";
+
+ cpu {
+ sound-dai = <&q6afedai SLIMBUS_0_RX>;
+ };
+
+ platform {
+ sound-dai = <&q6routing>;
+ };
+
+ codec {
+ sound-dai = <&wcd9340 AIF1_PB>;
+ };
+ };
+
+ slimcap-dai-link {
+ link-name = "SLIM Capture 1";
+
+ cpu {
+ sound-dai = <&q6afedai SLIMBUS_0_TX>;
+ };
+
+ platform {
+ sound-dai = <&q6routing>;
+ };
+
+ codec {
+ sound-dai = <&wcd9340 AIF1_CAP>;
+ };
+ };
+
+ slim2-dai-link {
+ link-name = "SLIM Playback 2";
+
+ cpu {
+ sound-dai = <&q6afedai SLIMBUS_1_RX>;
+ };
+
+ platform {
+ sound-dai = <&q6routing>;
+ };
+
+ codec {
+ sound-dai = <&wcd9340 AIF2_PB>;
+ };
+ };
+
+ slimcap2-dai-link {
+ link-name = "SLIM Capture 2";
+
+ cpu {
+ sound-dai = <&q6afedai SLIMBUS_1_TX>;
+ };
+
+ platform {
+ sound-dai = <&q6routing>;
+ };
+
+ codec {
+ sound-dai = <&wcd9340 AIF2_CAP>;
+ };
+ };
+
+ slimcap3-dai-link {
+ link-name = "SLIM Capture 3";
+
+ cpu {
+ sound-dai = <&q6afedai SLIMBUS_2_TX>;
+ };
+
+ platform {
+ sound-dai = <&q6routing>;
+ };
+
+ codec {
+ sound-dai = <&wcd9340 AIF3_CAP>;
+ };
+ };
+};
+
+&q6afedai {
+ dai@22 {
+ reg = <22>;
+ qcom,sd-lines = <1>;
+ };
+
+ dai@23 {
+ reg = <23>;
+ qcom,sd-lines = <0>;
+ };
+};
+
+&q6asmdai {
+ dai@0 {
+ reg = <0>;
+ };
+
+ dai@1 {
+ reg = <1>;
+ };
+
+ dai@2 {
+ reg = <2>;
+ };
+
+ dai@3 {
+ reg = <3>;
+ };
+
+ dai@4 {
+ reg = <4>;
+ };
+
+ dai@5 {
+ reg = <5>;
+ };
+};
+
&usb_1 {
status = "okay";
};
--
2.39.5
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v8 13/14] arm64: dts: qcom: sdm845-starqltechn: add graphics support
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
` (11 preceding siblings ...)
2024-12-09 12:09 ` [PATCH v8 12/14] arm64: dts: qcom: sdm845-starqltechn: add initial sound support Dzmitry Sankouski
@ 2024-12-09 12:09 ` Dzmitry Sankouski
2024-12-13 23:57 ` Konrad Dybcio
2024-12-09 12:09 ` [PATCH v8 14/14] arm64: dts: qcom: sdm845-starqltechn: add modem support Dzmitry Sankouski
2025-02-07 14:02 ` (subset) [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Mark Brown
14 siblings, 1 reply; 21+ messages in thread
From: Dzmitry Sankouski @ 2024-12-09 12:09 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Dzmitry Sankouski
Add support for gpu and panel.
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes for v6:
- refactor: s/starqltechn/sdm845-starqltechn in subject
- refactor: remove 'sde' prefix in tlmm dsi nodes
- refactor: place tlmm dsi nodes alphabetically
Changes for v5:
- fix label names
---
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 67 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
index 3a049459aeb3..e709b2062152 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
@@ -208,6 +208,52 @@ vib_pwm: pwm {
};
};
+&gpu {
+ status = "okay";
+
+ zap-shader {
+ memory-region = <&gpu_mem>;
+ firmware-name = "qcom/sdm845/starqltechn/a630_zap.mbn";
+ };
+};
+
+&mdss {
+ status = "okay";
+};
+
+&mdss_dsi0 {
+ vdda-supply = <&vreg_l26a_1p2>;
+ status = "okay";
+
+ panel@0 {
+ compatible = "samsung,s6e3ha8";
+ reg = <0>;
+ vci-supply = <&s2dos05_ldo4>;
+ vddr-supply = <&s2dos05_buck>;
+ vdd3-supply = <&s2dos05_ldo1>;
+ te-gpios = <&tlmm 10 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
+ pinctrl-0 = <&dsi_default &dsi_te>;
+ pinctrl-1 = <&dsi_suspend &dsi_te>;
+ pinctrl-names = "default", "suspend";
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mdss_dsi0_out>;
+ };
+ };
+ };
+};
+
+&mdss_dsi0_out {
+ data-lanes = <0 1 2 3>;
+ remote-endpoint = <&panel_in>;
+};
+
+&mdss_dsi0_phy {
+ vdds-supply = <&vdda_mipi_dsi0_pll>;
+ status = "okay";
+};
&apps_rsc {
regulators-0 {
@@ -859,6 +905,27 @@ &tlmm {
gpio-reserved-ranges = <27 4>, /* SPI (eSE - embedded Secure Element) */
<85 4>; /* SPI (fingerprint reader) */
+ dsi_default: dsi-default-state {
+ pins = "gpio6";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-disable;
+ };
+
+ dsi_suspend: dsi-suspend-state {
+ pins = "gpio6";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ dsi_te: dsi-te-state {
+ pins = "gpio10";
+ function = "mdp_vsync";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
i2c21_sda_state: i2c21-sda-state {
pins = "gpio127";
function = "gpio";
--
2.39.5
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v8 14/14] arm64: dts: qcom: sdm845-starqltechn: add modem support
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
` (12 preceding siblings ...)
2024-12-09 12:09 ` [PATCH v8 13/14] arm64: dts: qcom: sdm845-starqltechn: add graphics support Dzmitry Sankouski
@ 2024-12-09 12:09 ` Dzmitry Sankouski
2025-02-07 14:02 ` (subset) [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Mark Brown
14 siblings, 0 replies; 21+ messages in thread
From: Dzmitry Sankouski @ 2024-12-09 12:09 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Dzmitry Sankouski, Konrad Dybcio
Add support for modem and ipa(IP Accelerator).
Add spss reserved memory node.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Changes in v6:
- refactor: s/starqltechn/sdm845-starqltechn in subject.
---
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
index e709b2062152..0d80599e893d 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
@@ -19,6 +19,8 @@
#include "pm8998.dtsi"
#include "sdm845-wcd9340.dtsi"
+/delete-node/ &rmtfs_mem;
+/delete-node/ &spss_mem;
/delete-node/ &adsp_mem;
/delete-node/ &slpi_mem;
@@ -106,15 +108,39 @@ memory@a1300000 {
pmsg-size = <0x40000>;
};
+ /*
+ * It seems like reserving the old rmtfs_mem region is also needed to prevent
+ * random crashes which are most likely modem related, more testing needed.
+ */
+ removed_region: removed-region@88f00000 {
+ reg = <0 0x88f00000 0 0x1c00000>;
+ no-map;
+ };
+
slpi_mem: slpi@96700000 {
reg = <0 0x96700000 0 0xf00000>;
no-map;
};
+ spss_mem: spss@97700000 {
+ reg = <0 0x97700000 0 0x100000>;
+ no-map;
+ };
+
adsp_mem: memory@97800000 {
reg = <0 0x97800000 0 0x2000000>;
no-map;
};
+
+ rmtfs_mem: rmtfs-mem@fde00000 {
+ compatible = "qcom,rmtfs-mem";
+ reg = <0 0xfde00000 0 0x202000>;
+ qcom,use-guard-pages;
+ no-map;
+
+ qcom,client-id = <1>;
+ qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>;
+ };
};
i2c21 {
@@ -859,6 +885,19 @@ dai@5 {
};
};
+&mss_pil {
+ firmware-name = "qcom/sdm845/starqltechn/mba.mbn",
+ "qcom/sdm845/starqltechn/modem.mbn";
+ status = "okay";
+};
+
+&ipa {
+ qcom,gsi-loader = "self";
+ memory-region = <&ipa_fw_mem>;
+ firmware-name = "qcom/sdm845/starqltechn/ipa_fws.mbn";
+ status = "okay";
+};
+
&usb_1 {
status = "okay";
};
--
2.39.5
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH v8 01/14] ASoC: dt-bindings: Add bindings for WCD934x DAIs
2024-12-09 12:09 ` [PATCH v8 01/14] ASoC: dt-bindings: Add bindings for WCD934x DAIs Dzmitry Sankouski
@ 2024-12-10 8:10 ` Krzysztof Kozlowski
0 siblings, 0 replies; 21+ messages in thread
From: Krzysztof Kozlowski @ 2024-12-10 8:10 UTC (permalink / raw)
To: Dzmitry Sankouski
Cc: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, linux-arm-msm, devicetree, linux-kernel,
linux-sound
On Mon, Dec 09, 2024 at 03:09:05PM +0300, Dzmitry Sankouski wrote:
> Add bindings for the DAIs available in WCD934x to avoid
> having to use unclear number indices in device trees.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> Changes in v8:
> - remove #define NUM_CODEC_DAIS, because not binding constant
> - fix intendation
> ---
> MAINTAINERS | 1 +
> include/dt-bindings/sound/qcom,wcd934x.h | 16 ++++++++++++++++
> 2 files changed, 17 insertions(+)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v8 12/14] arm64: dts: qcom: sdm845-starqltechn: add initial sound support
2024-12-09 12:09 ` [PATCH v8 12/14] arm64: dts: qcom: sdm845-starqltechn: add initial sound support Dzmitry Sankouski
@ 2024-12-13 23:55 ` Konrad Dybcio
0 siblings, 0 replies; 21+ messages in thread
From: Konrad Dybcio @ 2024-12-13 23:55 UTC (permalink / raw)
To: Dzmitry Sankouski, cros-qcom-dts-watchers, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound
On 9.12.2024 1:09 PM, Dzmitry Sankouski wrote:
> Add support for sound (headphones and mics only)
> Also redefine slpi reserved memory, because adsp_mem overlaps with
> slpi_mem inherited from sdm845.dtsi.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
>
> ---
> Changes in v8:
> - clarify FM with FM -> FM radio
>
> Changes in v7:
> - replace indeces with constants from dt-bindings/sound/qcom,wcd9340.h
> - add spaces after 'link-name' node
> - remove not connected digital mics from audio routing
> - add DMIC(0|2) -> MCLK routing, because digital mics
> need clocks
> - align mapping comments, add dmics comment
>
> Changes in v6:
> - refactor: s/starqltechn/sdm845-starqltechn in subject.
> ---
> arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 223 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 223 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
> index 65f33be55da3..3a049459aeb3 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
> @@ -11,8 +11,16 @@
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/leds/common.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +#include <dt-bindings/sound/qcom,q6afe.h>
> +#include <dt-bindings/sound/qcom,q6asm.h>
> +#include <dt-bindings/sound/qcom,wcd934x.h>
> +
> #include "sdm845.dtsi"
> #include "pm8998.dtsi"
> +#include "sdm845-wcd9340.dtsi"
> +
> +/delete-node/ &adsp_mem;
> +/delete-node/ &slpi_mem;
>
> / {
> chassis-type = "handset";
> @@ -97,6 +105,16 @@ memory@a1300000 {
> ftrace-size = <0x40000>;
> pmsg-size = <0x40000>;
> };
> +
> + slpi_mem: slpi@96700000 {
> + reg = <0 0x96700000 0 0xf00000>;
> + no-map;
> + };
> +
> + adsp_mem: memory@97800000 {
> + reg = <0 0x97800000 0 0x2000000>;
> + no-map;
> + };
> };
>
> i2c21 {
> @@ -590,6 +608,211 @@ touchscreen@48 {
> };
> };
>
> +&adsp_pas {
> + firmware-name = "qcom/sdm845/starqltechn/adsp.mbn";
> + status = "okay";
> +};
> +
> +&lpasscc {
> + status = "okay";
> +};
> +
> +&wcd9340 {
So this looks mostly good now.. but I noticed that the nodes are
referenced in rather random order, please re-sort the references
alphabetically
[...]
> + cpu {
> + sound-dai = <&q6afedai SLIMBUS_0_RX>;
> + };
> +
> + platform {
> + sound-dai = <&q6routing>;
> + };
> +
> + codec {
> + sound-dai = <&wcd9340 AIF1_PB>;
> + };
(and would be nice if these subnodes were sorted alphabetically too -
codec < cpu < platform)
Konrad
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v8 10/14] arm64: dts: qcom: sdm845-starqltechn: add display PMIC
2024-12-09 12:09 ` [PATCH v8 10/14] arm64: dts: qcom: sdm845-starqltechn: add display PMIC Dzmitry Sankouski
@ 2024-12-13 23:55 ` Konrad Dybcio
0 siblings, 0 replies; 21+ messages in thread
From: Konrad Dybcio @ 2024-12-13 23:55 UTC (permalink / raw)
To: Dzmitry Sankouski, cros-qcom-dts-watchers, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound
On 9.12.2024 1:09 PM, Dzmitry Sankouski wrote:
> Add support for s2dos05 display / touchscreen PMIC
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v8 09/14] arm64: dts: qcom: sdm845-starqltechn: add max77705 PMIC
2024-12-09 12:09 ` [PATCH v8 09/14] arm64: dts: qcom: sdm845-starqltechn: add max77705 PMIC Dzmitry Sankouski
@ 2024-12-13 23:57 ` Konrad Dybcio
0 siblings, 0 replies; 21+ messages in thread
From: Konrad Dybcio @ 2024-12-13 23:57 UTC (permalink / raw)
To: Dzmitry Sankouski, cros-qcom-dts-watchers, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound
On 9.12.2024 1:09 PM, Dzmitry Sankouski wrote:
> Add support for max77705 MFD device. Supported sub-devices:
> charger, fuelgauge, haptic, led
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v8 13/14] arm64: dts: qcom: sdm845-starqltechn: add graphics support
2024-12-09 12:09 ` [PATCH v8 13/14] arm64: dts: qcom: sdm845-starqltechn: add graphics support Dzmitry Sankouski
@ 2024-12-13 23:57 ` Konrad Dybcio
0 siblings, 0 replies; 21+ messages in thread
From: Konrad Dybcio @ 2024-12-13 23:57 UTC (permalink / raw)
To: Dzmitry Sankouski, cros-qcom-dts-watchers, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound
On 9.12.2024 1:09 PM, Dzmitry Sankouski wrote:
> Add support for gpu and panel.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: (subset) [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
` (13 preceding siblings ...)
2024-12-09 12:09 ` [PATCH v8 14/14] arm64: dts: qcom: sdm845-starqltechn: add modem support Dzmitry Sankouski
@ 2025-02-07 14:02 ` Mark Brown
14 siblings, 0 replies; 21+ messages in thread
From: Mark Brown @ 2025-02-07 14:02 UTC (permalink / raw)
To: cros-qcom-dts-watchers, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
Dzmitry Sankouski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-sound,
Konrad Dybcio, Konrad Dybcio
On Mon, 09 Dec 2024 15:09:04 +0300, Dzmitry Sankouski wrote:
> Contains starqltechn device tree changes.
> Add support for new features:
> - sound (headphones and mics only)
> - gpu
> - panel
> - buttons
> - MAX77705 MFD:
> - charger
> - fuelgauge
> - haptic
> - led
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[01/14] ASoC: dt-bindings: Add bindings for WCD934x DAIs
commit: 8478dadc8148af311c3d43d4867cfb6632686ede
[02/14] ASoC: codecs: wcd934x: use wcd934x binding header
commit: e27c125040b1e1f26d910b46daabbe55e67fdf3b
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2025-02-07 14:02 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-09 12:09 [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 01/14] ASoC: dt-bindings: Add bindings for WCD934x DAIs Dzmitry Sankouski
2024-12-10 8:10 ` Krzysztof Kozlowski
2024-12-09 12:09 ` [PATCH v8 02/14] ASoC: codecs: wcd934x: use wcd934x binding header Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 03/14] arm64: dts: qcom: sdm845: enable gmu Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 04/14] arm64: dts: qcom: sdm845-starqltechn: remove wifi Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 05/14] arm64: dts: qcom: sdm845-starqltechn: fix usb regulator mistake Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 06/14] arm64: dts: qcom: sdm845-starqltechn: refactor node order Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 07/14] arm64: dts: qcom: sdm845-starqltechn: remove excess reserved gpios Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 08/14] arm64: dts: qcom: sdm845-starqltechn: add gpio keys Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 09/14] arm64: dts: qcom: sdm845-starqltechn: add max77705 PMIC Dzmitry Sankouski
2024-12-13 23:57 ` Konrad Dybcio
2024-12-09 12:09 ` [PATCH v8 10/14] arm64: dts: qcom: sdm845-starqltechn: add display PMIC Dzmitry Sankouski
2024-12-13 23:55 ` Konrad Dybcio
2024-12-09 12:09 ` [PATCH v8 11/14] arm64: dts: qcom: sdm845-starqltechn: add touchscreen support Dzmitry Sankouski
2024-12-09 12:09 ` [PATCH v8 12/14] arm64: dts: qcom: sdm845-starqltechn: add initial sound support Dzmitry Sankouski
2024-12-13 23:55 ` Konrad Dybcio
2024-12-09 12:09 ` [PATCH v8 13/14] arm64: dts: qcom: sdm845-starqltechn: add graphics support Dzmitry Sankouski
2024-12-13 23:57 ` Konrad Dybcio
2024-12-09 12:09 ` [PATCH v8 14/14] arm64: dts: qcom: sdm845-starqltechn: add modem support Dzmitry Sankouski
2025-02-07 14:02 ` (subset) [PATCH v8 00/14] This is continued work on Samsung S9(SM-9600) starqltechn Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox