[PATCH v3 0/1] iio: pressure: bmp280: Minor cleanup

[PATCH v3 0/1] iio: pressure: bmp280: Minor cleanup

[Vasileios Amoiridis]

Changes in v3:

- Remove interrupts from  SPI example

---
v2: https://lore.kernel.org/linux-iio/20241202181907.21471-1-vassilisamir@gmail.com/
Changes in v2:

Patch 1/3:
	- Switch if case for better readability

Patch 2/3:
	- Reword commit message

---
v1: https://lore.kernel.org/linux-iio/20241128232450.313862-1-vassilisamir@gmail.com/

This series adds the SPI interface description on the device-tree file
of the sensor, adds proper self-described sized variables and performs
a minor optimization in time variable names.

Vasileios Amoiridis (1):
  dt-bindings: iio: pressure: bmp085: Add SPI interface

 .../bindings/iio/pressure/bmp085.yaml         | 30 +++++++++++++++++++
 1 file changed, 30 insertions(+)


base-commit: 5ab39233382c621d3271cc274d1534e1b687f4d3
-- 
2.43.0

[PATCH v3 1/1] dt-bindings: iio: pressure: bmp085: Add SPI interface

[Vasileios Amoiridis]

The BMP{2,3,5}80 and BME280 devices have an SPI interface, so include it
in the device-tree.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 .../bindings/iio/pressure/bmp085.yaml         | 30 +++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
index cb201cecfa1a..017abe8eb9c5 100644
--- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
+++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
@@ -55,12 +55,16 @@ properties:
       If not set, defaults to push-pull configuration.
     type: boolean
 
+  spi-max-frequency:
+    maximum: 10000000
+
 required:
   - compatible
   - vddd-supply
   - vdda-supply
 
 allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
   - if:
       properties:
         compatible:
@@ -73,6 +77,16 @@ allOf:
     then:
       properties:
         interrupts: false
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - bosch,bmp085
+              - bosch,bmp180
+    then:
+      properties:
+        spi-max-frequency: false
 
 additionalProperties: false
 
@@ -93,3 +107,19 @@ examples:
             vdda-supply = <&bar>;
         };
     };
+  - |
+    # include <dt-bindings/gpio/gpio.h>
+    # include <dt-bindings/interrupt-controller/irq.h>
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        pressure@0 {
+            compatible = "bosch,bmp280";
+            reg = <0>;
+            spi-max-frequency = <10000000>;
+            reset-gpios = <&gpio0 26 GPIO_ACTIVE_LOW>;
+            vddd-supply = <&foo>;
+            vdda-supply = <&bar>;
+        };
+    };
+
-- 
2.43.0

Re: [PATCH v3 1/1] dt-bindings: iio: pressure: bmp085: Add SPI interface

[Jonathan Cameron]

On Tue, 10 Dec 2024 00:38:45 +0100
Vasileios Amoiridis <vassilisamir@gmail.com> wrote:

> The BMP{2,3,5}80 and BME280 devices have an SPI interface, so include it
> in the device-tree.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
Stray blank line at end of file.  I fixed that up and applied,

Thanks,

Jonathan

> ---
>  .../bindings/iio/pressure/bmp085.yaml         | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> index cb201cecfa1a..017abe8eb9c5 100644
> --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> @@ -55,12 +55,16 @@ properties:
>        If not set, defaults to push-pull configuration.
>      type: boolean
>  
> +  spi-max-frequency:
> +    maximum: 10000000
> +
>  required:
>    - compatible
>    - vddd-supply
>    - vdda-supply
>  
>  allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
>    - if:
>        properties:
>          compatible:
> @@ -73,6 +77,16 @@ allOf:
>      then:
>        properties:
>          interrupts: false
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - bosch,bmp085
> +              - bosch,bmp180
> +    then:
> +      properties:
> +        spi-max-frequency: false
>  
>  additionalProperties: false
>  
> @@ -93,3 +107,19 @@ examples:
>              vdda-supply = <&bar>;
>          };
>      };
> +  - |
> +    # include <dt-bindings/gpio/gpio.h>
> +    # include <dt-bindings/interrupt-controller/irq.h>
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        pressure@0 {
> +            compatible = "bosch,bmp280";
> +            reg = <0>;
> +            spi-max-frequency = <10000000>;
> +            reset-gpios = <&gpio0 26 GPIO_ACTIVE_LOW>;
> +            vddd-supply = <&foo>;
> +            vdda-supply = <&bar>;
> +        };
> +    };
> +