The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Zijun Hu <zijun_hu@icloud.com>
To: Rob Herring <robh@kernel.org>,
	Saravana Kannan <saravanak@google.com>,
	 Maxime Ripard <mripard@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	 Grant Likely <grant.likely@secretlab.ca>
Cc: Zijun Hu <zijun_hu@icloud.com>,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Zijun Hu <quic_zijuhu@quicinc.com>,
	 stable@vger.kernel.org
Subject: [PATCH v2 3/7] of: Correct child specifier used as input of the 2nd nexus node
Date: Mon, 16 Dec 2024 08:40:42 +0800	[thread overview]
Message-ID: <20241216-of_core_fix-v2-3-e69b8f60da63@quicinc.com> (raw)
In-Reply-To: <20241216-of_core_fix-v2-0-e69b8f60da63@quicinc.com>

From: Zijun Hu <quic_zijuhu@quicinc.com>

API of_parse_phandle_with_args_map() will use wrong input for nexus node
Nexus_2 as shown below:

    Node_1		Nexus_1                              Nexus_2
&Nexus_1,arg_1 -> arg_1,&Nexus_2,arg_2' -> &Nexus_2,arg_2 -> arg_2,...
		  map-pass-thru=<...>

Nexus_1's output arg_2 should be used as input of Nexus_2, but the API
wrongly uses arg_2' instead which != arg_2 due to Nexus_1's map-pass-thru.

Fix by always making @match_array point to @initial_match_array into
which to store nexus output.

Fixes: bd6f2fd5a1d5 ("of: Support parsing phandle argument lists through a nexus node")
Cc: stable@vger.kernel.org
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
 drivers/of/base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index bf18d5997770eb81e47e749198dd505a35203d10..969b99838655534915882abe358814d505c6f748 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1536,7 +1536,6 @@ int of_parse_phandle_with_args_map(const struct device_node *np,
 		 * specifier into the out_args structure, keeping the
 		 * bits specified in <list>-map-pass-thru.
 		 */
-		match_array = map - new_size;
 		for (i = 0; i < new_size; i++) {
 			__be32 val = *(map - new_size + i);
 
@@ -1545,6 +1544,7 @@ int of_parse_phandle_with_args_map(const struct device_node *np,
 				val |= cpu_to_be32(out_args->args[i]) & pass[i];
 			}
 
+			initial_match_array[i] = val;
 			out_args->args[i] = be32_to_cpu(val);
 		}
 		out_args->args_count = list_size = new_size;

-- 
2.34.1


  parent reply	other threads:[~2024-12-16  0:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-16  0:40 [PATCH v2 0/7] of: fix bugs and improve codes Zijun Hu
2024-12-16  0:40 ` [PATCH v2 1/7] of: Fix API of_find_node_opts_by_path() finding OF device node failure Zijun Hu
2024-12-16  0:40 ` [PATCH v2 2/7] of: unittest: Add a test case for API of_find_node_opts_by_path() Zijun Hu
2024-12-16 19:23   ` Rob Herring
2024-12-16 21:29     ` Rob Herring
2024-12-16  0:40 ` Zijun Hu [this message]
2024-12-16  0:40 ` [PATCH v2 4/7] of: Exchange implementation between of_property_present() and of_property_read_bool() Zijun Hu
2024-12-16  0:40 ` [PATCH v2 5/7] of: Fix available buffer size calculating error in API of_device_uevent_modalias() Zijun Hu
2024-12-16  0:40 ` [PATCH v2 6/7] of: Fix potential wrong MODALIAS uevent value Zijun Hu
2024-12-16  3:42   ` kernel test robot
2024-12-16  3:52   ` kernel test robot
2024-12-16  7:02   ` kernel test robot
2024-12-16  0:40 ` [PATCH v2 7/7] of: Do not expose of_alias_scan() and correct its comments Zijun Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241216-of_core_fix-v2-3-e69b8f60da63@quicinc.com \
    --to=zijun_hu@icloud.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=quic_zijuhu@quicinc.com \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=saravanak@google.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox